From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id Y5HKOIFZomNUegEAbAwnHQ (envelope-from ) for ; Wed, 21 Dec 2022 01:55:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 4BYxN4FZomOgkwAAG6o9tA (envelope-from ) for ; Wed, 21 Dec 2022 01:55:29 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9ECD33D402 for ; Wed, 21 Dec 2022 01:55:29 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7nNz-0005wP-IU; Tue, 20 Dec 2022 19:55:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7nNu-0005vV-SI for guix-patches@gnu.org; Tue, 20 Dec 2022 19:55:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7nNu-0002Dp-J3 for guix-patches@gnu.org; Tue, 20 Dec 2022 19:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7nNu-00072G-1t for guix-patches@gnu.org; Tue, 20 Dec 2022 19:55:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60212] [PATCH] gnu: Add emacs-fzf. Resent-From: "jgart" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Dec 2022 00:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60212 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: mail@nicolasgoaziou.fr, 60212@debbugs.gnu.org Cc: 60212-done@debbugs.gnu.org X-Debbugs-Original-To: "Nicolas Goaziou" , "jgart via Guix-patches via" Received: via spool by submit@debbugs.gnu.org id=B.167158406127023 (code B ref -1); Wed, 21 Dec 2022 00:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Dec 2022 00:54:21 +0000 Received: from localhost ([127.0.0.1]:48245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7nNE-00071n-OM for submit@debbugs.gnu.org; Tue, 20 Dec 2022 19:54:21 -0500 Received: from lists.gnu.org ([209.51.188.17]:34902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7nNC-00071c-Nl for submit@debbugs.gnu.org; Tue, 20 Dec 2022 19:54:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7nNC-0005tn-AR for guix-patches@gnu.org; Tue, 20 Dec 2022 19:54:18 -0500 Received: from mx2.dismail.de ([159.69.191.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7nNA-00025e-AL for guix-patches@gnu.org; Tue, 20 Dec 2022 19:54:18 -0500 Received: from mx2.dismail.de (localhost [127.0.0.1]) by mx2.dismail.de (OpenSMTPD) with ESMTP id 414ec6ce; Wed, 21 Dec 2022 01:54:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h= mime-version:date:content-type:content-transfer-encoding:from :message-id:subject:to:cc:in-reply-to:references; s=20190914; bh=GRG1kwND5AUtJcb/D5vQ2HRelIWUbIA3C9TF1wWdV7Y=; b=XPRSe0kBkaQq EfWCXLS4Wceq8M3u7FC1NKGZPKmK4J0n8kbZmP3HQYk+Tw7nFgGOEEnrOrd0drpT HorxWS229IcIAREEWa7EM7wt0yJXUxB+vSgc+u66ceZ80Ftfpk+5C3pcrwKDP078 cKK6DsTFfEbDMtLDrMfYKhrEDwkYOab82Yo3osO0OOI/QkJwPtYbJAlgMKpOB74u hoWTzHp1V5sWkrUhvoTlRZ2OixmQCwi45bfI9zUyvgFPIBAp2LgZUidNFdCXrwAO ndNJu87HSVMmJ8Gxw1impgTK3GKKlnpyxypRMZalpLuF1obd5/B40ELjQjzmiR41 MJ8zeeBH5A== Received: from smtp1.dismail.de ( [10.240.26.11]) by mx2.dismail.de (OpenSMTPD) with ESMTP id 9a92c1e7; Wed, 21 Dec 2022 01:54:12 +0100 (CET) Received: from smtp1.dismail.de (localhost [127.0.0.1]) by smtp1.dismail.de (OpenSMTPD) with ESMTP id a4ed2e2c; Wed, 21 Dec 2022 01:54:12 +0100 (CET) Received: by dismail.de (OpenSMTPD) with ESMTPSA id 90e37d50 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 21 Dec 2022 01:54:12 +0100 (CET) MIME-Version: 1.0 Date: Wed, 21 Dec 2022 00:54:11 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: RainLoop/1.16.0a Message-ID: <6dc428a54acf3ee157fd1a2784aa76b0@dismail.de> In-Reply-To: <87ili6cqx5.fsf@nicolasgoaziou.fr> References: <87ili6cqx5.fsf@nicolasgoaziou.fr> <20221220032916.5047-1-jgart@dismail.de> Received-SPF: pass client-ip=159.69.191.136; envelope-from=jgart@dismail.de; helo=mx2.dismail.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: jgart X-ACL-Warn: , jgart via Guix-patches From: jgart via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b=XPRSe0kB; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671584129; a=rsa-sha256; cv=none; b=EsK6hH72ro3etx3c7zNvJbKQI0p0kjBrEL49OKTFUSdnKGr63CQBN9IDXcIGkRnt/QWsyb DyCU9Tj3rsWphEZW4p9ABf9zmMBZquCRbYbENaNTDA7OLEET7m4gRh8Iy3jrm7RcGTde4t C9kSh3kYJ/4FukEJCKXvFZsuHgAIZ6cnVompQCqGCZsjUtBkVLT8xlk0Pl9b7f11/9X92/ IIOrkX5HHcDoPq3Kmc3qrJM+f3shgTATv4vWcVBas418gUeRODYX6ROGrPPOnwgy1Fmtko Ry0iE60Ghx9Lwihg6kZXfMVhoU2/3pLGNEuHYtXYNJ7ftRmcYFDEDnn7esWysg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671584129; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GRG1kwND5AUtJcb/D5vQ2HRelIWUbIA3C9TF1wWdV7Y=; b=bhnMjVSaHI8a074F9Z4ijPSNBxsU95GY7ni95kyv8A5F4sOen33iOqjm2ryvrQ5Nxho+RH 6i7BUi1EdThhQb5j5mCPtpUq7nfzaX4+cJ1QrvRjb0wShUQf1uG66Zjn/enbO2OYISXSof h1bBEW++5Q6AjlFQgI8G43kIUDlVvZwLfwA9ctmL9rruJiejh7cml6pLjndrB97CYaMyd8 idQPukUm2WT3Fc56njYSkub+qEFT6bOAr1U4ZZ+wNV6/lGv7m1Ct9ggGDpIgqavFz363rk fbaJIOqEBF8PcLAlDqE6dZnEfpuz+fh28Zm8pPbGMqd0/ttRWTb42tNDS6em0w== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=dismail.de header.s=20190914 header.b=XPRSe0kB; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -2.39 X-Spam-Score: -2.39 X-Migadu-Queue-Id: 9ECD33D402 X-TUID: 6Bnm0vxx/ffs I keep forgetting re @command I'll stop doing that. It has become a habit. Thanks for the review! It's much appreciated, jgart https://whereis.=E3=81=BF=E3=82=93=E3=81=AA/ December 20, 2022 4:26 AM, "Nicolas Goaziou" wro= te: > Hello, >=20 >=20jgart via Guix-patches via writes: >=20 >>=20* gnu/packages/emacs-xyz.scm (emacs-fzf): New variable. >=20 >=20Thank you. >=20 >>=20+ #~(modify-phases %standard-phases >> + (add-after 'unpack 'patch-fzf-executable >> + (lambda* (#:key inputs #:allow-other-keys) >> + (make-file-writable "fzf.el") >=20 >=20Nitpick: The expression above is usually not necessary, even though s= ome > package definitions use it. >=20 >>=20+ (emacs-substitute-variables "fzf.el" >> + ("fzf/executable" (search-input-file inputs "/bin/fzf")))))))) >> + (inputs (list fzf)) >> + (home-page "https://github.com/bling/fzf.el") >> + (synopsis "Front-end for fzf") >=20 >=20I expounded it a bit. >=20 >>=20+ (description "An @command{emacs} front-end for @command{fzf}.") >=20 >=20Please write full sentences in descriptions, even if upstream does no= t. >=20 >=20Also, "@command{emacs}" conveys no more information than "Emacs". So > does "@command{fzf}" vs "Fzf". The simpler the better, IMO. >=20 >=20Applied! >=20 >=20Regards, > -- > Nicolas Goaziou