all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Prikler <leo.prikler@student.tugraz.at>
To: 宋文武 <iyzsong@outlook.com>, rg@raghavgururajan.name
Cc: leo@famulari.name, 47643@debbugs.gnu.org
Subject: [bug#47643] WIP-GNOME
Date: Sat, 10 Apr 2021 15:19:58 +0200	[thread overview]
Message-ID: <6da3be185feabe72da9290926b10a832e8682240.camel@student.tugraz.at> (raw)
In-Reply-To: <OSZP286MB0664670ABA3D0807887D3271A3729@OSZP286MB0664.JPNP286.PROD.OUTLOOK.COM>

Hi,
Am Samstag, den 10.04.2021, 19:24 +0800 schrieb 宋文武:
> Leo Prikler <leo.prikler@student.tugraz.at> writes:
> 
> > Hi,
> > 
> > I've cleaned up your GStreamer patches a little and rebased them on
> > staging.
> > The patch set I'm about to send should both apply cleanly and
> > build, but I
> > haven't yet tested, whether it also runs okay.
> 
> Thank you!
> I have replied my reviews to the patches and here will do a summary.
> 
> > Raghav Gururajan (10):
> >   gnu: gstreamer: Update to 1.18.4.
> gtk+ is only used for an example, so I think we can remove it from
> inputs.
I agree.

> >   gnu: gst-plugins-base: Update to 1.18.4.
> >   gnu: gst-plugins-base: Add missing inputs to enable more
> > features.
> First patch should only make the update, and I think the second patch
> have some uncessary inputs.
Indeed, it seems this would build fine if we just did a version bump. 
At least it should if we go by version numbers alone.

> >   gnu: gst-plugins-good: Update to 1.18.4.
> >   gnu: gst-plugins-ugly: Update to 1.18.4.
> >   gnu: gst-libav: Update to 1.18.4.
> Trivial updates are good..
> 
> >   gnu: gst-plugins-bad: Update to 1.18.4.
> >   gnu: gst-plugins-bad: Add missing inputs to enable more features.
> >   gnu: gst-plugins-bad: Disable few more failing tests.
> I think there should be 2 patches, one for update, and one for enable
> more features.  Disable failing tests should be include into the
> first
> one which broken tests (or 3 patches if tests are already broken).
As far as I know, we already disable some broken tests, but those that
we don't disable should be fine.  So we should aim for 2 patches here.

> >   gnu: gst-editing-services: Update to 1.18.4.
> Also one for update, one for enable more features if possible.
> 
> And I don't think wrap thoes packages with 'glib-or-gtk? t' with
> inputs
> as glib-networking, gsettings-desktop-schema are very useful, maybe
> I'm
> wrong?
I think you're right, but it might be my bias as someone already
running GNOME.  We might want to test, whether gstreamer+gtk works in a
pure environment to make sure, that wrapping it is not required in some
fringe setting.  That said, I find it perfectly acceptable for
gstreamer to take these directly from the environment, since it's the
same for the plugins themselves.

> >  gnu/packages/gstreamer.scm | 262 ++++++++++++++++++++++++++++-----
> > ----
> >  1 file changed, 199 insertions(+), 63 deletions(-)
> > 
> > --
> > 2.31.1
> 
> In the end, 2 trivial update patches for gstreamer-docs and gst-
> python:
Thanks.  I'm a bit busy today, so I won't find the time to apply all
the suggested changes.  Is anyone else interested in forming a v2?

Regards,
Leo





  reply	other threads:[~2021-04-10 13:21 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07 19:30 [bug#47643] WIP-GNOME Raghav Gururajan via Guix-patches via
2021-04-07 20:42 ` [bug#47643] [PATCH 01/22] gnu: gstreamer: Update to 1.18.4 Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 02/22] gnu: gst-plugins-base: Fix indentation Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 03/22] gnu: gst-plugins-base: Update to 1.18.4 Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 04/22] gnu: gst-plugins-base: Add missing inputs to enable more features Raghav Gururajan via Guix-patches via
2021-04-08 23:22     ` Leo Famulari
2021-04-08 23:32       ` Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 05/22] gnu: gst-plugins-good: Update to 1.18.4 Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 06/22] gnu: gst-plugins-ugly: " Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 07/22] gnu: ibus: Update to 1.5.24 Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 08/22] gnu: ibus: Enable documentation Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 09/22] gnu: ibus: Enable memconf Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 10/22] gnu: ibus: Enable tests Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 11/22] gnu: librsvg: Correct unbound variable Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 12/22] gnu: gst-libav: Update to 1.18.4 Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 13/22] gnu: iqa: Correct source uri Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 14/22] gnu: faac: " Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 15/22] gnu: zbar: Update to 0.23.92 Raghav Gururajan via Guix-patches via
2021-04-08 23:18     ` Leo Famulari
2021-04-09  2:21       ` Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 16/22] gnu: transcode: Disable v4l support due to broken API Raghav Gururajan via Guix-patches via
2021-04-09 10:58     ` Léo Le Bouter via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 17/22] gnu: flite: Update to 2.2 Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 18/22] gnu: gst-plugins-bad: Fix indentation Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 19/22] gnu: gst-plugins-bad: Update to 1.18.4 Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 20/22] gnu: gst-plugins-bad: Add missing inputs to enable more features Raghav Gururajan via Guix-patches via
2021-04-08 23:20     ` Leo Famulari
2021-04-08 23:29       ` Raghav Gururajan via Guix-patches via
2021-04-09  8:28       ` Leo Prikler
2021-04-07 20:42   ` [bug#47643] [PATCH 21/22] gnu: gst-plugins-bad: Disable few more failing tests Raghav Gururajan via Guix-patches via
2021-04-07 20:42   ` [bug#47643] [PATCH 22/22] gnu: gst-editing-services: Update to 1.18.4 Raghav Gururajan via Guix-patches via
2021-04-09 18:38 ` [bug#47643] [PATCH staging 00/10] Update GStreamer " Leo Prikler
2021-04-09 18:38   ` [bug#47643] [PATCH staging 01/10] gnu: gstreamer: Update " Leo Prikler
2021-04-10  8:47     ` [bug#47643] WIP-GNOME 宋文武
2021-04-10 10:38       ` [bug#47643] WIP-GNOME: gstreamer 宋文武
2021-04-09 18:38   ` [bug#47643] [PATCH staging 02/10] gnu: gst-plugins-base: Update to 1.18.4 Leo Prikler
2021-04-10 10:35     ` [bug#47643] WIP-GNOME: gst-plugins-base 宋文武
2021-04-10 12:06       ` Raghav Gururajan via Guix-patches via
2021-04-09 18:38   ` [bug#47643] [PATCH staging 03/10] gnu: gst-plugins-base: Add missing inputs to enable more features Leo Prikler
2021-04-10 11:00     ` [bug#47643] WIP-GNOME: gst-plugins-base 宋文武
2021-04-10 12:09       ` Raghav Gururajan via Guix-patches via
2021-04-09 18:38   ` [bug#47643] [PATCH staging 04/10] gnu: gst-plugins-good: Update to 1.18.4 Leo Prikler
2021-04-09 18:38   ` [bug#47643] [PATCH staging 05/10] gnu: gst-plugins-ugly: " Leo Prikler
2021-04-09 18:38   ` [bug#47643] [PATCH staging 06/10] gnu: gst-libav: " Leo Prikler
2021-04-09 18:38   ` [bug#47643] [PATCH staging 07/10] gnu: gst-plugins-bad: " Leo Prikler
2021-04-09 19:33     ` Maxime Devos
2021-04-09 19:53       ` Leo Prikler
2021-04-10 10:13         ` Maxime Devos
2021-04-09 18:38   ` [bug#47643] [PATCH staging 08/10] gnu: gst-plugins-bad: Add missing inputs to enable more features Leo Prikler
2021-04-09 18:38   ` [bug#47643] [PATCH staging 09/10] gnu: gst-plugins-bad: Disable few more failing tests Leo Prikler
2021-04-09 18:38   ` [bug#47643] [PATCH staging 10/10] gnu: gst-editing-services: Update to 1.18.4 Leo Prikler
2021-04-10 11:24   ` [bug#47643] WIP-GNOME 宋文武
2021-04-10 13:19     ` Leo Prikler [this message]
2021-04-12  9:36 ` [bug#47643] [PATCH staging v2 1/9] gnu: gstreamer: Update to 1.18.4 Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 2/9] gnu: gst-plugins-base: " Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 3/9] gnu: gst-plugins-base: Enable more features Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 4/9] gnu: gst-plugins-good: Update to 1.18.4 Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 5/9] gnu: gst-plugins-ugly: " Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 6/9] gnu: gst-libav: " Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 7/9] gnu: gst-plugins-bad: " Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 8/9] gnu: gst-plugins-bad: Add missing inputs to enable more features Leo Prikler
2021-04-12  9:36   ` [bug#47643] [PATCH staging v2 9/9] gnu: gst-editing-services: Update to 1.18.4 Leo Prikler
2021-04-12 14:57     ` Maxime Devos
2021-04-12 15:59       ` Leo Prikler
2021-04-14 10:57 ` [bug#47643] [PATCH v2 06/18] gnu: ibus: Update to 1.5.24 Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 07/18] gnu: ibus: Enable documentation Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 08/18] gnu: ibus: Enable memconf Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 09/18] gnu: ibus: Enable tests Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 10/18] gnu: librsvg: Correct unbound variable Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 12/18] gnu: iqa: Correct source uri Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 13/18] gnu: faac: " Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 14/18] gnu: zbar: Update to 0.23.90 Raghav Gururajan via Guix-patches via
2021-04-14 10:57   ` [bug#47643] [PATCH v2 15/18] gnu: transcode: Disable v4l support due to broken API Raghav Gururajan via Guix-patches via
2021-04-14 12:08 ` [bug#47643] [PATCH core-updates 0/5]: Non-topical changes Raghav Gururajan via Guix-patches via
2021-04-14 12:08 ` [bug#47643] [PATCH core-updates 1/5] gnu: librsvg: Correct unbound variable Raghav Gururajan via Guix-patches via
2021-04-14 12:08   ` [bug#47643] [PATCH core-updates 2/5] gnu: iqa: Correct source uri Raghav Gururajan via Guix-patches via
2021-04-14 12:08   ` [bug#47643] [PATCH core-updates 3/5] gnu: faac: " Raghav Gururajan via Guix-patches via
2021-04-14 12:08   ` [bug#47643] [PATCH core-updates 4/5] gnu: zbar: Update to 0.23.90 Raghav Gururajan via Guix-patches via
2021-04-14 12:08   ` [bug#47643] [PATCH core-updates 5/5] gnu: transcode: Disable v4l support due to broken API Raghav Gururajan via Guix-patches via
2021-04-19 16:58 ` bug#47643: (no subject) Raghav Gururajan via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6da3be185feabe72da9290926b10a832e8682240.camel@student.tugraz.at \
    --to=leo.prikler@student.tugraz.at \
    --cc=47643@debbugs.gnu.org \
    --cc=iyzsong@outlook.com \
    --cc=leo@famulari.name \
    --cc=rg@raghavgururajan.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.