From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YIyGD2GHuWLADwEAbAwnHQ (envelope-from ) for ; Mon, 27 Jun 2022 12:33:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id WONVD2GHuWIdSAEAauVa8A (envelope-from ) for ; Mon, 27 Jun 2022 12:33:05 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DDAB3427C7 for ; Mon, 27 Jun 2022 12:33:04 +0200 (CEST) Received: from localhost ([::1]:41210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5m3C-0005OQ-L4 for larch@yhetil.org; Mon, 27 Jun 2022 06:33:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5m1C-0004lq-Hj for guix-devel@gnu.org; Mon, 27 Jun 2022 06:31:00 -0400 Received: from laurent.telenet-ops.be ([2a02:1800:110:4::f00:19]:41350) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5m1A-0006Zz-7F for guix-devel@gnu.org; Mon, 27 Jun 2022 06:30:58 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id oAWr2700i4UW6Th01AWsCz; Mon, 27 Jun 2022 12:30:52 +0200 Message-ID: <6d2b1052b3e63a67c42c4e6ce431b3f1bb4b4605.camel@telenet.be> Subject: Re: Dealing with upstream issues From: Maxime Devos To: Ludovic =?ISO-8859-1?Q?Court=E8s?= Cc: Tobias Kortkamp , guix-devel@gnu.org Date: Mon, 27 Jun 2022 12:30:48 +0200 In-Reply-To: <87r13aifi3.fsf_-_@gnu.org> References: <6d31ff958ec0c75cbba8324a275315d195a54902.1653045472.git.tobias.kortkamp@gmail.com> <87sfntu6ft.fsf@gnu.org> <87r13aifi3.fsf_-_@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-7L9DZFbUmJgCTs9Ab1ls" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1656325852; bh=31zBDOwJZhmEb0JAKgMijsya291EUh+Cwlr1qeCeLrI=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=OH1m2RDVAQWmPoRTNt1KTnHqSWHjquHyh4y3XZWJcTp2gpm50hIcTFnoS2ayxmOyq Nz62Zsua5gbWdzW5LAsDXKKYUK4MN9F8Lhh7Xnq3tmMiU/idhA6814+SQBZIWV1Bol R9PrqTLUoTjYXPTicq6VdVKEKDxeAWF89V/sn1gi8+uj8Y9EnqFc1+vlnBFemjVXy+ c6/3IzBNbJx48DAY0qExrjGdLysr9ZWCkRrYre7yYpuw55100DLALFkKaZg0a+ri+x WE0CV8x5YPbm2jdHDMiH013CR8Xjco+QR700c48kAbp7eEV1fpshYlyUJcm+KDIivW bYKXhHkUFu1jA== Received-SPF: pass client-ip=2a02:1800:110:4::f00:19; envelope-from=maximedevos@telenet.be; helo=laurent.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656325984; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=31zBDOwJZhmEb0JAKgMijsya291EUh+Cwlr1qeCeLrI=; b=nPsMFCEMSzLQzj3y1V6Zr4zyT0R7cQXfw9kYArQDtvti6Bnwr4qb0GKbSjOkAYW0NgCwMC v9sNz359jgTb8P66p2pQZVBh6YsRFllN5BizU2VR/c8cSc/wQbeiKnP2VSwviwyabPQws5 ctU8+HBSOpZYGcbFvMNLEFkWi/r9JRkSOKFDk5bagxRCVPQSqBqDMxlmigiseKirxTIHMF kvP+s8FFPafX87OVRrUcl7mqjeh1EFtNhYt0IHzctJ/o23l7t0HY1Jc3D1W1xHtv6ZWgFT oCAurlwXR9e/1R0gdHkTzSKAigJNdf/BmeTRvmcFgOA/QFN9JydUtL1hhuH4kQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656325984; a=rsa-sha256; cv=none; b=kXrmvn81erdTN84MeBjg8p+2ZDgDRedu6eZFimAqh4rITObeUcS1UmB6J64imA5RWNysGs de2HGRy66xizGy1zyKXUUrl/u0fFYn2EN4wNrRvcBDusjlxfhp3DA7PxGvmFWHRWDB/Jtv KtBT5wHyXUcZxyq4b0pDWGWPzX/Q1+VVYc7K0pu406mTUNLLrcIlpvMDQqshnaHnT+128U kP6rv5emwzV1kdEPrEw5XgsqDcrH3HD/3350uIN7NB5twx5FS5I99UokvwqRxE4Akrebwl l0dy9ZZH1eVEjOw+Nce01axm6LNPrm3DqXbKRu+DheN6ykbnYivvg9xEQnlzHg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r22 header.b=OH1m2RDV; dmarc=pass (policy=none) header.from=telenet.be; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -7.45 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=telenet.be header.s=r22 header.b=OH1m2RDV; dmarc=pass (policy=none) header.from=telenet.be; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DDAB3427C7 X-Spam-Score: -7.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: waCoZ2g30RDt --=-7L9DZFbUmJgCTs9Ab1ls Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s schreef op ma 27-06-2022 om 12:10 [+0200]: > Regarding the review process, I think we should strive for a predictable > process=E2=80=94not requesting work from the submitter beyond what they c= an > expect.=C2=A0 Submitters can be expected to follow the written rules=C2= =B9 and > perhaps a few more rules (for example, I don=E2=80=99t think we=E2=80=99v= e documented > the fact that #:tests? #f is a last resort and should come with a > comment).=C2=A0 >=20 > However, following that principle, we reviewers cannot > reasonably ask for work beyond that. [...] We can ask to do send the notice upstream, if it's in the rules (I consider this to be part of the unwritten rules). And I don't often have time for addressing the noticed issues and I have other things to do as well -- I usually limit myself to just reviewing. I do not intend to take up work beyond that. I also consider them to not be rules as in =E2=80=98if they are followed, i= t WILL be accepted=E2=80=99 but more guidelines like =E2=80=98these things ar= e important, they usually need to be followed, but it's not exhaustive, at times it might be discovered the list is incomplete=E2=80=99. I don't think that patch submitters can reasonably expect reviewers to do all the work. Also, previously in discussions about the review process, weren't there points about a reviewer not having to do everything all at once, they could choose to review parts they know how to review and have time for and leave the rest for others? > Related to that, I think it=E2=80=99s important to have a consistent revi= ew > process. In other words, we should be equally demanding for all > patches to avoid bad surprises or a feeling of double standard. I think I've been consistent in asking to inform upstream of the issues (*), with no distinction of whether it's a new submitter or an established one or whatever. (*) Except for when it's really basic downstream changes, like #:make- flags #~(list ... #$(cc-for-target)) or a substitute* cc -> TARGET-gcc. Greetings, Maxime. --=-7L9DZFbUmJgCTs9Ab1ls Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYrmG2BccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7loyAP4kf4xSehYEanJEfk0DTz8lbDV1 SPJXLAVrA4C1zWOyFAD/erXthnCkJbwc5yObB1GQtEUvxnwLmu/Yf9M7oJhR5Qw= =Jauv -----END PGP SIGNATURE----- --=-7L9DZFbUmJgCTs9Ab1ls--