From: Sahithi Yarlagadda <sahi@swecha.net>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 30894@debbugs.gnu.org
Subject: [bug#30894] Submission of patch for Add r-abc
Date: Thu, 29 Mar 2018 15:45:19 +0530 [thread overview]
Message-ID: <6c9c531d-75a5-be08-2784-ebae3c3a432b@swecha.net> (raw)
In-Reply-To: <87vadgdlyd.fsf@elephly.net>
[-- Attachment #1: Type: text/plain, Size: 3921 bytes --]
Hi Ricardo
I have a small doubt regarding the build. Let me explain the process i
am doing the build.
1) Cloning the Source
2) Running guix environment guix
3) ./bootstrap
4) ./configure --localstatedir=/var
5) make
6) Make Changes to the cran.scm file
7) Build using ./pre-inst-env guix build <package>
8) If build is success, format the patch and submit the patch
*When i am planning to write a different package description, i am
following this*
9) rebasing the patch
10) Pull for any changes
11) running the process from (2)
Am i doing the right way, I hope i have to compile everytime and then
make changes each Package Description. Because when i tired to just make
changes and build on old one, i got many errors and warning saying the
.go file is older than the .scm.
Please suggest me.
On Thursday 29 March 2018 01:14 AM, Ricardo Wurmus wrote:
> Hi Sahiti,
>
> have you been able to look at my review below?
> Please let me know if anything is unclear.
>
> ~~ Ricardo
>
> Ricardo Wurmus <rekado@elephly.net> writes:
>
>> Hi Sahithi,
>>
>>> I am submitting a patch for r-abc. Please review.
>> Thank you for the patch!
>>
>> What follows is a short review that includes things I could change
>> myself before applying the patch, but for the sake of learning I
>> explicitly point out in this message. I hope you don’t mind that I’m
>> focusing on what may seem like minor details.
>>
>>> From 4b3b3eee4995616059d8a27489affc43cee26ea4 Mon Sep 17 00:00:00 2001
>>> From: Sahithi Yarlagadda <sahi@swecha.net>
>>> Date: Wed, 21 Mar 2018 16:30:18 +0530
>>> Subject: [PATCH] gnu: Add r-abc.
>>>
>>> * gnu/packages/cran.scm (r-abc): New variable.
>> Nitpick: please don’t indent this line. The asterisk should be the
>> first character in this line.
>>
>>> +
>>> +(define-public r-abc
>>> + (package
>>> + (name "r-abc")
>>> + (version "2.1")
>>> + (source
>>> + (origin
>>> + (method url-fetch)
>>> + (uri (cran-uri "abc" version))
>>> + (sha256
>>> + (base32
>>> + "0ngzaaz2y2s03fhngvwipmy4kq38xrmyddaz6a6l858rxvadrlhb"))))
>>> + (build-system r-build-system)
>>> + (propagated-inputs
>>> + `(("r-abc-data" ,r-abc-data)
>>> + ("r-locfit" ,r-locfit)
>>> + ("r-mass" ,r-mass)
>>> + ("r-nnet" ,r-nnet)
>>> + ("r-quantreg" ,r-quantreg)))
>>> + (home-page
>>> + "http://cran.r-project.org/web/packages/abc")
>> Please pull this onto the previous line and use “https”.
>>
>>> + (synopsis
>>> + "Tools for approximate bayesian computation (ABC)")
>> Please combine this line with the previous line.
>>
>>> + (description
>>> + "Implements several ABC algorithms for performing parameter estimation,
>>> +model selection, and goodness-of-fit. Cross-validation tools are also
>>> +available for measuring the accuracy of ABC estimates, and to calculate the
>>> +misclassification probabilities of different models.")
>> Please use full sentences. For CRAN packages the official description
>> usually provides only a sentence fragment in place of the first
>> sentence. Please also use “@dfn{Approximate Bayesian Computation}
>> (ABC)” the first time “ABC” is mentioned.
>>
>> All thoughout the indentation is a bit off (that’s expected as the
>> importer is very simple and doesn’t know about the expected
>> indentation). If you’re using Emacs you can easily adjust it with M-C-q
>> (also known as “indent-sexp”); otherwise please use
>> “etc/indent-code.el”.
>>
>> Have you built this package with Guix?
>>
>> Finally, please rebase this patch so that it can be applied
>> independently from the other patch you’ve sent, which cannot currently
>> be applied due to problems in building the defined package. Rebasing
>> this patch ensures that it can be merged even if the other patch is
>> stuck.
>>
>> Thanks!
>
>
--
Regards
Sahithi
[-- Attachment #2: Type: text/html, Size: 5385 bytes --]
next prev parent reply other threads:[~2018-03-29 10:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 11:14 [bug#30894] Submission of patch for Add r-abc Sahithi Yarlagadda
2018-03-21 21:27 ` Ricardo Wurmus
2018-03-28 19:44 ` Ricardo Wurmus
2018-03-29 10:15 ` Sahithi Yarlagadda [this message]
2018-03-29 10:32 ` Ricardo Wurmus
2018-03-29 10:50 ` Sahithi Yarlagadda
2018-03-29 11:00 ` Sahithi Yarlagadda
2018-03-29 11:28 ` Sahithi Yarlagadda
2018-04-02 21:26 ` bug#30894: " Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c9c531d-75a5-be08-2784-ebae3c3a432b@swecha.net \
--to=sahi@swecha.net \
--cc=30894@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.