From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KIKeJTW76WFgRQAAgWs5BA (envelope-from ) for ; Thu, 20 Jan 2022 20:42:45 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4AlDIzW76WF84AAA9RJhRA (envelope-from ) for ; Thu, 20 Jan 2022 20:42:45 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3E8B7AC45 for ; Thu, 20 Jan 2022 20:42:45 +0100 (CET) Received: from localhost ([::1]:53560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAdKV-0008LA-UO for larch@yhetil.org; Thu, 20 Jan 2022 14:42:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAX3x-0001hb-SH for guix-patches@gnu.org; Thu, 20 Jan 2022 08:01:14 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35509) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAX3m-0006AI-Iv; Thu, 20 Jan 2022 08:01:10 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nAX3m-0003LN-FP; Thu, 20 Jan 2022 08:01:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53389] [PATCH 0/9] Replace some mocking with with-http-server*, avoid hardcoding ports, Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: ludo@gnu.org, guix-patches@gnu.org Resent-Date: Thu, 20 Jan 2022 13:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53389 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53389@debbugs.gnu.org Cc: ludo@gnu.org X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: ludo@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.164268365812597 (code B ref -1); Thu, 20 Jan 2022 13:01:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Jan 2022 13:00:58 +0000 Received: from localhost ([127.0.0.1]:56645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAX3h-0003Gi-J4 for submit@debbugs.gnu.org; Thu, 20 Jan 2022 08:00:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:43974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAX3f-0003EC-88 for submit@debbugs.gnu.org; Thu, 20 Jan 2022 08:00:55 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAX3Q-0001WR-45 for guix-patches@gnu.org; Thu, 20 Jan 2022 08:00:50 -0500 Received: from [2a02:1800:120:4::f00:15] (port=44032 helo=andre.telenet-ops.be) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAX3G-0005cn-2k for guix-patches@gnu.org; Thu, 20 Jan 2022 08:00:34 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by andre.telenet-ops.be with bizsmtp id l0zS260044UW6Th010zSBi; Thu, 20 Jan 2022 13:59:28 +0100 Message-ID: <6b1c1d98514b2547907a81a04c1241d9b865d6fa.camel@telenet.be> From: Maxime Devos Date: Thu, 20 Jan 2022 13:59:16 +0100 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-QJCuQ6NNc7AgRWJOGoB8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1642683568; bh=T2BWXZYp6DRhEBP93gCQ7XG/jZyoBX1+6RBN0nZWKdM=; h=Subject:From:To:Date; b=M7pUWf78fuxaIPUo1gc+dzyfirGXFI9ffzjr+AQndvqiRB47+rBSIi6Ibvd004GS+ es03QBJzV2gSgmteMCEr+hPEGmFqxoITc1e+bT36OjbnKptj9AJjqjaP5SjT/10b5W TBn4725DFZjTtWRnpcToIy1i/G1VXvh8u2LNaTeFsudvQCXVDXMFbAUZcDlUNA6JcS 8WDfme2KlzD2bpGgOCkBueHBL+xK1Vm8CCic4D/byyPVQpKmMA3Fi2jrxv6NAHceAR Bzf77ojijxg/GgD0k6Rm5fe7o0sk5GfUJQkraew2DUay55uKHVGV5yBnL5FrJwz7fn zYV1QhPonnyKQ== X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a02:1800:120:4::f00:15 (failed) Received-SPF: pass client-ip=2a02:1800:120:4::f00:15; envelope-from=maximedevos@telenet.be; helo=andre.telenet-ops.be X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642707765; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:list-id:list-help:list-unsubscribe:list-subscribe: list-post:dkim-signature; bh=T2BWXZYp6DRhEBP93gCQ7XG/jZyoBX1+6RBN0nZWKdM=; b=WE+Yax7O0dBwkNdJxseL0BO9vIs4VHjYc9ZhmeQ/rAneQf6DIVRuDGhRxa1Gn4dhPG1w7V mIot7hIPD/hmeyA5DDAZ5/6lhuINYGXzhE6ND+23hPTx7zJYx88tsz//lDrHNWj3RnC5JN l1jcHz9kVQvTk1UIGfuPcUpJq+KQlijtTebrVPRFhUS/LvHzyy5IVZuHByeTIEakyYQrkQ B03vqy1TdnQlhOLW0sW3GtOJDVy+kUE39nw0PdXCVL5oDdaZNOa1OtSKJqaDddaSDs6ruP guSD5scMg2O/QbSRVjbwjw4u8VLAh2T70N9IkwXEIz810PMFcz/t6Re4kVn6lw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642707765; a=rsa-sha256; cv=none; b=g9iK8TTlCgJKIUklNM8jeR5I3JtALLBDrNAMphXlw3TsXs49yruIu4H1kS1fq6tOx1bD0h q+1bXxT+Pqm7jPvZtZkbhCoRMzS/InDdLH+o/smWgl4rb5lWcCPpsoi7AhRE9NhHh0O4o/ +1kaUOsrETPTKsQco2bD7eb2y/tQMGMtq3sPI6GKaij6Yyt05OBOqr8LJTYSKT33Zir2Ln P91uw7XKVF89IQZ7lVjghE2gejLEJty6cbOXWWJeXpMgFatLc/sLqpeuuxeXivm0ZOWLDe bjLrY5IELwsCuLqxOystzyR1DWH809ioxzSM//vNlY9qd3qj5yAOKtVMfuxN7g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=M7pUWf78; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=M7pUWf78; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3E8B7AC45 X-Spam-Score: -3.92 X-Migadu-Scanner: scn1.migadu.com X-TUID: sbhWWgTZ32MN --=-QJCuQ6NNc7AgRWJOGoB8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Debbugs-CC: ludo@gnu.org Hi, This patch series addresses: Ludovic Court=C3=A8s schreef op zo 16-01-2022 om 23:19 [+0100]: > I think the whole point of having the =E2=80=98%github-api=E2=80=99 param= eter is that > it allows us to mock the HTTP server instead of having to override > bindings such as =E2=80=98http-fetch=E2=80=99. >=20 > I=E2=80=99d have a slight preference for doing that, similar to what is d= one > in tests/cpan.scm for instance. WDYT? (see .) by extending with-http-server to with-http-server* to allow arbitrary request handlers and extending with-http-server to allow verifying the URI of a request. tests/cpan.scm has been modified to verify the URIs. tests/import-github.scm and tests/minetest.scm have been modified to avoid mocking. Somewhat unrelated, tests/lint.scm, tests/cpan.scm and tests/challenge.scm have been modified to avoid hard coding ports, as a follow-up to commit c05ceaf2b650d090cf39a048193505cb4e6bd257: [...] Previously, test cases could fail if some process was listening at a hard-coded port. This patch eliminates most of these potential failures, by automatically assigning an unbound port.=C2=A0 This should allow for building multiple guix trees in parallel outside a build container, though this is currently untested. [...] After this patch series, there's to my knowledge only one instance of hardcoded ports remaining, in tests/lint.scm ("home-page: Connection refused"). This patch series is also available at https://notabug.org/maximed/guix-gnunet (branch more-precise-http-tests, commit f0a0303c17b5aa92493aea5a6d28183421b7cf44). Greetings, Maxime. --=-QJCuQ6NNc7AgRWJOGoB8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYelcpBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7irMAPwNeTw/NNF7cXaGMZlTV+D1k3p6 xFhNYna2mBtbycMXDwEAkcl04r0yhSxeFWzFd39Wtq0MbnlmB1iBu48nwDIQoA4= =56SL -----END PGP SIGNATURE----- --=-QJCuQ6NNc7AgRWJOGoB8--