From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7TUI-00013V-Lt for guix-patches@gnu.org; Sun, 07 May 2017 17:13:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7TUE-0002ya-K4 for guix-patches@gnu.org; Sun, 07 May 2017 17:13:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34417) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d7TUE-0002yO-Ft for guix-patches@gnu.org; Sun, 07 May 2017 17:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d7TUE-0005LJ-AN for guix-patches@gnu.org; Sun, 07 May 2017 17:13:02 -0400 Subject: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name Resent-Message-ID: References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> <45019b9a-565a-82a9-a0de-249cfe211cfa@tobias.gr> <87bmr4ptj6.fsf@gnu.org> From: Tobias Geerinckx-Rice Message-ID: <6a792b17-4e9f-c7ec-6934-8a04a9236bd1@tobias.gr> Date: Sun, 7 May 2017 23:13:29 +0200 MIME-Version: 1.0 In-Reply-To: <87bmr4ptj6.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="b1Lki3IThNs5wEJL5H5CmoEIXPKXFItVN" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ludo@gnu.org Cc: 26264@debbugs.gnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --b1Lki3IThNs5wEJL5H5CmoEIXPKXFItVN Content-Type: multipart/mixed; boundary="PPMteHPgS855mxD5X2huPg6whI57tHJ8M"; protected-headers="v1" From: Tobias Geerinckx-Rice To: ludo@gnu.org Cc: 26264@debbugs.gnu.org Message-ID: <6a792b17-4e9f-c7ec-6934-8a04a9236bd1@tobias.gr> Subject: Re: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> <45019b9a-565a-82a9-a0de-249cfe211cfa@tobias.gr> <87bmr4ptj6.fsf@gnu.org> In-Reply-To: <87bmr4ptj6.fsf@gnu.org> --PPMteHPgS855mxD5X2huPg6whI57tHJ8M Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludo', On 07/05/17 17:37, Ludovic Court=C3=A8s wrote: > WDYT of making it: > (define* (package-full-name package #:optional (separator "@")) > =E2=80=A6) > ? > (I think I suggested it somewhere, but maybe not. :-)) You did! I simply forgot to address it explicitly (=E2=80=98I'm sticking.= =2E.=E2=80=99). > That would make the adjustments to places that need a hyphen slightly > shorter. I considered it back when, but decided not to because it just felt... wrong. That's it. My intuitive, rambling reasoning: - All of the patched ex-callers are manually constructing some raw file or directory name. It includes the package's name and version in some way, but not really Guix's abstract concept of a =E2=80=98package-full-name=E2=80=99 atom. It just happened to be the sa= me string. - Making =E2=80=98separator=E2=80=99 configurable turns =E2=80=98package-= full-name=E2=80=99 into =E2=80=98package-name-version-join=E2=80=99. If one cares about the sep= arator, one also cares about the components, at which point one should just call string-join explicitly. Doing so isn't ugly, and is more clear. Does that make any sense? In the end, I care more about users' ability to finally copy & paste without confusing warnings than my perso'pinions on function naming. This bug has been open for long enough. > Thanks, and good luck with your new $DAYJOB! Thanks! It doesn't involve computers, so it won't last. Kind regards, T G-R --PPMteHPgS855mxD5X2huPg6whI57tHJ8M-- --b1Lki3IThNs5wEJL5H5CmoEIXPKXFItVN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAlkPjfkNHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmaoSB/9gyvLHcHctf5iqtQNQeSHwLDaajnNpukgxJ8v4 n1Qcdimyc8gWjWTesUWJNutl5708CcbqKVmTDy8719zzUbx86jUrHOhZaV1Rf99m /3O8bNyr8p5jGejJJFTBQsUsPfIA+sFHtaKEDZ2js2UBfX9ni+5MP5u6IpKy5LYH HHsUrtVoXVg4A4ybP4JaA3MUokru1tgCi5JgVjZ0H42cshKkXpihWcfkaovGExZw j7tjnoYChKLi3ag1sSnN2B2x6zVfqB1+TvRqeBdZd5jzz8oWkRfret9JareUWdNe kWeDteAuEu1RNZHRq2RlHDTuxOtj56yKcLaM2JzUhJt0WxNU =N+mT -----END PGP SIGNATURE----- --b1Lki3IThNs5wEJL5H5CmoEIXPKXFItVN--