From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iAO6GQRyGmJdVwAAgWs5BA (envelope-from ) for ; Sat, 26 Feb 2022 19:31:32 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oD0VFwRyGmKAzQAA9RJhRA (envelope-from ) for ; Sat, 26 Feb 2022 19:31:32 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F13473B8E3 for ; Sat, 26 Feb 2022 19:31:31 +0100 (CET) Received: from localhost ([::1]:55596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nO1qs-0007x3-0T for larch@yhetil.org; Sat, 26 Feb 2022 13:31:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nO1qQ-0007wu-D1 for guix-patches@gnu.org; Sat, 26 Feb 2022 13:31:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34204) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nO1qP-0003lt-VI for guix-patches@gnu.org; Sat, 26 Feb 2022 13:31:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nO1qP-0004tU-Jg for guix-patches@gnu.org; Sat, 26 Feb 2022 13:31:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53878] [PATCH v5 03/22] gnu: racket: Use Git origins for Racket packages. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 26 Feb 2022 18:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53878 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , 53878@debbugs.gnu.org, zimoun , Liliana Marie Prikler Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxime Devos , Attila Lendvai , Malte Gerdes , raingloom Received: via spool by 53878-submit@debbugs.gnu.org id=B53878.164590021818749 (code B ref 53878); Sat, 26 Feb 2022 18:31:01 +0000 Received: (at 53878) by debbugs.gnu.org; 26 Feb 2022 18:30:18 +0000 Received: from localhost ([127.0.0.1]:56334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nO1pi-0004sL-3c for submit@debbugs.gnu.org; Sat, 26 Feb 2022 13:30:18 -0500 Received: from mail-ej1-f65.google.com ([209.85.218.65]:37547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nO1pg-0004rw-2F for 53878@debbugs.gnu.org; Sat, 26 Feb 2022 13:30:16 -0500 Received: by mail-ej1-f65.google.com with SMTP id bg10so17068047ejb.4 for <53878@debbugs.gnu.org>; Sat, 26 Feb 2022 10:30:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=OMLZYrJOolGABSw+BgPM+Eu54MQvy5S1iysDJhNy6t4=; b=XHT/odSHZgWW3ZFhTiT3MJ5PS9ykn1JHxQtAAorCmnE8CsC5UCjSpJsex3EdvtRMb2 MO96KZr98gEMfmH9Qs75j/xJMfGsE7gSp4DxXQ2VsqboM60PWOp4r4CWzBNAvostKGX5 ty98sy4FlO44VA+pxAGvqRIP8UZENHNasGCvQpfvqMjv5OLCUQbXivJP/CHYFjyd8uz2 KTAQfEiv3sgc0/wfIxo+lX0Uh80nQXtngfMkNv7hagti+QdPxGqHQIvj6/VN2g0z/xVg G1UiLKJE0A8Oc9QkFc64U3m3cdGiCTxivbaO/zUIngEUyNQA0hjz3BS4LTXUBuVPRh0E 9DaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=OMLZYrJOolGABSw+BgPM+Eu54MQvy5S1iysDJhNy6t4=; b=o3dvAQJwYOcFemUxTqKpkHeXD7KB4BDBXFdiR3LIFXw2Lzb+9P4+d+LShDP9tfzy+m 7O9pvp3uIjtsnnjowGdq2BWfWgWZvk55JVlOyFttGl9Iexk/pf7dH7E6j2gwHLv8MS2B RwYC1a/HWp2smlwWNJOUj07yCTm2b3Z/FHezYUVpg1dbyo9qylnkymkiZ2hKuXuy00Un yPfDK3dcIzZUN+MeGD9BDSq2jXSLu8by8Chn7YMWlq3vzJvTU9An8bWEWowf5zxX+oA8 qrvZJxstK1tLLzf5qcZoPHKKAytHBSSh5Ru3FUUDqSggwlTn/HyU4Yv2pEyblHyvn3bW KBfg== X-Gm-Message-State: AOAM530lgqHfKAkZ6XC4mYRQg6x82Oct3y9Q+YboJuS8oCp/46OasVrb kJFk1ve+72To7V0LBeMsgFM= X-Google-Smtp-Source: ABdhPJz5NqOsmOoO0r6siH7ItgKBglAtxvjD/HmKsuI7SwtrKGIsdbXeqiJIOAehgD56o7ppxSHY7w== X-Received: by 2002:a17:906:3ac6:b0:6cb:6808:95f9 with SMTP id z6-20020a1709063ac600b006cb680895f9mr10494985ejd.375.1645900210220; Sat, 26 Feb 2022 10:30:10 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id d25-20020aa7d699000000b004128cfcc228sm3258052edr.5.2022.02.26.10.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Feb 2022 10:30:09 -0800 (PST) Message-ID: <6a35fdea04cdf461a662830efc5bfd84fee60ec1.camel@gmail.com> From: Liliana Marie Prikler Date: Sat, 26 Feb 2022 19:30:08 +0100 In-Reply-To: <19823080.dSP1spjjOr@bastet> References: <20220220060610.178131-1-philip@philipmcgrath.com> <3354324.gHnXMxdNb5@bastet> <0c9963cedab248085b106effdd68649647a41ca2.camel@ist.tugraz.at> <19823080.dSP1spjjOr@bastet> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645900292; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=OMLZYrJOolGABSw+BgPM+Eu54MQvy5S1iysDJhNy6t4=; b=R0KvxYW7AAB9oy5xqp9FWMKBUK8UYDUd+tPFLnuKi9W+FW2XJDo90ygRFxH3SqOIcMWCCC SuxlZ/48eIgINS7JUNREoUko0qFqA0j2L6Uc0/F1emqutvc2bkUFPXH25QgJgcPb65D3r+ T8t045uWqgSCZLzIFT+3DF1zArt2MTCw/HDu63k4wx1Moy31H1BEvYK4WfhasbsPk/Ommw kyp6G7KMVG59G5ntLgaGUqzPFro7x7mVSbnPk/pNnTbkEa2zrdS2GYbfEVDOX0ce3DFkDV Xkc76+RWzYFaRpXRocIznvm9JNYTHJvagyRm2yCsLUDbVQnjT+HNoRJYzk70cA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645900292; a=rsa-sha256; cv=none; b=Jb7JbLOs6Se/r2aihSEP0AsDMec/zaeAVjnpxjCB4za/jZ5X4I5us/MHjKuf+9yFGXGq3y 481c2Y7BBJsG1XdZrTQ5fwA1mfs8Ie5Y/bfip3qNYXUNDob5PAuE9B5Uvawv+l5e8s90MH y2CZGlXjOtqtz8Kg+q0PASikBfFfHka11Q4LOdSSdTZXjP9axE60yThpBkk2+Uke+WcKAr NLICzhciGX7Dsf+CIR9jBP/fy1oTHMEb/TV2k5i+/TYXBYdNixNQyzGNSP3WF2xW6a/Lon 7MlJ8pKliDfRrGy2EuofkFsFllHw0DH5BA62/joWjtBjqqljh96bN2LADf3UJA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="XHT/odSH"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.88 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="XHT/odSH"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: F13473B8E3 X-Spam-Score: 6.88 X-Migadu-Scanner: scn0.migadu.com X-TUID: zwZ93z3X41J7 Hi, Am Samstag, dem 26.02.2022 um 12:23 -0500 schrieb Philip McGrath: > Hi, > > On Saturday, February 26, 2022 9:26:29 AM EST Liliana Marie Prikler > wrote: > > I'm not talking about the generated file, but the procedure that > > generates it.  Special characters like dots and slash are still > > pretty special in Scheme, even if they're allowed as identifiers. > > Do you mean A, B, C, and/or D of these: > a > >           (replace 'configure > >             (lambda* (#:key inputs configure-flags #:allow-other- > > keys) > >               (let* ((racket (search-input-file inputs > > "bin/racket"))) > >                 (apply invoke > >                        racket > >                        #$make-installation-layer.rkt ;; <--- A > >                        `(,@configure-flags > >                          ,(dirname (dirname racket)) > >                          ,#$output)) > >                 (invoke racket > >                         "--config" (string-append #$output > > "/etc/racket") > >                         "-l" "raco" "setup" > >                         "--no-user")))) > > > > [...] > > > > (define make-installation-layer.rkt ;; <--- B > >   (scheme-file > >    "make-installation-layer.rkt" ;; <--- C > >    `(module > >      make-installation-layer racket/base ;; <--- D > >      (require racket/cmdline > > or something else? The name in B is confusing imo, because it implies a procedure when it is in fact a file. Of course, that'd affect A as well. The file name in C does not matter too much, but should probably be matched with B to some extent (but importantly keeping the .rkt extension even if we drop it from B). I'm not sure if D is a function call or not, but if it's a module name perhaps we should make it match B. Given that we pass configure-flags to this thing, how about "configure- racket-layer", "configure-layer.rkt" or something along those lines? > In particular, not to be dense, but B is not a function. Yeah, that's my bad for only skimming these and not paying too close attention to brackets. The name itself implies a function, hence my confusion. Looking at things closely would make me see more typos like ";; workaroung Guile reader/printer:" workaround. > One of the reasons I particularly like being able to use `.` in > identifiers is to refer to files by name, without some ad-hoc > encoding. I do admit that is helpful, but in this context, metaphors were mixed in a way that conveyed the wrong message. > > > > I think some way to shorten those origins would do wonders in > > > > terms > > > > of the number of lines this patch adds. > > > > > > At one point, I had abbreviated the origins as something like: > > > > > >   (REPO-SPEC SHA256 [COMMIT]) > > > > > > [...] > > > > I wouldn't do this inside of extract-package-source, but define a > > one or two liner for adding specifically packages hosted on > > racket's github.  WDYT? > > > > > I wasn't sure about the trade-off between being slightly more > > > cryptic > > > than explicit origins, but a lot shorter. > > > > Note that the goal is not to code golf, but to be understandable.  > > When adding a bunch of origins as inputs, understandability suffers > > by induced scrolling. > > > > I've done this, and it was a very good idea. In particular, it helped > find some places where I hadn't switched to using `%racket-commit` > once the release was tagged. That is better, but can still be improved. As hinted at in my comment to your tree, origin snippets might be a better solution here unless I'm missing something in the heat of the moment. > Other than potentially doing something about "make-installation- > layer.rkt", > I'd plan to squash the WIP/FIXUP commits in > < > https://gitlab.com/philip1/guix-patches/-/tree/racket-chez-refactor-hist-28 > > > and send it as v6. I did have a short look at it and apart from the above comment it appears fine, but I'll have to reevaluate it when it's a full v6 anyway. Cheers