From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Jos=C3=A9_Miguel_S=C3=A1nchez_Garc=C3=ADa?= Subject: Re: [PATCH] gnu: xmonad: Add missing propagated input. Date: Mon, 09 Jan 2017 17:28:15 +0100 Message-ID: <6a0f504b1ffe30f880ba804c9dca8f64@openmailbox.org> References: <1adf5de996d4bf21362c97110f574565@openmailbox.org> <87r34ey21f.fsf@gnu.org> <877f65x1k7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQco3-0003qZ-T9 for guix-devel@gnu.org; Mon, 09 Jan 2017 11:28:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQcnz-00051g-Ov for guix-devel@gnu.org; Mon, 09 Jan 2017 11:28:23 -0500 In-Reply-To: <877f65x1k7.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ludo@gnu.org Cc: guix-devel@gnu.org On 2017-01-08 11:56, ludo@gnu.org wrote: > Hi! >=20 > Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa skrib= is: >=20 >> On 2017-01-07 22:48, ludo@gnu.org wrote: >>> Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa skr= ibis: >>>=20 >>>> xmonad package needs some love, and this is the first step. ghc=20 >>>> should >>>> be a >>>> propagated input, because it's needed for certain commands such as >>>> xmonad --recompile. >>>=20 >>> Instead of propagating it, would it be possible to hard-code the >>> absolute file name of =E2=80=98ghc=E2=80=99 inside the xmonad source? >>>=20 >>> That would avoid pulling in GHC in the user=E2=80=99s profile, which = could >>> conflict with the user=E2=80=99s GHC. >>>=20 >>> Thanks! >>>=20 >>> Ludo=E2=80=99. >> I don't understand. xmonad needs ghc at runtime to compile the >> configuration >> file (because the configuration file is a binary and XMonad is a >> library). >> Could you explain better? >=20 > Propagated inputs are automatically added to the user=E2=80=99s profile= . So > with the patch you suggested, when someone installs xmonad, they=E2=80=99= d also > get GHC in their profile. This solves the problem at hand, but it=E2=80= =99s=20 > not > great: it =E2=80=9Cpollutes=E2=80=9D the user=E2=80=99s profile, and it= could conflict with > another GHC already present in the profile. >=20 > Thus, when possible, we often patch patches to do (roughly): >=20 > execv("/gnu/store/=E2=80=A6/bin/ghc", =E2=80=A6); >=20 > instead of >=20 > execvp("ghc", =E2=80=A6); >=20 > IOW, we specify the absolute file name of the executable instead of > relying on $PATH lookup. >=20 > An example of that is =E2=80=98gv=E2=80=99, where we patch the source t= o refer to the > absolute file name of =E2=80=98gs=E2=80=99 instead of looking it up in = $PATH: >=20 > =20 > http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/gv.scm#n46 >=20 > Same for =E2=80=98egrep=E2=80=99: >=20 > =20 > http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/base.scm#n9= 5 >=20 > HTH! >=20 > Ludo=E2=80=99. Oh, I see. I've been trying to fix it properly but I can't (I can patch=20 the source, but it generates other errors I haven't solved yet). I think=20 I'll keep working on the patch on my free time until I can make it work fine. Thanks Ludo! --=20 Jos=C3=A9 Miguel S=C3=A1nchez Garc=C3=ADa