From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OBfyIto4V2SpJQAASxT56A (envelope-from ) for ; Sun, 07 May 2023 07:36:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id mH0OIto4V2Q71gAAG6o9tA (envelope-from ) for ; Sun, 07 May 2023 07:36:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5EBBC32767 for ; Sun, 7 May 2023 07:36:26 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvX42-0000Nq-SE; Sun, 07 May 2023 01:36:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvX3z-0000M5-59 for bug-guix@gnu.org; Sun, 07 May 2023 01:36:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvX3y-0007l1-6L for bug-guix@gnu.org; Sun, 07 May 2023 01:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvX3y-00062a-21 for bug-guix@gnu.org; Sun, 07 May 2023 01:36:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63082: [PATCH v3 05/16] services: mpd: Obsolete the 'group' field. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 07 May 2023 05:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer Cc: 63082@debbugs.gnu.org Received: via spool by 63082-submit@debbugs.gnu.org id=B63082.168343773223178 (code B ref 63082); Sun, 07 May 2023 05:36:02 +0000 Received: (at 63082) by debbugs.gnu.org; 7 May 2023 05:35:32 +0000 Received: from localhost ([127.0.0.1]:36196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvX3T-00061l-V9 for submit@debbugs.gnu.org; Sun, 07 May 2023 01:35:32 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:48505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvX3Q-00061Y-S5 for 63082@debbugs.gnu.org; Sun, 07 May 2023 01:35:30 -0400 Received: by mail-ed1-f66.google.com with SMTP id 4fb4d7f45d1cf-50bc0117683so6090725a12.1 for <63082@debbugs.gnu.org>; Sat, 06 May 2023 22:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683437723; x=1686029723; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=I8/eBTkNRPBIg2Ca/2Y6EwiDAhZ5AcELTLw+0FSQmhw=; b=qYqOlWGusURjSaC+nDHf7MeehPhyPNJDoKuY7op43kGNHKqhQSMi6u9XwqSCyNH0Xl IEfJEkgrLxQ+z0es+7Jkze3NhpvPMVeLVFhAwVpi0LkZZqOM1EmZEVbOm3TWXzZyp+W2 +6CTKST2XBc87AruE0nyTjOClAlQT0nJclyeJLGA65FYP9pxoyB9NUQdaafqDGBxmD+q cJgCsEXV5QJDZZR4rk/1cRp+g/mSNfMXRKq3KslFDhgOfHghh1RRpGe8svKh6aTGJEW0 IembXPLUQjPOHJkKX6eejIXKmb8SCDnNT2k4WTLwb8yegslOOyugJq4EvF6f8WN27BPt tAMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683437723; x=1686029723; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=I8/eBTkNRPBIg2Ca/2Y6EwiDAhZ5AcELTLw+0FSQmhw=; b=eb2tiTVlxhbuQx5FwoLxm0jwuPrCBl8GlRwxM348dzOucku3LViXxvQCWpKK9YLOoh 57c073C7Qqbm9Sduvkxm2hTnqjWywtnZN0xDyIDZex6OpivoiYphuGNR0mroynA8ALPy B8JNPhYPL0paQP1XdajCsR5YOcVr3p+FgWfFLt2cge4tJmgZvZmrem7A0DUdmnk35Gsg qGL/d87+vVbLkqxCQfSQDodPQcpM6mCkK3TyjA8GBYTqcELEPnLtgCqeSu4RIj0NCT6Y QLkSHh5zCrx4M1v1f3cCGrcm4Solho+XAM3IOW3CVQojF8LNcPKMP/FusSMIt7pJ8H1k SfMw== X-Gm-Message-State: AC+VfDw4u1kibi3oqCOKBYww8zT0LNx1yOYlcf+OiQbnsHjD2wRN53f0 3qHzl7OYfyS71TIbTrOx3Wk= X-Google-Smtp-Source: ACHHUZ6YZ23RLCa2Qk0tvyug7vj99R77dbdkQ/zDWMdMI9XTEgm8uMI6/M9gNkus8dtSUcWR7nZkDw== X-Received: by 2002:a17:906:5d11:b0:95f:7edb:def2 with SMTP id g17-20020a1709065d1100b0095f7edbdef2mr5528357ejt.69.1683437722669; Sat, 06 May 2023 22:35:22 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id t8-20020a1709063e4800b009660df2e6c6sm1818476eji.168.2023.05.06.22.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 22:35:22 -0700 (PDT) Message-ID: <69a7c685bb22add38026990a91f099db44eb80ec.camel@gmail.com> From: Liliana Marie Prikler Date: Sun, 07 May 2023 07:35:21 +0200 In-Reply-To: <875y943l6c.fsf@gmail.com> References: <40db40a2bbfe5e0586d8b8c9694607bc0d66e340.1683299529.git.maxim.cournoyer@gmail.com> <7ba0cf980bf4ad3766c6c0ae30b069ed2891128e.camel@gmail.com> <875y943l6c.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683437786; a=rsa-sha256; cv=none; b=tfNJDTzjl4CC8mcDZuZzGrX9hkAW1Vy3AgPUBT81WB3asf7wsIjk4+50Qh+9DAceYgx579 IVPP0u4OjuV5zINaHP/1XH6bb7D/k26EWfbIvX5DxRjdE5SCJ5UXpYw9XnOBlg9c51xzxJ +2Bt85bixw1nELsQ1JmDParmqp94/rs+/sTuvI30MdqKyvs/lDshNwisEPXWzxq3pGb5iV Jd5HC45BtqLAAXCXF8dX0lE7+q1aWfoJoFfKXfxtng6S3x7ahaVWAGfREoeAs583l5ORfD ySXYbWR8+FhAG2vbcLRDEm9Px1jQNPjMQUL1s13U/XhwcLXWplQe8anfWb/mvA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=qYqOlWGu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683437786; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=I8/eBTkNRPBIg2Ca/2Y6EwiDAhZ5AcELTLw+0FSQmhw=; b=GITYvJGxLIPBMNqgdImNOSQs9g9D+Y7/4chWmL2AU0ThlYA9MwX32aubF59+TdWtmLzvc3 isV6FCNgskncGu8GIMR0Cgb4hUptfVtCVNIHstitFYL0oD6r5lmnSaIQndYK0bD+OyJ2NE 9DbN8plslwfShkHP833U5+IzXDKi9KQpHRl/tLCGYq4k1iNj59vNjJVKA3I8LKEBvWdCGG rgUXXkvYBwVHIcCUyyRlKa4p4S6xv9S2f5WlZmLmgJ+mFkIlH/3dsqg5BnFHlyBskP/xop nZAFF2gQVJC4lEJvjtbgROiPuYgV9Ps5MOXN5TGAwTXaQ1583YlFl6AL8ssZzQ== X-Migadu-Spam-Score: 0.49 X-Spam-Score: 0.49 X-Migadu-Queue-Id: 5EBBC32767 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=qYqOlWGu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: hwPnqNd37KCO Am Samstag, dem 06.05.2023 um 22:55 -0400 schrieb Maxim Cournoyer: > Hi! >=20 > Liliana Marie Prikler writes: >=20 > > Am Freitag, dem 05.05.2023 um 14:29 -0400 schrieb Maxim Cournoyer: > > Didn't we agree in v2 that we want to address this on the account- > > service level?=C2=A0 Unless the rest of this series somehow depends on > > this patch, I'd rather delay it until we have a proper solution. >=20 > I think we agreed the idea to have support group> objects for its group field was a good idea that should be > implemented, but I declined doing this new work as part of this > series :-). Indeed, that's how I understood it. However, I also thought that addressing this issue in a later series means we can keep the current behaviour until that is done. > > > Synchronizing both is not practical, as it can easily lead to > > > slightly different objects conflicting, again > > > causing problems. > > It might not be practical to do so inside the service, but note how > > this has already become an effort in defensive programming.=C2=A0 There > > are easier ways to not make this a problem on the configuration > > level, namely by specifying the same group for both user and group > > fields.=C2=A0 As far as I see this is even the default state of being i= f > > the user is supplied as a string. >=20 > I really don't like the group information being duplicated in both > the user and a distinct field; it's an awkward API that raises more > questions than it provides answers, in my opinion (non-intuitive). And I agree that it's awkward, but I don't agree that this patch solves the underlying issue. > One of the reasons I came think this way is because a > can differ by being a system group or not, which would make it easy > to introduce unexpected, subtle variants. Is that a serious issue, though? Yes, two configuration files, one with (system? #t) and one without will produce different results in that GIDs are allocated differently, but the same applies to the user as well. The only real issue I can think about here goes back to the handling of duplicate accounts and groups; and again, we both agree that those ought to be hard errors rather than warnings. Cheers