From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id IM2yBQ2eAGUChQEAauVa8A:P1 (envelope-from ) for ; Tue, 12 Sep 2023 19:21:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id IM2yBQ2eAGUChQEAauVa8A (envelope-from ) for ; Tue, 12 Sep 2023 19:21:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 260CC56A59 for ; Tue, 12 Sep 2023 19:04:10 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=E9weWCNl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694538250; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=DUd5Rtpwnm21f1fdRWSEXMHznbgXxVCl6/N25on16Ws=; b=HMCbH8l1LbsEKzia4e12IyEdoIHJf8XDK0DMshotHDr3HL4TtUfzfE0GYwQftybTSmkRZ8 sV6iJj/kuZ2G1dtmVQlZv9HZMuAJjgcijP1xMZBGAOndGzNCy8+tBxeV1Ipe2r/dh+Vuxa PYGB0fj7v0Unajw2nF00nnAjJ3T6FDO7RNjElPW7pwL8qjWGP2dVbXaBEDfaBle1/pESeN +ZbU4OWPNXPbOfNYnmlnO+rAROvruhO0EeyJmOauxbVjXeoutS0M2OS6HkSsKgdICDMDeK y2d2a1CR5jt2vlG0g6QvurZuCWDicsjU0I2AMYeTcoRe+RNP/V86De2izDrQrA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694538250; a=rsa-sha256; cv=none; b=nPSbuY08xHLCZo6MifWEHPTwfoUjsX83GxcITgmWb0txKUv/iXPdv1vXJLEQe8qmnHpvm1 RjjDREaHmTzduC1M9fDOOyXOtr0pRALdY/0jGdn3gwfFZbZWmvpIZ6/TBCiDFTtjzXrAQX nOsXcY5IQHjgRocPaH7nh+UrhRbcHosZnuyG7iC7X7TQsHBT/9NBzmKYxa5aDZx55DljyV 5Qble3wFUOKz4MfsMSuW3ndOzUn3A/GgfNKj5u3LwNK7NKcr2YM7+7RzblabTDZ7TNnSPj IXhGnDVpKqrPaEdlTkJbk/uF0x2K3pQHeUuvX9EMVx4K6jPF1bfMjlQ1nbLGtw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=E9weWCNl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qg6nd-0008Bc-1Y; Tue, 12 Sep 2023 13:03:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qg6nR-0008Ag-Ty for guix-devel@gnu.org; Tue, 12 Sep 2023 13:03:36 -0400 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qg6nO-000401-VW; Tue, 12 Sep 2023 13:03:29 -0400 Received: by mail-ej1-x642.google.com with SMTP id a640c23a62f3a-99bcc0adab4so745114566b.2; Tue, 12 Sep 2023 10:03:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694538203; x=1695143003; darn=gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=DUd5Rtpwnm21f1fdRWSEXMHznbgXxVCl6/N25on16Ws=; b=E9weWCNlShcAICrpu5TtkDqd4AqFYCb0nme7y6VzluHgP0pjYI8UjrA9JAtPWlchLF HsskPIJSLnIBhgE8i67nmloh80Y6cyaUt1Q/dOjd9giCf2uSLvtn7SM6GwaHzrx3bIH+ 3cgQ2g1ZzwkF0cgwZ5l+bXbaGdJGEwe5K5JJDMBW/u5MJWwES023v8EgNibiwkh97DHw +PUYSeLlvsw6+toa6qyoiqs2Ef/a5wpKL64YkoVVJcuUZWFPNPTQlVRW11w7C0pYBJwJ 57KeWhKlo3SjExLhsBq4NSPBkUCnC8RYnE0ktPOCwf01t+xPCDcqOMwiEeAEOYuEjAyk 2uvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694538203; x=1695143003; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DUd5Rtpwnm21f1fdRWSEXMHznbgXxVCl6/N25on16Ws=; b=Mjn40f+3oWO1Y6cYrkkJDwLINSuYaYxGa5I+wbFH1nN4d1mm83V9eb1bkeaK55nV2/ BwiBAfIp1Qy/PPW2/uiUYKxgRBlfLa9zLqZDwZpP/w7C/S7vf5xYPBvLd6LavTsPDJHl X7+Buqlh+Xq4CGnRqdRJo+zhw5HPW0qlcUozMt295Li3LRfhzAEQgbOVXjfW7QqJg+Wx UdN9r4mczErjnbVt0ezMl2ndqRMX1GYkffTwCIbC583JHXNWlQJ39P1sbtphttryuoZt dD1B3igoLT3qAnljoLP9JyRwy8Ls2EWdqS74Z6Pc0Hv29ovLx7WJjbOF77caqv79+8gM PDNw== X-Gm-Message-State: AOJu0Yw7gWCRQkiLTRETqhNgaI5zsNl2uX56BkwG444Lp6voIZr688SG NJTjG3Ap2skzs/axynE46Rc= X-Google-Smtp-Source: AGHT+IH+/dQDUs5Eck+ymTXd5xmKWjBnKZTWqDETqVwdIYlcOnIb/PeGMhUsuqF3vQ1VIRf9wYhDqg== X-Received: by 2002:a17:906:2101:b0:9a5:d095:a8e1 with SMTP id 1-20020a170906210100b009a5d095a8e1mr11995100ejt.11.1694538202648; Tue, 12 Sep 2023 10:03:22 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id sb5-20020a170906edc500b009a1be9c29d7sm7186313ejb.179.2023.09.12.10.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 10:03:21 -0700 (PDT) Message-ID: <6929416953b2939445a5247b014142ea8bb521d9.camel@gmail.com> Subject: Re: [workflow] Automatically close bug report when a patch is committed From: Liliana Marie Prikler To: Maxim Cournoyer Cc: Giovanni Biscuolo , Vagrant Cascadian , guix-devel@gnu.org, Ludovic =?ISO-8859-1?Q?Court=E8s?= Date: Tue, 12 Sep 2023 19:03:20 +0200 In-Reply-To: <87zg1sv3vt.fsf@gmail.com> References: <8734zrn1sc.fsf@xelera.eu> <87edjb5le5.fsf@gmail.com> <87jzt2feq6.fsf@xelera.eu> <87y1hikln6.fsf@wireframe> <2d93b48dfd381c55ff706394ff7226133f5e014a.camel@gmail.com> <87pm2pces0.fsf@xelera.eu> <87bke8wo96.fsf@gmail.com> <929b035f6f4aca0793d9f8a6454b673b2a7069c1.camel@gmail.com> <87zg1sv3vt.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::642; envelope-from=liliana.prikler@gmail.com; helo=mail-ej1-x642.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.98 X-Spam-Score: -2.98 X-Migadu-Queue-Id: 260CC56A59 X-Migadu-Scanner: mx0.migadu.com X-TUID: 9yDAIW5RbAvt Hi Maxim, Am Montag, dem 11.09.2023 um 16:41 -0400 schrieb Maxim Cournoyer: > [...] > Perhaps both approach[es] could be combined.=C2=A0 I still see value in a > general scheme to automate closing applied series that linger on in > Debbugs. >=20 > [0]=C2=A0 > https://lists.gnu.org/archive/html/guix-devel/2023-09/msg00138.html >=20 > Change-Ids would also add the benefit that any commit found in Git > could easily be traced back to their submission on the guix-patches > or guix trackers or vice-versa (git log --grep=3D'Change-Id=3DXXXX'), as > noted by Giovanni. The thing is, we're discussing the same basic workflow (which you lay out below), just different kinds of metadata that we'd have to attach to our commits. IIUC ChangeIds need to actually be carried around by the committers as they e.g. rewrite patches (rebasing, squashing, what have you), and they're basically opaque hashes so I don't see the benefit to the reader. (I think you might be arguing that the benefit is uniqueness, but I'm not sure if I ought to buy that.) Meanwhile "Fixes: [whatever notation]" also needs to carried around, sure, but at the same time provides semantics by pointing to a (known) bug report. Now again, I personally prefer cool URLs here, but that's a bike we can shed however we want. > The process could go like this: >=20 > 1. commits of a series pushed to master > 2. Savannah sends datagram to a remote machine to trigger the > post-commit job, with the newly pushed commits 'Change-Id' values (a > list of them). > 3. The remote machine runs something like 'mumi close-issues [change- > id-1 change-id-2 ...]' Yeah, I think we basically agree on the 1 and 2 here, but I don't think we have to really implement 3. IMHO we could do something simpler for all parties by just carrying the bug number around (in whichever form), which we do for some of our pre-ChangeLog explanations already. =20 > In case it couldn't close an issue, it could send a notification to > the submitter: "hey, I've seen some commits of series NNNN landing to > master, but not all of the commits appears to have been pushed, > please check" I'm not sure how common this case is, but if it's needed we could add "Part-of: [same stuff as for fixes]" which once parsed by Debbugs/Mumi would send that notification. Cheers