all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.
       [not found] <20170409165703.9034-1-arunisaac@systemreboot.net>
@ 2017-04-09 16:57 ` Arun Isaac
  2017-04-10  9:10   ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Arun Isaac @ 2017-04-09 16:57 UTC (permalink / raw)
  To: 26420

* gnu/packages/emacs.scm (emacs-use-package): New variable.
---
 gnu/packages/emacs.scm | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index e3fe5e51e..4a77723b3 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4102,3 +4102,37 @@ actually changing the buffer's text.")
     (description "@code{emacs-diminish} implements hiding or
 abbreviation of the mode line displays (lighters) of minor modes.")
     (license license:gpl2+)))
+
+(define-public emacs-use-package
+  (package
+    (name "emacs-use-package")
+    (version "2.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/jwiegley/use-package/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0x4h136jb3imyli6zsh7dyzjrra6pv0v6b0yk94jdng3rdfcmsf5"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-diminish" ,emacs-diminish)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; tests fail in this release
+         (add-before 'install 'check
+           (lambda _
+             (zero? (system* "emacs" "--batch" "-L" "."
+                             "-l" "use-package-tests.el"
+                             "-f" "ert-run-tests-batch-and-exit"))
+             #t)))))
+    (home-page "https://github.com/jwiegley/use-package")
+    (synopsis "Declaration for simplifying your .emacs")
+    (description "The use-package macro allows you to isolate package
+configuration in your .emacs file in a way that is both
+performance-oriented and tidy.")
+    (license license:gpl2+)))
-- 
2.12.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.
  2017-04-09 16:57 ` bug#26420: [PATCH 2/2] gnu: Add emacs-use-package Arun Isaac
@ 2017-04-10  9:10   ` Ludovic Courtès
  2017-04-10  9:31     ` Arun Isaac
       [not found]     ` <5cb979bd.AEQAJFaVgOkAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABY61Dr@mailjet.com>
  0 siblings, 2 replies; 6+ messages in thread
From: Ludovic Courtès @ 2017-04-10  9:10 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 26420

Arun Isaac <arunisaac@systemreboot.net> skribis:

> * gnu/packages/emacs.scm (emacs-use-package): New variable.

[...]

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         ;; tests fail in this release
> +         (add-before 'install 'check
> +           (lambda _
> +             (zero? (system* "emacs" "--batch" "-L" "."
> +                             "-l" "use-package-tests.el"
> +                             "-f" "ert-run-tests-batch-and-exit"))
> +             #t)))))

Please remove #t as it would hide a failure of the “emacs --batch”
command above.

> +    (home-page "https://github.com/jwiegley/use-package")
> +    (synopsis "Declaration for simplifying your .emacs")
> +    (description "The use-package macro allows you to isolate package
> +configuration in your .emacs file in a way that is both
> +performance-oriented and tidy.")

@file{.emacs} in the synopsis and description.

OK to push with these changes, thank you!

Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.
  2017-04-10  9:10   ` Ludovic Courtès
@ 2017-04-10  9:31     ` Arun Isaac
       [not found]     ` <5cb979bd.AEQAJFaVgOkAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABY61Dr@mailjet.com>
  1 sibling, 0 replies; 6+ messages in thread
From: Arun Isaac @ 2017-04-10  9:31 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 26420


>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         ;; tests fail in this release
>> +         (add-before 'install 'check
>> +           (lambda _
>> +             (zero? (system* "emacs" "--batch" "-L" "."
>> +                             "-l" "use-package-tests.el"
>> +                             "-f" "ert-run-tests-batch-and-exit"))
>> +             #t)))))
>
> Please remove #t as it would hide a failure of the “emacs --batch”
> command above.

As noted in the comment, the tests fail in this release. I have put the
#t there to make the package build succeed. In the upstream git
checkout, tests pass. So, in the next release, tests should pass. When
updating the package, the #t should be removed. Is this ok? Shall I
leave the #t there?

> @file{.emacs} in the synopsis and description.

Will do.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.
       [not found]     ` <5cb979bd.AEQAJFaVgOkAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABY61Dr@mailjet.com>
@ 2017-04-10 12:43       ` Ludovic Courtès
  2017-04-10 19:41         ` Arun Isaac
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2017-04-10 12:43 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 26420

Arun Isaac <arunisaac@systemreboot.net> skribis:

>>> +    (arguments
>>> +     `(#:phases
>>> +       (modify-phases %standard-phases
>>> +         ;; tests fail in this release
>>> +         (add-before 'install 'check
>>> +           (lambda _
>>> +             (zero? (system* "emacs" "--batch" "-L" "."
>>> +                             "-l" "use-package-tests.el"
>>> +                             "-f" "ert-run-tests-batch-and-exit"))
>>> +             #t)))))
>>
>> Please remove #t as it would hide a failure of the “emacs --batch”
>> command above.
>
> As noted in the comment, the tests fail in this release. I have put the
> #t there to make the package build succeed. In the upstream git
> checkout, tests pass. So, in the next release, tests should pass. When
> updating the package, the #t should be removed. Is this ok? Shall I
> leave the #t there?

Oh sure.  Maybe move the comment closer to #t and, if you have the
reference of the upstream fix, you can put it there.

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.
  2017-04-10 12:43       ` Ludovic Courtès
@ 2017-04-10 19:41         ` Arun Isaac
  2017-04-10 19:43           ` Arun Isaac
  0 siblings, 1 reply; 6+ messages in thread
From: Arun Isaac @ 2017-04-10 19:41 UTC (permalink / raw)
  To: 26420


Pushed with changes!

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.
  2017-04-10 19:41         ` Arun Isaac
@ 2017-04-10 19:43           ` Arun Isaac
  0 siblings, 0 replies; 6+ messages in thread
From: Arun Isaac @ 2017-04-10 19:43 UTC (permalink / raw)
  To: 26420-done


Closing bug...

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-04-10 19:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20170409165703.9034-1-arunisaac@systemreboot.net>
2017-04-09 16:57 ` bug#26420: [PATCH 2/2] gnu: Add emacs-use-package Arun Isaac
2017-04-10  9:10   ` Ludovic Courtès
2017-04-10  9:31     ` Arun Isaac
     [not found]     ` <5cb979bd.AEQAJFaVgOkAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABY61Dr@mailjet.com>
2017-04-10 12:43       ` Ludovic Courtès
2017-04-10 19:41         ` Arun Isaac
2017-04-10 19:43           ` Arun Isaac

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.