From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6OFtO/wIVGFbOAEAgWs5BA (envelope-from ) for ; Wed, 29 Sep 2021 08:34:36 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 0B8pN/wIVGHqKgAAB5/wlQ (envelope-from ) for ; Wed, 29 Sep 2021 06:34:36 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 723C11FDDC for ; Wed, 29 Sep 2021 08:34:32 +0200 (CEST) Received: from localhost ([::1]:46504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVTAl-0003vC-La for larch@yhetil.org; Wed, 29 Sep 2021 02:34:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVT8N-0002De-KS for guix-patches@gnu.org; Wed, 29 Sep 2021 02:32:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36041) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVT8M-0008O2-HN for guix-patches@gnu.org; Wed, 29 Sep 2021 02:32:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVT8M-0005sE-Bk for guix-patches@gnu.org; Wed, 29 Sep 2021 02:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49946] [PATCH 08/31] gnu: node: Patch /usr/bin/env in node-gyp. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Sep 2021 06:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49946 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Langlois Cc: 49946@debbugs.gnu.org, Maxime Devos Received: via spool by 49946-submit@debbugs.gnu.org id=B49946.163289711922569 (code B ref 49946); Wed, 29 Sep 2021 06:32:02 +0000 Received: (at 49946) by debbugs.gnu.org; 29 Sep 2021 06:31:59 +0000 Received: from localhost ([127.0.0.1]:47587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVT8I-0005rx-OK for submit@debbugs.gnu.org; Wed, 29 Sep 2021 02:31:58 -0400 Received: from mail-qt1-f181.google.com ([209.85.160.181]:43614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVT8D-0005rh-Ob for 49946@debbugs.gnu.org; Wed, 29 Sep 2021 02:31:57 -0400 Received: by mail-qt1-f181.google.com with SMTP id a13so1339405qtw.10 for <49946@debbugs.gnu.org>; Tue, 28 Sep 2021 23:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ku9uFVHqwjxGYefU7RwD4aGD8sroVoeATwxZs4xZqp8=; b=Ku5gLNiWunOxN7eES5Cv/OrBAQv8YFGCyI417ireHsVnBKSJ92oPp0zWOcQ7eKHORF FEYYY4Syl9ma7oW8NZZOzFlwJRSHsAQ2p9LIBXHEElDmcAu0pVOHzv39hVlDkDR7AclE b0dUNI5gR8iKiLmdyvzpb+EIb/cVhtMQ12vYvrIeOopY7DYyw2SOYn7U0RhHZU5ZUUaN Mdf5HPLA8HyTFrz+osJ3p40dJ1G7rljl8ucSdlToheALbkfFzHqKqZz9jYQx+c7DR+pe 3cDnppziB9igrgOg6ekp1QqnGFJIqTs80b2zG+lS5O6SxHsF13uksnKYq60UVt3Ka36Q +w1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ku9uFVHqwjxGYefU7RwD4aGD8sroVoeATwxZs4xZqp8=; b=LRulh3TOB37RQNJ9H34e5yvUHZjw03C717NmtMymuTqEEMwIcNOpV6Wi7qzEYy46jc 709usCjVeTXMM9pawzYDpnYXjmJlXn7yJONSwWF3hVdy4oN8cXyIg88ZTU5VPfiLE3PK JNc93SBB21FRGfgM0dcu1WhCErImZpRhIt4NEfnw6bxHrNIOIbBOQjQZXm1cao9olkMR 7Hx3hJIkdOZ6Ca0qTYxpNNmrSxod4IsLPCgc0S8nfZYl+W7DImyn775bxcCKnZt1U0fq o6kwl35Csl8kSZj417iYFJ8QRRCAr/wQw7lXxTAS3SSiAvMx5eSZAkVlNF+kUQl5Nm0g kutQ== X-Gm-Message-State: AOAM532irIpT37kGKlvOhBE0jJjxymk8WWp+2wmYzUl8OSX3DlA9SssV aKIATCccVkLS5nCDoLVrQUHgUnQFxSwdO1gM X-Google-Smtp-Source: ABdhPJxXLBmHdS2/QcAlk8K2BgPfVThdTn/wb7C9KzINtuIChUYUMUdIy+oKoAdpB2BZFSsd7WQlyg== X-Received: by 2002:ac8:1e0e:: with SMTP id n14mr9917577qtl.95.1632897108058; Tue, 28 Sep 2021 23:31:48 -0700 (PDT) Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id d13sm1046272qtm.32.2021.09.28.23.31.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Sep 2021 23:31:47 -0700 (PDT) References: <87h7fztt60.fsf@gmx.com> <20210808233354.6745-1-pierre.langlois@gmx.com> <20210808233354.6745-8-pierre.langlois@gmx.com> <42e10baddb6afe308f67c3240bf5da8159e6f118.camel@telenet.be> <87o88gq5p5.fsf@gmx.com> From: Philip McGrath Message-ID: <682f2ed3-90bd-a9f8-1193-34bef399ca62@philipmcgrath.com> Date: Wed, 29 Sep 2021 02:31:46 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <87o88gq5p5.fsf@gmx.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632897272; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ku9uFVHqwjxGYefU7RwD4aGD8sroVoeATwxZs4xZqp8=; b=O4Q6ySP6rDXrSPqfg4fnKsbH9NxCDGh48Jb7irFfPn4JspGHK96EPX11jeDqlKkk3v1m+u bMRB15pdJDQlg7OgiW+4bEUsqdJOc+R8Dvto1NxY6dfEUyrmy1VzB29yVMT8oWdhNzQhVi qXobcdnrdMABwT1wbUm/ThCHrfqAoCPc8hY3nGf0+TSiS9CyeYb05eBY6eNwz1qTVcX3ya PApv/sh+I2rNzpZ/tsUtwWAUqoi+DzUxWAq7LURYMoDLKYKUwQP88dFj8ZkwVu8TEyJ5fY +/xRQvyC9VC1V0mNWw1hsKKzVmWlXuNmO9ITaP7sraJIAjvjo6o+8Ytg+2uI1A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632897272; a=rsa-sha256; cv=none; b=KaOLUSTRaduHroeEIhzyAxgd4jLadN2RFzmLUAAX/hQ58yuWo0pxT6L5qx6Fc/6FkgzO0J +APEy2+KnHtUNfqnVriMrbOi8CMxudoSnoPlHHLLvyrw4kpo7ucUNA2YD0RTAYgWnrmzY8 g56mo4st5lZQM/lW4+N/+OZBeoL5ozUtIaMn7PnSAkTGULUp9VOzRHigy46FrCZamA4SHl 6eCdMynUruDFE2RyiCD6tCddrBL/Cr9Wxz6rJm3bkVe5Av97oJ1/QpNIv6mgMn9JWZTlvN z0VFSCyzVvsPYuK+xL2bcOINGOn0/g84kiW4Vmuxn/tBjzTw/MN6fz8M5BZthg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=Ku5gLNiW; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=Ku5gLNiW; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 723C11FDDC X-Spam-Score: -1.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: IYMjlfwxZrqO On 9/25/21 6:24 AM, Pierre Langlois wrote: > For instance, while working on a newer version of one of the packages in > this series, I saw we may need to patch GYP's python reference as well, > like so: > > (substitute* "deps/npm/node_modules/node-gyp/gyp/gyp_main.py" > (("#!/usr/bin/env python") > (string-append "#!" (assoc-ref inputs "python") "/bin/python3"))) > > Only for node 14+. The reason seems to be that gyp still refers to > "python", but python2 is no longer a dependency for newer nodes. And it > seems GYP is perfectly happy with python3, and the shebang is fixed > upstream so a never node will be fine: > https://github.com/nodejs/node-gyp/pull/2355/files I think this needs to be a `python` from `inputs` rather than `native-inputs`, for cross-compilation, IIUC. I tried building node 14.18.0, and it ran into other issues, but there were still a number shebangs with `python` rather than `python3` in various places, though I think they'd be fine with `python-wrapper`. -Philip