From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id oFBnL3FRQ2Z7bwEAqHPOHw:P1 (envelope-from ) for ; Tue, 14 May 2024 13:56:33 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id oFBnL3FRQ2Z7bwEAqHPOHw (envelope-from ) for ; Tue, 14 May 2024 13:56:33 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715687793; a=rsa-sha256; cv=none; b=E2qYp1a3KuKhoA25qC/mUGue0bhPdYIqDn3c0h6NcnpNdQPoLVFWmTyCnDSMHl8XnIDfT+ jnF/2CWcINFSvnH5idrt8Mxk/WgJZStc93znWd4DD6oabawNoGtXR1cTzwFHG8XsUnLCk+ gF2iA1px+ghOBeQjaNsPbl/uIZkA1JKf48NqPeVbJgHE8/FGKKZfh7V/va1vhPd0vgeKpN YrINlelJpyg7uJOLqkSmV7ocnvX9pKXXPPd/gJvFlBfztwfgaXrOqhL1iF6WwG1/Fm4vpY 6MMxLfgOrR/FhnxU58C95r8oJs3To9Bd264O3IFkwqsH7aRBTJj73UccFk2suQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715687793; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=MFWRLyzGRk/mWLsSeDeOJSOrkFjMGww5z5BoB2BxrYM=; b=Eus8S6QhjGjY/6EwfPLMGRE2yqdfDWqIffJNYq0M03Tc0ZlDx8K1Oz1lVzPc67U0QBwmQ8 EfRsCUMLz422+KwaXdbCbYzOm8p/PzQ/2WfUwxggdTUS6k55dz8nrVY1IvPbcNVIhmrkrt vkVmDWo+ccGIalyl1PQPY8vCfuMZH4nehg0S76YN2o6StpVVkWp7zvM9hZoHYnAJAJx4yy OHwHZI16cShXaawUQiyZakZcnWBRHhaUUaqiGuxFhZd94GARugq7NQF5qqaGj3Yl2Jn72o LHa2fDRNh1dO7eRjXY1d8sKOOoJNc4tc/S0yIxwwBBJhPWe5A6WybtivHoLKjQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6771D64219 for ; Tue, 14 May 2024 13:56:33 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6qlZ-0007Vc-7y; Tue, 14 May 2024 07:56:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6qlS-0007Uv-G3 for guix-patches@gnu.org; Tue, 14 May 2024 07:56:18 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s6qlF-0008H4-UA for guix-patches@gnu.org; Tue, 14 May 2024 07:56:13 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s6qlG-0003xH-EJ for guix-patches@gnu.org; Tue, 14 May 2024 07:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70933] [PATCH] system: Do not add "--disable-chroot" to containers. Resent-From: Andreas Enge Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 May 2024 11:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 70933 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70933@debbugs.gnu.org Cc: Andreas Enge X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171568775515195 (code B ref -1); Tue, 14 May 2024 11:56:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 May 2024 11:55:55 +0000 Received: from localhost ([127.0.0.1]:38910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6ql8-0003x1-L4 for submit@debbugs.gnu.org; Tue, 14 May 2024 07:55:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:37642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6ql4-0003wv-2e for submit@debbugs.gnu.org; Tue, 14 May 2024 07:55:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6ql2-0007NL-LK for guix-patches@gnu.org; Tue, 14 May 2024 07:55:48 -0400 Received: from hera.aquilenet.fr ([2a0c:e300::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6qky-000833-1i for guix-patches@gnu.org; Tue, 14 May 2024 07:55:48 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 486381AF1; Tue, 14 May 2024 13:55:38 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mwXudKHg1Mbc; Tue, 14 May 2024 13:55:37 +0200 (CEST) Received: from jurong.as207910.net (unknown [IPv6:2001:678:984:800:7aea:3b12:7efa:b1bc]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 893C715D; Tue, 14 May 2024 13:55:37 +0200 (CEST) From: Andreas Enge Date: Tue, 14 May 2024 13:50:34 +0200 Message-ID: <67f49b23cfe3755c6802e2fc3351ef3cf0dcdfda.1715687434.git.andreas@enge.fr> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a0c:e300::1; envelope-from=andreas@enge.fr; helo=hera.aquilenet.fr X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 6771D64219 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -3.57 X-Spam-Score: -3.57 X-TUID: oH3ik9HjB1Eg The rationale for these lines is that they enable non-privileged docker containers. But I would like to create a privileged container with chroot (in an openshift environment, where I suppose this environment does additional encapsulation to enforce security), which these lines prevent. Users can still add the option. Alternatively, we could add an additional field "chroot? (default: #t)" to guix-configuration. Andreas * gnu/system/linux-container.scm (containerized-operating-system): Do not add "--disable-chroot". Change-Id: I1eff9aa0d02d6e53bd4e42f3aeb07d0ab42616a8 --- gnu/system/linux-container.scm | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/gnu/system/linux-container.scm b/gnu/system/linux-container.scm index c780b68fba..2fc54a8121 100644 --- a/gnu/system/linux-container.scm +++ b/gnu/system/linux-container.scm @@ -159,17 +159,6 @@ (define* (containerized-operating-system os mappings (nscd-configuration (inherit (service-value s)) (caches %nscd-container-caches)))) - ((eq? guix-service-type (service-kind s)) - ;; Pass '--disable-chroot' so that - ;; guix-daemon can build thing even in - ;; Docker without '--privileged'. - (service guix-service-type - (guix-configuration - (inherit (service-value s)) - (extra-options - (cons "--disable-chroot" - (guix-configuration-extra-options - (service-value s))))))) (else s))) (operating-system-user-services os)))) (file-systems (append (map mapping->fs base-commit: a682ddd70846d488cfbd82d65e8566ec6739813c -- 2.41.0