From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +MYOIyAqBGDAegAA0tVLHw (envelope-from ) for ; Sun, 17 Jan 2021 12:14:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id aPu5HiAqBGBlUAAAB5/wlQ (envelope-from ) for ; Sun, 17 Jan 2021 12:14:24 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DC7059403AC for ; Sun, 17 Jan 2021 12:14:23 +0000 (UTC) Received: from localhost ([::1]:45666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l16wo-0005eY-OE for larch@yhetil.org; Sun, 17 Jan 2021 07:14:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l16wU-0005dm-69 for guix-patches@gnu.org; Sun, 17 Jan 2021 07:14:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:33089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l16wT-00031B-V2 for guix-patches@gnu.org; Sun, 17 Jan 2021 07:14:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l16wT-0004wG-PQ for guix-patches@gnu.org; Sun, 17 Jan 2021 07:14:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45721] Telegram Desktop (v13) Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 17 Jan 2021 12:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45721 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Raghav Gururajan , 45721@debbugs.gnu.org Received: via spool by 45721-submit@debbugs.gnu.org id=B45721.161088559418925 (code B ref 45721); Sun, 17 Jan 2021 12:14:01 +0000 Received: (at 45721) by debbugs.gnu.org; 17 Jan 2021 12:13:14 +0000 Received: from localhost ([127.0.0.1]:44635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l16vi-0004vB-85 for submit@debbugs.gnu.org; Sun, 17 Jan 2021 07:13:14 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:3075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l16vf-0004uw-HU for 45721@debbugs.gnu.org; Sun, 17 Jan 2021 07:13:13 -0500 Received: from nijino.local (217-149-173-242.nat.highway.telekom.at [217.149.173.242]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4DJYhz6zplz3yVj; Sun, 17 Jan 2021 13:13:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1610885588; bh=wsWjnOBoUz/gopKRq9yR4hRyq1K9fMyJUOlq/K1zCoQ=; h=Subject:From:To:Date:In-Reply-To:References; b=Pym7YNQuZPJ/fPSHNMlRa8PcZ47CHTzR1YMkrMq1w7wYEUPvfqD19H6nu2SNeonMg 1IMW2aRQMSHB6JWXRYmsqyejVHNmuqCoycagd0ry98rjDwydu4ETbxGEnpzt3BaDlN p9fBSQfTCr9761wXeHtsAvX+SXLDvSXKjEvJJb2A= Message-ID: <67f3a995fb657c86efd2ecdc403b24cb2d441524.camel@student.tugraz.at> From: Leo Prikler Date: Sun, 17 Jan 2021 13:13:07 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.26 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=Pym7YNQu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DC7059403AC X-Spam-Score: -1.26 X-Migadu-Scanner: scn0.migadu.com X-TUID: w4J1rDs2GPxF Hi, Am Samstag, den 16.01.2021, 20:52 -0500 schrieb Raghav Gururajan: > * gnu/packages/fcitx.scm (fcitx-qt5): New variable. LGTM. > + (version > + (git-version "1" revision commit)) You can still use "0" or "0.0.0" for the base version. > + (add-after 'unpack 'delete-thirdparty > + (lambda _ > + (with-directory-excursion "src/third_party" > + (for-each delete-file-recursively > + ;; [1] Keep Abseil-CPP, LibSRTP, LibVPx, > LibYuv, > + ;; OpenH264, PFFFT, RnNoise and UsrSCTP. > + ;; [2] Tg_owt uses custom fork of Abseil- > CPP, > + ;; LibSRTP, OpenH264 and RnNoise. > + ;; [3] Tg_owt uses specific > version/commit of LibVPx, > + ;; which is different from one available > in Guix. > + ;; [4] LibYuv, PFFFT and UsrSCTP aren't > available. > + (list > + "yasm"))) I forgot to mention this, but this should be a snippet, perhaps even a computed origin. Also, as it has been noted in your Nextcloud patch (IIRC), you should formulate this in terms of what to keep. E.g. '(;; custom forks of existing packages ;; the forks are incompatible with what we have in Guix "abseil-cpp" "libsrtp" "openh264" "rnnoise" ;; XXX: packages currently lacking a description "pffft" "usrsctp") > + (add-after 'delete-thirdparty 'copy-inputs > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((libvpx-from (assoc-ref inputs "libvpx")) > + (libyuv-from (assoc-ref inputs "libyuv")) > + (libvpx-to (string-append (getcwd) > + "/src/third_party/li > bvpx/source/libvpx")) > + (libyuv-to (string-append (getcwd) > + "/src/third_party/li > byuv"))) > + (copy-recursively libvpx-from libvpx-to) > + (copy-recursively libyuv-from libyuv-to)) > + #t))))) Should be after unpack (see above), otherwise LGTM. > + ("libvpx" > + ,(origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://chromium.googlesource.com/webm/libvpx") > + (commit "5b63f0f"))) > + (file-name > + (git-file-name "libvpx" version)) > + (sha256 > + (base32 > "1psvxaddihlw1k5n0anxif3qli6zyw2sa2ywn6mkb8six9myrp68")))) > + ("libyuv" > + ,(origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://chromium.googlesource.com/libyuv/libyuv > ") > + (commit "ad89006"))) > + (file-name > + (git-file-name "libyuv" version)) > + (sha256 > + (base32 > "01knnk4h247rq536097n9n3s3brxlbby3nv3ppdgsqfda3k159ll")))) Use long hashes. Also, try to make things work with the nearest release. You might also want to package them individually as "libvpx- for-telegram-desktop" etc. if everything else fails, see stepmania as an example with a custom ffmpeg. As per our discussion in IRC, this should be part of the telegram module. Regards, Leo