From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id mLH/KUt5F2CjOAAA0tVLHw (envelope-from ) for ; Mon, 01 Feb 2021 03:45:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IGq+JUt5F2AADQAAB5/wlQ (envelope-from ) for ; Mon, 01 Feb 2021 03:45:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 007949403E8 for ; Mon, 1 Feb 2021 03:45:11 +0000 (UTC) Received: from localhost ([::1]:43822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6Q9G-0008G5-Pk for larch@yhetil.org; Sun, 31 Jan 2021 22:45:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6Q98-0008Fk-8z for guix-patches@gnu.org; Sun, 31 Jan 2021 22:45:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46898) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l6Q98-0002Rv-1H for guix-patches@gnu.org; Sun, 31 Jan 2021 22:45:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l6Q97-0000v1-U1 for guix-patches@gnu.org; Sun, 31 Jan 2021 22:45:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46215] [PATCH] Add yadm Resent-From: Ellis =?UTF-8?Q?Keny=C5=91?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 01 Feb 2021 03:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46215 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Received: via spool by 46215-submit@debbugs.gnu.org id=B46215.16121510583452 (code B ref 46215); Mon, 01 Feb 2021 03:45:01 +0000 Received: (at 46215) by debbugs.gnu.org; 1 Feb 2021 03:44:18 +0000 Received: from localhost ([127.0.0.1]:58441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6Q8P-0000tb-P2 for submit@debbugs.gnu.org; Sun, 31 Jan 2021 22:44:18 -0500 Received: from mail.elken.dev ([165.22.120.78]:36147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l6Q8M-0000tN-S1 for 46215@debbugs.gnu.org; Sun, 31 Jan 2021 22:44:15 -0500 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 79CCA3F14E; Mon, 1 Feb 2021 04:44:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1612151048; bh=SFtrD+rnxu8VzNkrJ2l1TU3F6gFEYbYQK4nd6LXFjUI=; h=In-Reply-To:References:Subject:From:Date:To:CC:From; b=a3NIJswDx2XIVr1c2tZwMkcRaEX3D2o2vg/FJULAtmFhHJQKQltnX2D8AulieDGpS 99y5QzgC8blz2bG3kFPLk6kWkTu0hCQXvQMTbhUSJZpLIHsqJGJUHfpLHHb2NjiZNe SBUBpWCP0x7l2rRsaibt+bqIXv1JhNTeB+LuFPCrYIlQPl0RKJMLH2cNhY8h+gYnES duZaHASCLwROywWkUzoXkqjL0jDCY0f7VpVTjEvspheR2DPi8H/qW8dyGXcCPQ9KCC Ej1GMBnZ/m1ojiBgUlydcmF1RfDyx/Yv40/ianKM8mWEVpCnO7q+A29MhZ/CXPu1W7 rgRssQJqKwQBw== In-Reply-To: <0ff6a0c2cc9a2f65cd51c1eeb9e6a33aa4789766.camel@student.tugraz.at> References: <20210131164721.8792-1-me@elken.dev> <84ab5054792abeb5e9b85d21229cd7182204d817.camel@student.tugraz.at> <87czxkc0yv.fsf@elken.dev> <0ff6a0c2cc9a2f65cd51c1eeb9e6a33aa4789766.camel@student.tugraz.at> X-Referenced-Uid: 2577 Thread-Topic: Re: [PATCH] Add yadm X-Is-Generated-Message-Id: true MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----3J4PSSI0ZWU07F1HEYBN3YFS0DRI30" Content-Transfer-Encoding: 7bit Date: Mon, 01 Feb 2021 03:44:06 +0000 Message-ID: <669deac8-ffa5-42ba-8741-3cae0b18220e@elken.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 46215@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Ellis =?UTF-8?Q?Keny=C5=91?= X-ACL-Warn: , Ellis =?UTF-8?Q?Keny=C5=91?= via Guix-patches From: guix-patches--- via X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.86 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elken.dev header.s=mail header.b=a3NIJswD; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 007949403E8 X-Spam-Score: -2.86 X-Migadu-Scanner: scn1.migadu.com X-TUID: gn6qf9AcZzAF ------3J4PSSI0ZWU07F1HEYBN3YFS0DRI30 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Leo, I understand what to do, I just wasn't sure how dependencies insta= lled later would be handled=2E Some are optional and if they don't exist ya= dm just carries on, but some are required=2E Would the optional ones still= be handled? On 31 Jan 2021, 20:36, at 20:36, Leo Prikler wrote: >Hi Ellen, > >Am Sonntag, den 31=2E01=2E2021,= 20:16 +0000 schrieb Ellis Keny=C5=91: >> Hi Leo, >> >> Thanks for the fee= dback=2E >> >> > Your commit is missing a ChangeLog in its message=2E >> T= his will be added with the next patch=2E >> >> > Document why (i=2Ee=2E "n= o check target")=2E >> I have also added similar comments for the other rem= oved stages=2E >That's not as important, gnu-build-system is often used as = base for >packages and build system, that don't actually have configure=2E = For >disabled tests, however, it is not clear without comment whether they= >fail or whether they simply don't exist=2E > >> > yadm has a few things y= ou need to patch=2E For one, its shebang >> > is >> > /bin/sh despite req= uiring bash=2E Also it contains a large number >> > of >> > _PROGRAM vari= ables, which would be need to be replaced by their >> > actual >> > store = path (use the which procedure for that)=2E >> >> Patch them to be the $(wh= ich ) expression or evaluate that? >> If the latter, I'm not sure how = that would handle installing deps >> retroactively=2E >You'd add the packag= es, that define those programs as inputs, then >you do something along the = lines of > > (substitute* "yadm" > (("(=2E*)_PROGRAM=3D\"(=2E*)\"" all= var prog) > (format #f "~a_PROGRAM=3D~s" var (which prog)))) > >inside= some phase after unpack=2E >Please apologize if the snippet above doesn't = actually work for your >case, I haven't tried it=2E > >By the way, git form= at-patch seems to swallow the Umlaut (or however >it's called in your langu= age) in your surname=2E If you want it to be >that way, then fair enough, = just know that there's no policy >prohibiting UTF-8 in committer names=2E >= >Regards, >Leo ------3J4PSSI0ZWU07F1HEYBN3YFS0DRI30 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hi Leo,
<= br>
I understand what to do, I just wasn't sure how= dependencies installed later would be handled=2E Some are optional and if = they don't exist yadm just carries on, but some are required=2E

Would the optional ones still be handled?
On 31 Jan 2021, at 20:36, Leo Prikler <leo=2Eprikle= r@student=2Etugraz=2Eat> wrote:
Hi Ellen,

Am Sonntag, de=
n 31=2E01=2E2021, 20:16 +0000 schrieb Ellis Keny=C5=91:
 Hi Leo,
 
 Thanks for the feedback=
=2E
 
 Your commit i=
s missing a ChangeLog in its message=2E
 This will be added=
 with the next patch=2E
 
 Document why (i=2Ee=2E "no check target")=2E
 I have=
 also added similar comments for the other removed stages=2E
That's not as important, gnu-build-system is often used as base for
pa=
ckages and build system, that don't actually have configure=2E  For
disa=
bled tests, however, it is not clear without comment whether they
fail o=
r whether they simply don't exist=2E

 yadm ha=
s a few things you need to patch=2E  For one, its shebang 
 is
 /bin/=
sh despite requiring bash=2E  Also it contains a large number 
 of
 _=
PROGRAM variables, which would be need to be replaced by their 
 actual<=
br> store path (use the which procedure for that)=2E
 
 =
Patch them to be the $(which <exe>) expression or evaluate that?
 =
If the latter, I'm not sure how that would handle installing deps
 retro=
actively=2E
You'd add the packages, that define those progr=
ams as inputs, then
you do something along the lines of

  (substi=
tute* "yadm" 
    (("(=2E*)_PROGRAM=3D\"(=2E*)\"" all var prog)
     =
(format #f "~a_PROGRAM=3D~s" var (which prog))))

inside some phase a=
fter unpack=2E
Please apologize if the snippet above doesn't actually wo=
rk for your
case, I haven't tried it=2E

By the way, git format-pa=
tch seems to swallow the Umlaut (or however
it's called in your language=
) in your surname=2E  If you want it to be
that way, then fair enough, j=
ust know that there's no policy
prohibiting UTF-8 in committer names=2E<=
br>
Regards,
Leo
------3J4PSSI0ZWU07F1HEYBN3YFS0DRI30--