From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp2.migadu.com ([2001:41d0:403:58f0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms13.migadu.com with LMTPS
	id YGQzF3G20WboJwAAe85BDQ:P1
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Fri, 30 Aug 2024 12:09:21 +0000
Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp2.migadu.com with LMTPS
	id YGQzF3G20WboJwAAe85BDQ
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Fri, 30 Aug 2024 14:09:21 +0200
X-Envelope-To: larch@yhetil.org
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=nz8ZX28b;
	dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=MTmuMIiq;
	dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none);
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1725019761;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=5iqSmkwWCrSPZMPk1hIfa8ue+YyNIWJwUjK3KZNwsmU=;
	b=a1tnUAiNtzbKAC7/WhTkPs6YOiEoVEbyPRw3TNVF7hIKvimh/BVsp5vTYyOemIfb0lzQTG
	Q9OVQhNSt0YPBXV7G3tll0sS8gi5p7vH8jUGPqe6lLBL2KVDtukDt1bI7veTSQVbVr0Sem
	jSWaugm/4fnK/oP4RskP5lZtTRqfrzs1LXlZheSCuoSOkNeIZggAQVAe6qEU1SjZOlC9Fh
	m5x1UF3RMJXaeDgOPaa1wttqmMAHt9MEZRx84Oa2vRsHoa1OraMdV9pKhZxJ2XOTACCjpF
	mWjKqhbcc5VBc9h+mktmVU2+xoba+/RvNyJG/wu46LZV+sjpwIImxyfAJ1WdRg==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725019761; a=rsa-sha256; cv=none;
	b=Zm4KSUsFUEgmqTeEl1kizqH3V9sMfBZGw4kNJgFy/6lWRyGYPbeMlKRP+HqCrOyUSAxtAd
	Y3D+G/mtcMiGGsBFH73Th+gpqLpo0I25vVDygucUJMAMNX9RDQtL+tnfrP3OvWqLyYk1Fx
	E8GLQvVHf7xOkCqUxrtVdopSZ6zS4oKtmibIkCmSSjypnXTF+oDEERyrr3koQNjK+BH8Q0
	t+lYHbCBYt/8wSJaz9xFQsUBofozwtW0Ics7r818yK2TTjEISyCVmPD7dh23R+g2pD75E2
	1Csi8OLfhVCVTlLzB4jzsaC6hNXUZKalUTxcRxcPaK4Arx4q4d5+PghjpGMCRw==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=nz8ZX28b;
	dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=MTmuMIiq;
	dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none);
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 91DAF8665
	for <larch@yhetil.org>; Fri, 30 Aug 2024 14:09:20 +0200 (CEST)
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces@gnu.org>)
	id 1sk0RA-00011U-0R; Fri, 30 Aug 2024 08:09:08 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1sk0R8-00011M-1p
 for guix-patches@gnu.org; Fri, 30 Aug 2024 08:09:06 -0400
Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1sk0R7-0004DI-OE
 for guix-patches@gnu.org; Fri, 30 Aug 2024 08:09:05 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=debbugs.gnu.org; s=debbugs-gnu-org; 
 h=In-Reply-To:From:References:MIME-Version:Date:To:Subject;
 bh=5iqSmkwWCrSPZMPk1hIfa8ue+YyNIWJwUjK3KZNwsmU=; 
 b=nz8ZX28boVfWzwgi/mI2amTE3lF5JoUVbOB4AP/N0feHBfOQXpEX175gygqeeSsVw0dfwEWMVyRC4VL9IndDcFSYRQ1erMLuVFgAZ/6CYkI5fiCc3qHOLFJXxG3jwj/D9GjDlQ6d5pCy3pxAs/DYdpKqkIl1DmpVyMutLdyERQi98h1FllwqEDGrzALvK7SzcrpOevXPewh6kLmY61QuIGPRSWnP3ZCDw33a6mubJyzq04zOfNa0Zimmmvu0LqOWhFkqBIuTsBNrJxY9JW23BmKV9oXk09tG3hy0pMVhJm4KSubgDjsA4r5U4VdUaFCAH/tGjKiNYAqY2y9zsp37KA==;
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1sk0S1-0002o5-JT
 for guix-patches@gnu.org; Fri, 30 Aug 2024 08:10:01 -0400
X-Loop: help-debbugs@gnu.org
Subject: [bug#72867] [PATCH] gexp: Make 'local-file' follow symlinks.
Resent-From: Nigko Yerden <nigko.yerden@gmail.com>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Fri, 30 Aug 2024 12:10:01 +0000
Resent-Message-ID: <handler.72867.B72867.172501976510732@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 72867
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 72867@debbugs.gnu.org
Received: via spool by 72867-submit@debbugs.gnu.org id=B72867.172501976510732
 (code B ref 72867); Fri, 30 Aug 2024 12:10:01 +0000
Received: (at 72867) by debbugs.gnu.org; 30 Aug 2024 12:09:25 +0000
Received: from localhost ([127.0.0.1]:52580 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1sk0RE-0002ml-Av
 for submit@debbugs.gnu.org; Fri, 30 Aug 2024 08:09:25 -0400
Received: from mail-lf1-f67.google.com ([209.85.167.67]:49407)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <nigko.yerden@gmail.com>) id 1sk0RA-0002mP-Eq
 for 72867@debbugs.gnu.org; Fri, 30 Aug 2024 08:09:10 -0400
Received: by mail-lf1-f67.google.com with SMTP id
 2adb3069b0e04-53349d3071eso2278401e87.2
 for <72867@debbugs.gnu.org>; Fri, 30 Aug 2024 05:08:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1725019626; x=1725624426; darn=debbugs.gnu.org;
 h=content-transfer-encoding:in-reply-to:from:content-language
 :references:cc:to:subject:user-agent:mime-version:date:message-id
 :from:to:cc:subject:date:message-id:reply-to;
 bh=5iqSmkwWCrSPZMPk1hIfa8ue+YyNIWJwUjK3KZNwsmU=;
 b=MTmuMIiq9JvRkcUrSmTn1krVuZ0pXPBaolMhMTcGdPuA9/AcBEcRuFPEcUCHvGytX5
 dJ+AGrT10QYeVgH/v/i0PBjLzNAGIwxNOgXSn0bb5to6UYGGK15BUsX9ZFADZjIBpFPR
 qhm1oDqp2jJEQUXEV1ITRQboxVRrOp3JjnPbr/OWw4BKk7QMmtA4/+rNhvASFPpnKrjD
 0AaJ43q/By5m0pcQi8jQvYnfbCMKGG0aEBeXSgKuJz+QMSDPm4Nlk9GscUTDsIZzhKOp
 wirFCPbbZFo6dRM5ElnE71461xVB7um9iFUsGFNifA0GMQbg+KaTqCikI0kGpMJjakK3
 y61A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1725019626; x=1725624426;
 h=content-transfer-encoding:in-reply-to:from:content-language
 :references:cc:to:subject:user-agent:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=5iqSmkwWCrSPZMPk1hIfa8ue+YyNIWJwUjK3KZNwsmU=;
 b=nTPJzreYr8ODSR7l1Vr9azNSNRr/BY5wqwjcfb7iSXxZLzBDNYlUf+sloyVmlaPc5y
 X95RRuL+Y1InGczd5i/I+4YinfaCa49v8V6qKYMzFzYoRiuy57UJFQ6t+S5C2Ek8gBAi
 5YaPivBpWH8Dbk8KRWfaYX3lgfoX7wl97lYLwCF1YvPHntQvVh/3v34DENfsxohRxRz9
 Wfeoxo/l0+ixH9znavwtxIGaVMCW0WnbmaY+v8luTLhwonX1DNZN2VD5oV9lEKiwNTF8
 l0QYuAeyZZN10O1ho+XtnlJAR5KriGMb/7Dw8QsHMT/aMm6O1KsLsv0kG3LcEj4f9JYq
 asjQ==
X-Gm-Message-State: AOJu0Yxc2K4vDK9xdNyXT7jEg45bMEKklUiZ1bBw/3dnqhxtzomkt/sk
 uw+aCs0nBa7o9iwB02mQ6ywiak+9QZbpsP4v27TaKHyq0ga7PT/K
X-Google-Smtp-Source: AGHT+IFcQwkhCseaaPHr57n1F3fcX2gz3sZArX2PJu1wJlslUykyM1GecugowRSsMu92Zcu9CoPqpw==
X-Received: by 2002:a05:6512:10cc:b0:530:b760:92b3 with SMTP id
 2adb3069b0e04-53546b3fdc7mr1554176e87.31.1725019624765; 
 Fri, 30 Aug 2024 05:07:04 -0700 (PDT)
Received: from [127.0.0.1] ([188.68.135.139]) by smtp.gmail.com with ESMTPSA id
 2adb3069b0e04-535407ad56bsm572951e87.116.2024.08.30.05.07.04
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Fri, 30 Aug 2024 05:07:04 -0700 (PDT)
Message-ID: <6650f73f-e3d7-47ed-86df-ad9fa5f8cf7d@gmail.com>
Date: Fri, 30 Aug 2024 17:07:03 +0500
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
References: <e2bf165fc2905bcc8d33d23293eb3d31f3fbe4b8.1724911574.git.nigko.yerden@gmail.com>
 <87frqnhffj.fsf@gnu.org> <87v7zjbpxa.fsf@pelzflorian.de>
Content-Language: en-US
From: Nigko Yerden <nigko.yerden@gmail.com>
In-Reply-To: <87v7zjbpxa.fsf@pelzflorian.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: guix-patches-bounces+larch=yhetil.org@gnu.org
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: US
X-Migadu-Spam-Score: -6.41
X-Spam-Score: -6.41
X-Migadu-Queue-Id: 91DAF8665
X-Migadu-Scanner: mx11.migadu.com
X-TUID: DpDHYlH+1vWo

Hello Florian,

> I contributed only the error location in a failed fix.
Discussions and testings also should be counted. Without your
suggestions I would hardly have made this patch.
Thank you for all this.

> There are currently no tests for `current-source-directory'.
> To make a test case like in test/channels.scm, we would have to make
> a new guile process or build process, I presume?
I was thinking about making a test to 'local-file'. It is natural
taking into account the problem this patch solves sits in
'local-file' bad behavior. But 'current-source-directory'
is fine already.

Regards,
Nigko



pelzflorian (Florian Pelz) wrote:
> Hello all.  Thank you to Nigko for sending the patch.
> 
> Nigko Yerden <nigko.yerden@gmail.com> writes:
>> This patch is the result of collective work of
>> Florian Pelz <pelzflorian@pelzflorian.de> and
>> Nigko Yerden <nigko.yerden@gmail.com>
> 
> All real contribution to this patch is Nigko’s work.
> I contributed only the error location in a failed fix.
> 
> 
> Ludovic Courtès <ludo@gnu.org> writes:
>> I haven’t read the thread above.  Could you come up with a test case
>> that shows the problem being fixed?  (That is, the test should fail when
>> run on current ‘master’.)
> 
> Nigko sums up the fixed issue in
> <https://lists.gnu.org/archive/html/guix-devel/2024-08/msg00071.html>:
>> pelzflorian (Florian Pelz) wrote:
>>> Nonsense; it must have worked; 7.7 Wrapping Up lists
>>> https://git.savannah.gnu.org/cgit/guile.git/tree/.guix/modules/guile-package.scm?id=cd57379b3df636198d8cd8e76c1bfbc523762e79
>>> as proof.
>> […]
>> For me pulling from this channel with subsequent
>>
>> $ guix build guile@3.0.99-git
>>
>> throws an error ("No such file or directory" "GUILE-VERSION"). However,
>>
>> $ GUILE_LOAD_PATH= guix build guile@3.0.99-git
>>
>> , which emulates system without [1] in Guile load path, works like a charm.
>> Thus, this repository behaves exactly as does the main branch of [2].
>>
>> Perhaps many systems (e.g. Guix on foreign distributions) indeed does not
>> have [1] in Guile load path, and thus recipe from the Cookbook works for them.
>>     Regards,
>> Nigko
>>
>> [1] ~/.config/guix/current/share/guile/site/3.0/
>> [2] https://gitlab.com/anigko/test-channel.git
> 
> There are currently no tests for `current-source-directory'.
> To make a test case like in test/channels.scm, we would have to make
> a new guile process or build process, I presume?
> 
> Regards,
> Florian