From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id INirM7ovGmKDXAAAgWs5BA (envelope-from ) for ; Sat, 26 Feb 2022 14:48:42 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sM/5MLovGmLzVAAA9RJhRA (envelope-from ) for ; Sat, 26 Feb 2022 14:48:42 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 71C803417A for ; Sat, 26 Feb 2022 14:48:42 +0100 (CET) Received: from localhost ([::1]:40970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNxRB-0005g6-E1 for larch@yhetil.org; Sat, 26 Feb 2022 08:48:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNxQY-0005f9-HS for guix-patches@gnu.org; Sat, 26 Feb 2022 08:48:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60651) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNxQY-0004Ik-8R for guix-patches@gnu.org; Sat, 26 Feb 2022 08:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNxQY-0006nX-4o for guix-patches@gnu.org; Sat, 26 Feb 2022 08:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53878] [PATCH v5 03/22] gnu: racket: Use Git origins for Racket packages. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 26 Feb 2022 13:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53878 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , 53878@debbugs.gnu.org, zimoun Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxime Devos , Attila Lendvai , Malte Gerdes , raingloom Received: via spool by 53878-submit@debbugs.gnu.org id=B53878.164588327426116 (code B ref 53878); Sat, 26 Feb 2022 13:48:02 +0000 Received: (at 53878) by debbugs.gnu.org; 26 Feb 2022 13:47:54 +0000 Received: from localhost ([127.0.0.1]:54548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNxQP-0006nA-KJ for submit@debbugs.gnu.org; Sat, 26 Feb 2022 08:47:53 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:53903) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNxQN-0006mh-48 for 53878@debbugs.gnu.org; Sat, 26 Feb 2022 08:47:52 -0500 Received: from kagayaki.fritz.box (85-127-52-93.dsl.dynamic.surfer.at [85.127.52.93]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4K5SdG5sD4z3xcY; Sat, 26 Feb 2022 14:47:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1645883267; bh=acNOJwCfD+uXnFjNrzfl32j/Z0z2W60d6rBCJRa+3c0=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Av6EA8T8GloIX0hrMWpJdl7J8tfTm1Crc8Ymg1POXLwjyK/488hbs4/pGqqUeYWNZ AVv4PCQJj90YzcT8NU6DcAotqJvGHBOFKbKli7fXdNme/FNPGwilVSBz1D09/7WYil FzSTzOOHfh5/plthT+Vb1F9ZrFFw50Fr9xwgBW70= Message-ID: <649ff53c6b4ff05db5bad3c75abd9d49752930d1.camel@ist.tugraz.at> From: Liliana Marie Prikler Date: Sat, 26 Feb 2022 14:47:45 +0100 In-Reply-To: <20220226130254.1301333-4-philip@philipmcgrath.com> References: <20220220060610.178131-1-philip@philipmcgrath.com> <20220226130254.1301333-1-philip@philipmcgrath.com> <20220226130254.1301333-4-philip@philipmcgrath.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645883322; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=acNOJwCfD+uXnFjNrzfl32j/Z0z2W60d6rBCJRa+3c0=; b=OtdQiAjFRP/tQ1kz3inU7hwAbiM/VUDuxN6hIIxCGEtHXWLr6z8XEPRUAcmizLsF1Vu8M7 XF0PD+5R3dHnMGxr9FFm2pVDiwnuXX9d10NS6q/NcESava/d1FhPivj3YMQ2VeHl2KJ68k bOKXkmH/64VrXOFpQqvEoXKg5kUGRKiriljJntb5E5S3VAjopuqa5OomcWM3rg89I9sezJ 0nigCSM8yDjIbfNQ/+JNe80ZOmCFFWaSujrF1765kY8aC+K4wDmJlcQf7x0IALOYr2kJWJ X6tftRq5hZka/z3PQBCrUDtSpXM4g6AxpnIfDqQp4WMcPOpplnUL8zCMVELaQA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645883322; a=rsa-sha256; cv=none; b=f413eA3ig2hAQFee7TIDqiJ02rNmwxqAZinfN69OZ1h5b877RMOzagYFQzwxwx66y/EbU3 KwsebE27wqKk6h7MeBAUtt1eD0cESHkNNs2r+iZtNulK5/vamqSZ8GVybZCo4PQP4BzQNW JkYoFBJf9ul46xopiaqdMy2lufEp7L16orKrRS9Ix5lNTKoRWnHQ5wLVfQ+/SB2Xfy4c/v ztFtxoFEDpcSNtxY8Fs86Amuh1WjbiAx3EQeEDvFYkMfzy1NFaYUepfJ5iPRRiy6rIR4Uy TL+TqALTjPlXLx6oG6tj0ED8T2+uSSKgVlRkjMMSq+LQVPDR0vU0yqNTOVpy5A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=Av6EA8T8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.38 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=Av6EA8T8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 71C803417A X-Spam-Score: 6.38 X-Migadu-Scanner: scn0.migadu.com X-TUID: TROzBQ9htCGs Am Samstag, dem 26.02.2022 um 08:02 -0500 schrieb Philip McGrath: > * gnu/packages/patches/racket-gui-tethered-launcher-backport.patch: > Adjust path. > * gnu/packages/racket.scm (extract-package-source, > extract-package-source*): New procedures. > (extend-layer): Rename to ... > (make-installation-layer.rkt): ... this variable. Tweak command-line > arguments. Adapt to 'config-tethered-apps-dir'. > (racket): Stop inheriting from 'racket-minimal'. > [version]: Use '%racket-version'. > [source]: Stop using bundled tarball. > [inputs]: Remove labels. Add 'racket-minimal' and package sources. > [native-inputs]: Remove, since cross-compilation doesn't work yet. > [arguments]: Rewrite to use G-expressions, package sources from > 'inputs', an explicit 'install' phase, and the revised > 'make-installation-layer.rkt'. Since you haven't made this a union-build yet, I will from now on assume that it is indeed more complicated than one to save us some time debating whether it should or shouldn't be. Given that this was my main complaint w.r.t. the stuff following make-installation-layer, much is now resolved, except for two things. First, can we simplify "make-installation-layer.rkt" to "make- installation-layer"? I don't think the file extension conveys much meaning here, or does it? Second, can we find an abbreviation for > +      (extract-package-source* > +       `((,(origin > +             (method git-fetch) > +             (uri (git-reference > +                   (url "https://github.com/racket/2d") > +                   (commit %racket-commit))) > +             (sha256 (base32 > +                      > "1zzcz5qyjv7syi41vb8jkxjp1rqgj61zbsdrg0nlc4qy9qsafzgr")) > +             (file-name > +              (git-file-name "racket-2d" %racket-version))) > +          "2d" "2d-doc" "2d-lib") > +         (,(origin > +             (method git-fetch) > +             (uri (git-reference > +                   (url "https://github.com/racket/algol60") > +                   (commit %racket-commit))) > +             (sha256 (base32 > +                      > "09kj6asypmc24n29w0izc9p0q8hpga2hpkchsypfwn5c8zpvihlx")) > +             (file-name > +              (git-file-name "racket-algol60" %racket-version))) > +          ("algol60" ".")) > +         (,%racket-origin > +          ("base" "pkgs/base") ;; FIXME belongs in racket-minimal > +          ("racket-lib" "pkgs/racket-lib") ;; FIXME belongs in > racket-minimal > +          ("at-exp-lib" "pkgs/at-exp-lib") > +          ("compiler" "pkgs/compiler") > +          ("compiler-lib" "pkgs/compiler-lib") > +          ("net" "pkgs/net") > +          ("net-doc" "pkgs/net-doc") > +          ("net-lib" "pkgs/net-lib") > +          ("racket-doc" "pkgs/racket-doc") > +          ("racket-index" "pkgs/racket-index") > +          ("sandbox-lib" "pkgs/sandbox-lib") > +          ("zo-lib" "pkgs/zo-lib")) > +         (,(origin > +             (method git-fetch) > +             (uri (git-reference > +                   (url "https://github.com/racket/cext-lib") > +                   (commit %racket-commit))) > +             (sha256 (base32 > +                      > "00w38jpv88fpl4pgj6ndnysvn0s21rjvj0xhznay80msan0vc341")) > +             (file-name (git-file-name "racket-cext-lib" %racket- > version))) > +          "cext-lib" "dynext-lib") > [...] I think some way to shorten those origins would do wonders in terms of the number of lines this patch adds. Other than that, looks pretty good to me.