From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePrfh-0001ID-0k for guix-patches@gnu.org; Fri, 15 Dec 2017 10:13:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePrfa-0001c3-H7 for guix-patches@gnu.org; Fri, 15 Dec 2017 10:13:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:55480) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ePrfa-0001b3-AY for guix-patches@gnu.org; Fri, 15 Dec 2017 10:13:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ePrfZ-0006jT-Vb for guix-patches@gnu.org; Fri, 15 Dec 2017 10:13:02 -0500 Subject: [bug#29719] [PATCH] gnu: virtualization: Add lookingglass. Resent-Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_4c0b20ece82a7ae101c6550fdd87c75f" Date: Fri, 15 Dec 2017 16:11:51 +0100 From: Rutger Helling In-Reply-To: <78341e76d8e762763e5c8c9b464ea9b7@mykolab.com> References: <87bmj0hy98.fsf@gnu.org> <78341e76d8e762763e5c8c9b464ea9b7@mykolab.com> Message-ID: <649e163286d9a0c40f551b22e502a03b@mykolab.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: ludo@gnu.org Cc: 29719@debbugs.gnu.org --=_4c0b20ece82a7ae101c6550fdd87c75f Content-Type: multipart/alternative; boundary="=_8f9e9020add901be0412d437605aae14" --=_8f9e9020add901be0412d437605aae14 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Forgot to put two spaces in the lines for the description. Here's the proper patch, sorry about that. On 2017-12-15 16:05, Rutger Helling wrote: > Thanks for reviewing! Here's an updated patch based on your feedback. > > On 2017-12-15 15:16, ludo@gnu.org wrote: > Hello! > > Rutger Helling skribis: > > From ccea9a6c9dd71aea5ef5c07802f7e376a7f86a96 Mon Sep 17 00:00:00 2001 > From: Rutger Helling > Date: Fri, 15 Dec 2017 11:58:10 +0100 > Subject: [PATCH] gnu: virtualization: Add lookingglass. > > * gnu/packages/virtualization.scm (lookingglass): New variable. > [...] > > +(define-public lookingglass > + (package > + (name "lookingglass") > Please run: > > ./etc/indent-code.el gnu/packages/virtualization.scm lookingglass > > + (version "a5") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/gnif/LookingGlass/archive/" > + version ".tar.gz")) > + (file-name (string-append name "-" version)) > + (sha256 > + (base32 > + "0lrb821914fp27xaq0spwhbblssz55phiygvdlvcrkifa138v8pf")))) > + (build-system gnu-build-system) > + (inputs `(("fontconfig" ,fontconfig) > + ("glu" ,glu) > + ("mesa" ,mesa) > + ("openssl" ,openssl) > + ("sdl2" ,sdl2) > + ("sdl2-ttf" ,sdl2-ttf) > + ("spice-protocol" ,spice-protocol))) > + (native-inputs `(("pkg-config", pkg-config))) > + (arguments > + `(#:tests? #f ;; No tests are available. > + #:phases (modify-phases %standard-phases > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) > + (chdir "client"))) > Return #t. > > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (mkdir-p (string-append %output "/bin")) > + (copy-file "bin/looking-glass-client" (string-append > + %output "/bin/looking-glass-client"))))))) > Same here. > > Use the 'outputs' argument instead of the '%output' global variable. > > Also, you can replace the mkdir-p/copy-file pair with just: > > (install-file "bin/looking-glass-client" > (string-append (assoc-ref outputs "out") "/bin")) > > + (home-page "https://looking-glass.hostfission.com") > + (synopsis "Low-latency KVMFR implementation for QEMU guests with VGA PCI > +passthrough") > + (description "LookingGlass is an extremely low latency KVMFR (KVM FrameRelay) > +implementation for QEMU guests with VGA PCI Passthrough.") > Could you shorten the synopsis and expound the description a little bit? > :-) I find it hard to understand what this is about looking at this. > > + (license gpl2))) > AFAICS source file headers explicitly say "or any later version", so > this should be 'gpl2+'. > > The rest LGTM. Could you send an updated patch? > > Thank you! > > Ludo'. --=_8f9e9020add901be0412d437605aae14 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8

Forgot to put two spaces in the lines for the description.
Here's t= he proper patch, sorry about that.

On 2017-12-15 16:05, Rutger Helling wrote:

Thanks for reviewing! Here's an updated patch based on your feedback.

On 2017-12-15 15:16, ludo@gnu.org wrote:

Hello!

Rutger Helling <rhelling@mykolab.com> skribis:

From ccea9a6c9dd71aea5ef5c07802f7e376a7f86a96 Mon Sep 17 00:00:00 2= 001
From: Rutger Helling <= rhelling@mykolab.com>
Date: Fri, 15 Dec 2017 11:58:10 +0100 Subject: [PATCH] gnu: virtualization: Add lookingglass.

* = gnu/packages/virtualization.scm (lookingglass): New variable.

[...]

+(define-public lookingglass
+  (package
+  &= nbsp;(name "lookingglass")

Please run:

  ./etc/indent-code.el gnu/packag= es/virtualization.scm lookingglass

+   (version "a5")
+   (source
+ &n= bsp;  (origin
+     (method url-fetch)<= br /> +     (uri (string-append "https://github.com/gnif/LookingGlass/archive/"
+  &nb= sp;            =           version ".tar= =2Egz"))
+     (file-name (string-append name "-"= version))
+     (sha256
+   &nbs= p;  (base32
+       "0lrb8219= 14fp27xaq0spwhbblssz55phiygvdlvcrkifa138v8pf"))))
+   (buil= d-system gnu-build-system)
+   (inputs `(("fontconfig" ,fon= tconfig)
+          &nbs= p;  ("glu" ,glu)
+       &nbs= p;     ("mesa" ,mesa)
+    &n= bsp;        ("openssl" ,openssl) +            &nb= sp;("sdl2" ,sdl2)
+         &= nbsp;   ("sdl2-ttf" ,sdl2-ttf)
+    &nb= sp;        ("spice-protocol" ,spice= -protocol)))
+   (native-inputs `(("pkg-config", pkg-config= )))
+   (arguments
+    `(#:tests? #f = ;; No tests are available.
+      #:phases (= modify-phases %standard-phases
+       =           (replace 'confi= gure
+           &n= bsp;        (lambda* (#:key outputs= #:allow-other-keys)
+        &nbs= p;            &= nbsp;(chdir "client")))

Return #t.

+            = ;      (replace 'install
+   =             &nb= sp;    (lambda* (#:key outputs #:allow-other-keys)
+             = ;         (mkdir-p (string-app= end %output "/bin"))
+        &nbs= p;            &= nbsp;(copy-file "bin/looking-glass-client" (string-append
+  &nb= sp;            =             &nb= sp;     %output "/bin/looking-glass-client")))))))=

Same here.

Use the 'outputs' argument instead of the '%= output' global variable.

Also, you can replace the mkdir-p/cop= y-file pair with just:

  (install-file "bin/looking-= glass-client"
         &= nbsp;      (string-append (assoc-ref outputs = "out") "/bin"))

+   (home-page "https://looking-glas= s.hostfission.com")
+   (synopsis "Low-latency KVMFR im= plementation for QEMU guests with VGA PCI
+passthrough")
+ &nbs= p; (description "LookingGlass is an extremely low latency KVMFR (KVM F= rameRelay)
+implementation for QEMU guests with VGA PCI Passthrough= =2E")

Could you shorten the synopsis and expound the description a little = bit?
:-)  I find it hard to understand what this is about lookin= g at this.

+   (license gpl2)))

AFAICS source file headers explicitly say "or any later version", so=
this should be 'gpl2+'.

The rest LGTM.  Could you = send an updated patch?

Thank you!

Ludo'.



--=_8f9e9020add901be0412d437605aae14-- --=_4c0b20ece82a7ae101c6550fdd87c75f Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-gnu-virtualization-Add-lookingglass-v3.patch Content-Disposition: attachment; filename=0001-gnu-virtualization-Add-lookingglass-v3.patch; size=2784 RnJvbSA0NzlkYjJmMTE4MzdhMTc1NTk4ZmNjMDRjYzA3YmVlMDMwZjE3ZmIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSdXRnZXIgSGVsbGluZyA8cmhlbGxpbmdAbXlrb2xhYi5jb20+ CkRhdGU6IEZyaSwgMTUgRGVjIDIwMTcgMTY6MDg6MzAgKzAxMDAKU3ViamVjdDogW1BBVENIXSBn bnU6IHZpcnR1YWxpemF0aW9uOiBBZGQgbG9va2luZ2dsYXNzLgoKKiBnbnUvcGFja2FnZXMvdmly dHVhbGl6YXRpb24uc2NtIChsb29raW5nZ2xhc3MpOiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3Bh Y2thZ2VzL3ZpcnR1YWxpemF0aW9uLnNjbSB8IDQ0ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKQoKZGlmZiAt LWdpdCBhL2dudS9wYWNrYWdlcy92aXJ0dWFsaXphdGlvbi5zY20gYi9nbnUvcGFja2FnZXMvdmly dHVhbGl6YXRpb24uc2NtCmluZGV4IDg1NTYzZGRlNi4uMmZjZDllNWE3IDEwMDY0NAotLS0gYS9n bnUvcGFja2FnZXMvdmlydHVhbGl6YXRpb24uc2NtCisrKyBiL2dudS9wYWNrYWdlcy92aXJ0dWFs aXphdGlvbi5zY20KQEAgLTM2LDYgKzM2LDcgQEAKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2Fn ZXMgZG5zKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBkb2Nib29rKQogICAjOnVzZS1t b2R1bGUgKGdudSBwYWNrYWdlcyBkb2N1bWVudGF0aW9uKQorICAjOnVzZS1tb2R1bGUgKGdudSBw YWNrYWdlcyBmb250dXRpbHMpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIGdsKQogICAj OnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBnbGliKQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNr YWdlcyBnbm9tZSkKQEAgLTcwOSwzICs3MTAsNDYgQEAgbWFpbmx5IGltcGxlbWVudGVkIGluIHVz ZXIgc3BhY2UuIikKIGluY3JlbWVudGFsIGJhY2t1cHMgb2YgcnVubmluZyBRRU1VIHZpcnR1YWwg bWFjaGluZXMgdmlhIFFNUCwgdGhlIFFFTVUKIE1hY2hpbmUgUHJvdG9jb2wuIikKICAgICAobGlj ZW5zZSBncGwzKykpKQorCisoZGVmaW5lLXB1YmxpYyBsb29raW5nZ2xhc3MKKyAgKHBhY2thZ2UK KyAgIChuYW1lICJsb29raW5nZ2xhc3MiKQorICAgKHZlcnNpb24gImE1IikKKyAgIChzb3VyY2UK KyAgICAob3JpZ2luCisgICAgIChtZXRob2QgdXJsLWZldGNoKQorICAgICAodXJpIChzdHJpbmct YXBwZW5kICJodHRwczovL2dpdGh1Yi5jb20vZ25pZi9Mb29raW5nR2xhc3MvYXJjaGl2ZS8iCisg ICAgICAgICAgICAgICAgICAgICAgICAgdmVyc2lvbiAiLnRhci5neiIpKQorICAgICAoZmlsZS1u YW1lIChzdHJpbmctYXBwZW5kIG5hbWUgIi0iIHZlcnNpb24pKQorICAgICAoc2hhMjU2CisgICAg ICAoYmFzZTMyCisgICAgICAgIjBscmI4MjE5MTRmcDI3eGFxMHNwd2hiYmxzc3o1NXBoaXlndmRs dmNya2lmYTEzOHY4cGYiKSkpKQorICAgKGJ1aWxkLXN5c3RlbSBnbnUtYnVpbGQtc3lzdGVtKQor ICAgKGlucHV0cyBgKCgiZm9udGNvbmZpZyIgLGZvbnRjb25maWcpCisgICAgICAgICAgICAgKCJn bHUiICxnbHUpCisgICAgICAgICAgICAgKCJtZXNhIiAsbWVzYSkKKyAgICAgICAgICAgICAoIm9w ZW5zc2wiICxvcGVuc3NsKQorICAgICAgICAgICAgICgic2RsMiIgLHNkbDIpCisgICAgICAgICAg ICAgKCJzZGwyLXR0ZiIgLHNkbDItdHRmKQorICAgICAgICAgICAgICgic3BpY2UtcHJvdG9jb2wi ICxzcGljZS1wcm90b2NvbCkpKQorICAgKG5hdGl2ZS1pbnB1dHMgYCgoInBrZy1jb25maWciLCBw a2ctY29uZmlnKSkpCisgICAoYXJndW1lbnRzCisgICAgYCgjOnRlc3RzPyAjZiA7OyBObyB0ZXN0 cyBhcmUgYXZhaWxhYmxlLgorICAgICAgIzpwaGFzZXMgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJk LXBoYXNlcworICAgICAgICAgICAgICAgICAocmVwbGFjZSAnY29uZmlndXJlCisgICAgICAgICAg ICAgICAgICAgKGxhbWJkYSogKCM6a2V5IG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAg ICAgICAgICAgICAgICAgICAgKGNoZGlyICJjbGllbnQiKQorICAgICAgICAgICAgICAgICAgICAg I3QpKQorICAgICAgICAgICAgICAgICAocmVwbGFjZSAnaW5zdGFsbAorICAgICAgICAgICAgICAg ICAgIChsYW1iZGEqICgjOmtleSBvdXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAg ICAgICAgICAgICAgIChpbnN0YWxsLWZpbGUgImJpbi9sb29raW5nLWdsYXNzLWNsaWVudCIKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgKGFzc29jLXJl ZiBvdXRwdXRzICJvdXQiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAiL2JpbiIpKQorICAgICAgICAgICAgICAgICAgICAgI3QpKSkpKQorICAgKGhv bWUtcGFnZSAiaHR0cHM6Ly9sb29raW5nLWdsYXNzLmhvc3RmaXNzaW9uLmNvbSIpCisgICAoc3lu b3BzaXMgIktWTSBGcmFtZSBSZWxheSAoS1ZNRlIpIGltcGxlbWVudGF0aW9uIikKKyAgIChkZXNj cmlwdGlvbiAiTG9va2luZyBHbGFzcyBhbGxvd3MgdGhlIHVzZSBvZiBhIEtWTSAoS2VybmVsLWJh c2VkIFZpcnR1YWwKK01hY2hpbmUpIGNvbmZpZ3VyZWQgZm9yIFZHQSBQQ0kgUGFzcy10aHJvdWdo IHdpdGhvdXQgYW4gYXR0YWNoZWQgcGh5c2ljYWwKK21vbml0b3IsIGtleWJvYXJkIG9yIG1vdXNl LiAgSXQgZGlzcGxheXMgdGhlIFZNJ3MgcmVuZGVyZWQgY29udGVudHMgb24geW91ciBtYWluCitt b25pdG9yL0dQVS4iKQorICAgKGxpY2Vuc2UgZ3BsMispKSkKLS0gCjIuMTUuMQoK --=_4c0b20ece82a7ae101c6550fdd87c75f--