From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: "Efraim Flashner" <efraim@flashner.co.il>,
"Ludovic Courtès" <ludo@gnu.org>
Cc: 37908-close@debbugs.gnu.org
Subject: bug#37908: [PATCH 0/2] Remove monolithic qt5 (and other unused package)
Date: Fri, 1 Nov 2019 17:09:43 +0100 [thread overview]
Message-ID: <63a06330-1a56-9af8-2a82-0d0c8d280298@crazy-compilers.com> (raw)
In-Reply-To: <20191101143954.GK20762@E5400>
[-- Attachment #1.1: Type: text/plain, Size: 942 bytes --]
Am 01.11.19 um 15:39 schrieb Efraim Flashner:
>> Please ensure that “guix build qt@4 -nd” returns the same derivation
>> before and after the change.
Done already before submitting the patch :-) But I repeated it now and
this revealed some error. So many thanks for nagging :-)
>>
>> Perhaps add a comment above saying that ‘qt’ used to refer to the
>> monolithic Qt 5.x package?
Done.
> I didn't apply it locally, I can do it in about 36 hours, but it looks
> good. IIRC we have qt4 inheriting from qt5, and qtbase was its own
> definition so nothing should change on that side.
Correct. I added some more explanation to the commit message to make
this more clear.
Pushed as 02511196d99ebc5e385e9dc7f733ffbe848e25ca
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-11-01 16:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 19:20 [bug#37908] [PATCH 0/2] Remove monolithic qt5 (and other unused package) Hartmut Goebel
2019-10-24 19:23 ` [bug#37908] [PATCH 1/2] gnu: Remove qtdeclarative-render2d Hartmut Goebel
2019-10-24 19:23 ` [bug#37908] [PATCH 2/2] gnu: Remove monolithic qt5 Hartmut Goebel
2019-10-25 10:34 ` [bug#37908] [PATCH 0/2] Remove monolithic qt5 (and other unused package) Efraim Flashner
2019-10-25 10:43 ` Efraim Flashner
2019-10-25 21:33 ` Ludovic Courtès
2019-10-28 9:06 ` Hartmut Goebel
2019-11-01 10:49 ` Ludovic Courtès
2019-11-01 12:18 ` Hartmut Goebel
2019-11-01 14:14 ` Ludovic Courtès
2019-11-01 14:39 ` Efraim Flashner
2019-11-01 16:09 ` Hartmut Goebel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63a06330-1a56-9af8-2a82-0d0c8d280298@crazy-compilers.com \
--to=h.goebel@crazy-compilers.com \
--cc=37908-close@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.