From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Gibbons Subject: Re: 01/01: services: Add =?UTF-8?Q?=E2=80=98=2Fusr=2Fbin=2Fenv=E2=80=99?= special file. Date: Fri, 06 Sep 2019 23:05:52 -0600 Message-ID: <6384138c4454d584c43e0a6144ed18bf458c551a.camel@gmail.com> References: <20190906102509.28951.2772@vcs0.savannah.gnu.org> <20190906102510.002BE21324@vcs0.savannah.gnu.org> <87d0gdbtji.fsf@cbaines.net> <87mufhwhc6.fsf@nckx> <874l1p80zr.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:55613) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6Sv8-0004Zu-VQ for guix-devel@gnu.org; Sat, 07 Sep 2019 01:06:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i6Sv7-0007kp-FN for guix-devel@gnu.org; Sat, 07 Sep 2019 01:05:58 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:39221) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i6Sv7-0007kM-7k for guix-devel@gnu.org; Sat, 07 Sep 2019 01:05:57 -0400 Received: by mail-pl1-x62a.google.com with SMTP id bd8so4150216plb.6 for ; Fri, 06 Sep 2019 22:05:56 -0700 (PDT) In-Reply-To: <874l1p80zr.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Mark H Weaver , Tobias Geerinckx-Rice Cc: guix-devel@gnu.org On Fri, 2019-09-06 at 19:21 -0400, Mark H Weaver wrote: > Hi Tobias, > > Tobias Geerinckx-Rice writes: > > > Christopher, > > > > Christopher Baines 写道： > > > This seems to me like quite a big change, and I'd be interested > > > in > > > knowing what your motivation was [1]? > > > > It's not, really. It's equivalent to the impure /bin/sh that Guix > > Systems already provide, but actually useful: ‘use #!/usr/bin/env, > > not > > #!/bin/sh!’ was already a mantra when I wrote my first shell script > > — > > and I'm not that young. > > > > There's no good argument for not being able to run the vast > > majority > > of well-written scripts, out of the box, on Guix Systems. > > > > I hope that's sufficient, but I don't think it needed to go in the > > commit message. > > This should have been discussed more widely before pushing to > 'master'. > It is not a new idea. We talked about it long ago, and decided that > it > should *not* be included. I don't have the energy right now to > restate > the arguments or find the old discussions. > > Mark > Here's a post with what I think is a good argument against adding /usr/bin/env. I think the standard patch-shebang phase does a good job at preventing the potential issue, but the argument still applies to scripts generated by make, as I learned while attempting to port pysolfc. I recommend you read the thread too. https://lists.gnu.org/archive/html/guix-devel/2015-11/msg00505.html