From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0CDv-0006uf-0j for guix-patches@gnu.org; Mon, 17 Apr 2017 15:22:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0CDr-0008L7-29 for guix-patches@gnu.org; Mon, 17 Apr 2017 15:22:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:54715) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d0CDq-0008Ks-PA for guix-patches@gnu.org; Mon, 17 Apr 2017 15:22:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d0CDq-0006vi-GW for guix-patches@gnu.org; Mon, 17 Apr 2017 15:22:02 -0400 Subject: bug#26500: [PATCH] gnu: Add mcomix. References: Resent-Message-ID: Message-Id: <633024d3.AEEAJmX48o8AAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY9RXB@mailjet.com> MIME-Version: 1.0 From: Arun Isaac Date: Tue, 18 Apr 2017 00:51:31 +0530 In-reply-to: <5e116405-23c7-b059-e4af-9cee0893ae57@cock.li> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 26500@debbugs.gnu.org >> Instead of mentioning p7zip, unrar and mupdf in the description, it >> would be better if we could make them inputs and patch all references to >> the executables in the source with their absolute paths. Could you try t= his? > I could try that, but mupdf is a pretty heavy dependency. guix size says > it's self-size is 208MiB and total-size is 491MiB. > I personally never needed it with mcomix, so I like that it is optional. > Is there some way to define a package with optional inputs? As far as I understand, there is no way to specify optional inputs (yet?). Here are two of many threads discussing this. https://lists.gnu.org/archive/html/guix-devel/2014-11/msg00549.html https://lists.gnu.org/archive/html/guix-devel/2015-05/msg00379.html If mupdf is a heavy dependency and it is not commonly needed, you can drop it and just package with 7z and rar as dependencies. > + (arguments `(#:python ,python-2)) > + (inputs `(("python2-pygtk" ,python2-pygtk) > + ("python2-pillow" ,python2-pillow))) Sort these inputs alphabetically, as I mentioned in the crawl thread. LGTM, otherwise! Please send an updated patch. Thanks! =