all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: 26500@debbugs.gnu.org
Subject: bug#26500: [PATCH] gnu: Add mcomix.
Date: Tue, 18 Apr 2017 00:51:31 +0530	[thread overview]
Message-ID: <633024d3.AEEAJmX48o8AAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY9RXB@mailjet.com> (raw)
In-Reply-To: <5e116405-23c7-b059-e4af-9cee0893ae57@cock.li>


>> Instead of mentioning p7zip, unrar and mupdf in the description, it
>> would be better if we could make them inputs and patch all references to
>> the executables in the source with their absolute paths. Could you try this?
> I could try that, but mupdf is a pretty heavy dependency. guix size says
> it's self-size is 208MiB and total-size is 491MiB.
> I personally never needed it with mcomix, so I like that it is optional.
> Is there some way to define a package with optional inputs?

As far as I understand, there is no way to specify optional inputs
(yet?). Here are two of many threads discussing this.

https://lists.gnu.org/archive/html/guix-devel/2014-11/msg00549.html
https://lists.gnu.org/archive/html/guix-devel/2015-05/msg00379.html

If mupdf is a heavy dependency and it is not commonly needed, you can
drop it and just package with 7z and rar as dependencies.

> +    (arguments `(#:python ,python-2))
> +    (inputs `(("python2-pygtk" ,python2-pygtk)
> +              ("python2-pillow" ,python2-pillow)))

Sort these inputs alphabetically, as I mentioned in the crawl thread.

LGTM, otherwise! Please send an updated patch. Thanks!

  reply	other threads:[~2017-04-17 19:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-14 17:50 bug#26500: [PATCH] gnu: Add mcomix nee
2017-04-15  8:36 ` Arun Isaac
2017-04-15  9:09   ` ng0
2017-04-16  8:53     ` Arun Isaac
2017-04-17  4:45       ` nee
2017-04-17 19:21         ` Arun Isaac [this message]
2017-04-18 22:09           ` nee
2017-04-19 15:53             ` Arun Isaac
2017-04-19 19:54               ` ng0
2017-04-21  9:00               ` Ludovic Courtès
2017-04-21 17:57                 ` Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=633024d3.AEEAJmX48o8AAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY9RXB@mailjet.com \
    --to=arunisaac@systemreboot.net \
    --cc=26500@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.