From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id KDdtEAhyMmbvAAEA62LTzQ:P1 (envelope-from ) for ; Wed, 01 May 2024 18:47:04 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id KDdtEAhyMmbvAAEA62LTzQ (envelope-from ) for ; Wed, 01 May 2024 18:47:04 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=hTEU7ieH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714582024; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=LpgBDTHlaIAeybSmbvHkPrMcjkbh8k/ncVzF7CpPoa0=; b=dr/80/gSvL2j4Ec0BDPL+s2F1AwsiYu7/OJaPDMcC+JKQlWkI3MK3jU4c61F/rrUytvqvq cPEJyYGJruyAC3myTMurmdK4TVx3wbajfL/ndFB5toD187+vg94fgd+U1Jq2Ip5yINAM1E dvGU5yLdiMyrrShlG9eQmpmMkHzXUcsPzK7iUOxpkBQNw0/3a0rIaCZ6chilQhiYPzplg+ ew4VOt8ZeW+YrMoOCCB00M/K6Tz7Y6CanKXFzKe++oMVtcZQEC4DMa2W0sfWaag38uSRXU H1aj3j7zBh0kvn2OMTLIOc64joq9syL9/53msbvFpkY0h3ZDZNEigjWJ9kzDuw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714582024; a=rsa-sha256; cv=none; b=AbWRvOGGvGSh/dJCmNRQnV12Y86gX1VN+ahVJD/RLPVpWqm++Ama4kIOwNZAQd8PZNfFbq Ic514obv+U5VAK0l2hOkUnD/dFSVvylAgB3Ej5C0tFx/qiruO0hPGlS6TONLENZnJqfUjv Hgg2CDznwgDzrAk5HQs8N+EB1aw7/ZwxP72B1XuA+KAPlGrqhdUhuW7WO0eYivOBMERRfP IjMl7gwu76s/UveML17znfXPXezflWIKQi+KclXxLS2loSU7V5zbE5Y3u8v48uXYh0Pzb2 OlxeUgRkI2dGekdR9Lpvehepa2KHMp7tDyok/2ZdspQXPRGt9n5aKQvphX5xzw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=hTEU7ieH; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0361265EDA for ; Wed, 01 May 2024 18:47:04 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2D6c-0004KI-8v; Wed, 01 May 2024 12:46:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2D6P-0004Iy-Mn for guix-patches@gnu.org; Wed, 01 May 2024 12:46:42 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2D6O-0002lm-PS for guix-patches@gnu.org; Wed, 01 May 2024 12:46:41 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s2D6k-0003rH-0n for guix-patches@gnu.org; Wed, 01 May 2024 12:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70632] [PATCH 1/2] aux-files: comp-integrity: Adjust for newer emacs. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 01 May 2024 16:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70632 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Morgan Smith Cc: Katherine Cox-Buday , 70632@debbugs.gnu.org, Andrew Tropin Received: via spool by 70632-submit@debbugs.gnu.org id=B70632.171458201814825 (code B ref 70632); Wed, 01 May 2024 16:47:01 +0000 Received: (at 70632) by debbugs.gnu.org; 1 May 2024 16:46:58 +0000 Received: from localhost ([127.0.0.1]:38347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2D6g-0003r3-3E for submit@debbugs.gnu.org; Wed, 01 May 2024 12:46:58 -0400 Received: from mail-ed1-x541.google.com ([2a00:1450:4864:20::541]:45351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2D6e-0003qp-2n for 70632@debbugs.gnu.org; Wed, 01 May 2024 12:46:56 -0400 Received: by mail-ed1-x541.google.com with SMTP id 4fb4d7f45d1cf-56e1f3462caso9037144a12.3 for <70632@debbugs.gnu.org>; Wed, 01 May 2024 09:46:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714581989; x=1715186789; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=LpgBDTHlaIAeybSmbvHkPrMcjkbh8k/ncVzF7CpPoa0=; b=hTEU7ieH1iT5njlx1CFPraNBYyoo0ewzX3PfgDHkMfUz4THGPkQPdyVAoEq+6JTTrf CH2IxiGCwZ4ct9sH6J2gKvGtSTmk1M3+fbJWV554Vx4qTmOKs/7dKh5n5H+WCtXMrUZ8 i2ZR3ECbieSQkKBaVIM7fZLLNcHPoPQqrbQqWkWkcDE/wRRyV9TIgdUeWx2gJ3Ndn3PH n+j1/bfwaHhk5RqonMOHqIfwAdiBO2lnRXVbuxhgqh09rZsjbDLGcWhjST6PB2iBRpih 4nS9Q01GKBkTpv34ziOBpBGBSy3uRHImzbZ1wegGohyL/JYb9xDnBEK4IBtp6Y98Ccqh 0tlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714581989; x=1715186789; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=LpgBDTHlaIAeybSmbvHkPrMcjkbh8k/ncVzF7CpPoa0=; b=uALd2q0nRLxgXEivx5oWK/fdl768k2weN1La7VDkTjrPSIIBW/y4pIG0K+o5L68BLD bpH0GrUVtJlDcTEwEDIVdzzXwh/6wGvY7u+L15EbxYypgcgnOwPQoqjl1bY8gNHRzTD5 xWioX8QFYYEvaA/rmgYf+7eglZPtr4Phg8rYQBmeHsokkIrREsy2Obm6KfRmmbXsCZtY /r06KjzYy8l7WAN7Hyw90LuL0dEHHNdDaa2XJjLNd3Wxqbw34bl51SuFBealZGIuY678 p/cFR76OomoaAGpNZ4Zn2azVfLpBEpiBQfHA0vvLXtLXKqAYvblV6hMC3rwZHh1Bl+yI azEw== X-Gm-Message-State: AOJu0YwvmOmBJifPXQ23dwczayW2WiBlY5mn5QrHKvuUmxokO8neR+xg fjtCe+ravHlPDjjgafJbJNmYJBCl9zkfkfXfWipQOVjsCRPXlrGY X-Google-Smtp-Source: AGHT+IHAsAIwzuGyanBNFXy+trta1MMpqIcycuyR1ipizHhnP5UjomwcWqf4KFAZ4q37QXt9C8TPsA== X-Received: by 2002:a50:9993:0:b0:572:51fb:5571 with SMTP id m19-20020a509993000000b0057251fb5571mr1948974edb.5.1714581988666; Wed, 01 May 2024 09:46:28 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id q25-20020aa7cc19000000b0057203242f31sm11575525edt.11.2024.05.01.09.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 09:46:28 -0700 (PDT) Message-ID: <632d44c7dda06b0441f8c0ba88f47ea745c7f202.camel@gmail.com> From: Liliana Marie Prikler Date: Wed, 01 May 2024 18:46:23 +0200 In-Reply-To: References: <71e3b67343fca5dfce8633e9aba6414b74de2832.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.79 X-Spam-Score: -0.79 X-Migadu-Queue-Id: 0361265EDA X-Migadu-Scanner: mx11.migadu.com X-TUID: 0uW/OAiShIrI Am Mittwoch, dem 01.05.2024 um 12:32 -0400 schrieb Morgan Smith: > Liliana Marie Prikler writes: >=20 > > Am Montag, dem 29.04.2024 um 16:43 -0400 schrieb Morgan Smith: > > > Liliana Marie Prikler writes: > > >=20 > > > I'm not a fan of adding another file so I came up with this > > > solution. See attached patch. > > Hmm, I'm a bit torn on the solution.=C2=A0 On one hand, it is a local > > solution with just a phase, on the other having the file makes it > > easier to just mv it. >=20 > I don't understand the trade-offs here.=C2=A0 I'm a fan of keeping data a= s > close to where it's used as possible (so ideally in emacs.scm).=C2=A0 I'm > not sure what advantages putting it in a file gives over this > solution. The advantage lies in only rebuilding Emacs 30. > Just to be clear: what do you mean by adding another file?=C2=A0 I assume > you mean adding a comp-integrity-next.el file which is almost > identical to comp-integrity.el with these small changes in place. Yes. > > > If we believe that a core-updates merge will occur before Emacs > > > 30 then I would like to see my original patch applied there. > > It'd be only emacs-team, not core-updates, but we could do this > > "quickly" either way.=C2=A0 But the point behind those is to keep them > > small and manageable in a sense, so core-updates is typically not > > concerned with leaves or leaf-like stuff. >=20 > I don't think I understand how our branch development stuff works.=C2=A0 = I > thought we put large dependency changes on core-updates so that the > CI could chew through everything and make sure it's good before > merging. Most stuff is now organized within teams that have "smaller" responsibilities. I'm responsible for getting Emacs and Gnome updates way later than we could=E2=80=A6 > Regardless, I trust the team to do the proper procedures.=C2=A0 I simply > believe we might do more package fiddling before Emacs 30 and that > potential problems might be assuaged if the comp-integrity file was > more forgiving and supported every Emacs equally.=C2=A0 Thus, I would > encourage it to be applied in the appropriate place now to avoid > potential headache but if we wish to wait for Emacs 30 that would > also be a valid choice. There are tradeoffs to be made here. In principle, we could support "every Emacs ever", in practice, it hardly makes sense. If you need an old Emacs in the future, you might as well use the built-in time machine. The right place is a new comp-integrity.el. We can just mv it over the old one once Emacs 30 is the default Emacs. We don't yet know how the help changes for 31, so we can't really ask a crystal ball to insert the right check. Cheers