From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id mPBSEPmHn2CjNwEAgWs5BA (envelope-from ) for ; Sat, 15 May 2021 10:36:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cOT+C/mHn2CsAQAA1q6Kng (envelope-from ) for ; Sat, 15 May 2021 08:36:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC6CD1F71E for ; Sat, 15 May 2021 10:36:08 +0200 (CEST) Received: from localhost ([::1]:33700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhpmK-0005SW-0z for larch@yhetil.org; Sat, 15 May 2021 04:36:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhpmE-0005NT-F5 for guix-patches@gnu.org; Sat, 15 May 2021 04:36:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35951) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhpmE-0001gp-6W for guix-patches@gnu.org; Sat, 15 May 2021 04:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lhpmE-0002uM-4V for guix-patches@gnu.org; Sat, 15 May 2021 04:36:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47824] [PATCH 0/3] Happy hacking in the Spring 2021 LGJ Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 15 May 2021 08:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47824 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 47824@debbugs.gnu.org, efraim@flashner.co.il Received: via spool by 47824-submit@debbugs.gnu.org id=B47824.162106776111175 (code B ref 47824); Sat, 15 May 2021 08:36:02 +0000 Received: (at 47824) by debbugs.gnu.org; 15 May 2021 08:36:01 +0000 Received: from localhost ([127.0.0.1]:47497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhpmD-0002u8-8w for submit@debbugs.gnu.org; Sat, 15 May 2021 04:36:01 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:22630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhpmA-0002ty-UJ for 47824@debbugs.gnu.org; Sat, 15 May 2021 04:35:59 -0400 Received: from [10.0.0.4] (91-114-247-246.adsl.highway.telekom.at [91.114.247.246]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FhzHt5qvwz1LWp5; Sat, 15 May 2021 10:35:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4FhzHt5qvwz1LWp5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1621067755; bh=cLbZXtNE8wr/x3/yYboQh/u4j3TMnZCxSCpfuRm0fYI=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=s9A5uHrw4/BxXmy/gC9JCycNLwlA4BF/AlNATP2gViIwS4dqhqBHq0egyLlvmqznl W39onjy2eHeM2I+NVc+//LbsJ1If2HSfdryfmH89QIsxFG0nu++8R0EHwHdZpPtXhF lCYkTDLgYzYI0oliU6iVplV495X1wqfwnwVj37wg= Message-ID: <62d2f1043b816c5c7619cb0eef15ff3a73bc4e2b.camel@student.tugraz.at> From: Leo Prikler Date: Sat, 15 May 2021 10:35:33 +0200 In-Reply-To: <82ad8a0c2757ff74694e8c83eb528cf84c59855e.camel@student.tugraz.at> References: <20210419081744.7247-1-leo.prikler@student.tugraz.at> <20210419081744.7247-3-leo.prikler@student.tugraz.at> <874kfhjmfd.fsf_-_@gnu.org> <867322166b5492fe1964df02db2b4d148ade29dd.camel@student.tugraz.at> <875yzwgmmg.fsf@gnu.org> <82ad8a0c2757ff74694e8c83eb528cf84c59855e.camel@student.tugraz.at> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621067769; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cLbZXtNE8wr/x3/yYboQh/u4j3TMnZCxSCpfuRm0fYI=; b=LjwicolJYYBCg5YeE6aXLC9rztuZ0obiTCv7gQaAOtMvJup+9koy3E7gfUy0VWYaIfAoGS sRe3Y1kz2mzm0zkkcE4I7pqgXrRSK020RRkQiBjxSwgxcGnt2SjtNRlTyiid66FASaRHjC oWRYs67wvqAW9SOI+2/pcoEScEcj+XJJ1ba4aO0dK+PjQCvx4I9Rb4kjH8LGq44qrE1iNL olzkWgnZrGLHOivFHB3MVODl2WdRBZsgijlWrHgwSdoIEKqo3bGRhfXhDBAosz3kpKPfVK Rv7s6lUmrCwyzo0e8hC6HDCwc54oUMgRQjhIRvZCND5d/+SWfRqahOxYahXYYA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621067769; a=rsa-sha256; cv=none; b=ms1MICAekRVQlZCXWoKQa85emqlX0mj3avRmYnVPxysu/8liOYK1tX4T3MTeSbXnaaCr9K 7iokY5gaDrt8vEpnKDrfXBaKTDFLiJPwzTJtNkxlF7IPsTafxAkwD9t/u7c+5RBjpyQ3// cdUJzu8GyaxqBe8f4IDdd7/jplH+CALytBTMr60H0fD+Uuy502nkvtb18/L/bwExRQSkoT QoHOfimey29YZHFpcIVKjoK7EZws61VrDl4bHs2+fMJnCsfrZo4led1wfhRYb6CE/GApGE ExYy/zWQj9dId8vsw60xof79YSgozpoT/Q/cC9RBwdEIM+m2vQNLXbo1VUrEFA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=s9A5uHrw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.35 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=s9A5uHrw; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: CC6CD1F71E X-Spam-Score: -1.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: MTKanL6OCKxz Ping. For the record, I've pushed guile-sdl and chickadee already, any hints w.r.t. the problem in Tsukundere? Am Donnerstag, den 06.05.2021, 13:03 +0200 schrieb Leo Prikler: > Am Donnerstag, den 06.05.2021, 12:52 +0200 schrieb Ludovic Courtès: > > Hi, > > > > Leo Prikler skribis: > > > > > Am Mittwoch, den 05.05.2021, 16:16 +0200 schrieb Ludovic Courtès: > > > > Hi Leo, > > > > > > > > On a cursory look, all three patches LGTM. > > > > > > > > One nit: > > > > > > > > > + "exec " > > > > > + (assoc-ref inputs "guile-runtime") > > > > > + "/bin/guile " args))) > > > > > > > > [...] > > > > > > > > > ("guile" ,guile-3.0) > > > > > ("pkg-config" ,pkg-config) > > > > > ("texinfo" ,texinfo))) > > > > > - (propagated-inputs > > > > > - `(("guile-sdl2" ,guile3.0-sdl2))) > > > > > + (inputs > > > > > + `(("guile-sdl2" ,guile3.0-sdl2) > > > > > + ("guile-runtime" ,guile-3.0))) > > > > > > > > I think it’s best to not play trick with labels, and to always > > > > use > > > > the > > > > package name as the label (to facilitate migration on the day > > > > where > > > > we > > > > get rid of labels, who knows…). > > > > > > > > A common pattern for the case above is to provide “guile” both > > > > as > > > > native > > > > input and input, and to write: > > > > > > > > (assoc-ref (or native-inputs inputs) "guile") > > > What I'm doing here is the exact opposite. I don't want the > > > omnipresent native-input guile to shadow the guile I use as > > > input, > > > > In that case, you can unconditionally do: > > > > (assoc-ref inputs "guile") > > > > Unless I’m mistaken, it won’t be shadowed by the native input > > “guile” > > when cross-compiling. > > > > Or am I missing something? > Perhaps it's an implementation detail, that when performing native > builds, inputs are merged as (append inputs native-inputs), but they > could as well be (append native-inputs inputs). I'd have to check, > and > I'm not sure whether I want to rely on that detail. > > Regards, > Leo