From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8M41Ggcrv2ECLgEAgWs5BA (envelope-from ) for ; Sun, 19 Dec 2021 13:52:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id OMjkFQcrv2EOLgAAbx9fmQ (envelope-from ) for ; Sun, 19 Dec 2021 12:52:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 23FDB212C8 for ; Sun, 19 Dec 2021 13:52:22 +0100 (CET) Received: from localhost ([::1]:32970 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myvfp-0001BP-9p for larch@yhetil.org; Sun, 19 Dec 2021 07:52:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myvfW-0000v3-FO for guix-patches@gnu.org; Sun, 19 Dec 2021 07:52:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:33598) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myvfW-0006Ux-71 for guix-patches@gnu.org; Sun, 19 Dec 2021 07:52:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myvfW-00053N-2d for guix-patches@gnu.org; Sun, 19 Dec 2021 07:52:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52472] [PATCH] gnu: Add libtree Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 19 Dec 2021 12:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52472 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 52472@debbugs.gnu.org, othacehe@gnu.org, poptsov.artyom@gmail.com X-Debbugs-Original-To: guix-patches@gnu.org, Mathieu Othacehe , poptsov.artyom@gmail.com X-Debbugs-Original-Cc: 52472@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163991827319365 (code B ref -1); Sun, 19 Dec 2021 12:52:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Dec 2021 12:51:13 +0000 Received: from localhost ([127.0.0.1]:45144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myvei-00052H-PW for submit@debbugs.gnu.org; Sun, 19 Dec 2021 07:51:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:32900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myveh-000529-EY for submit@debbugs.gnu.org; Sun, 19 Dec 2021 07:51:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myveg-0008Qi-AO for guix-patches@gnu.org; Sun, 19 Dec 2021 07:51:11 -0500 Received: from lepiller.eu ([89.234.186.109]:40146) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myvec-0006A6-7B; Sun, 19 Dec 2021 07:51:09 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 9176c641; Sun, 19 Dec 2021 12:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=yIzStsoNJdqz B0w2g1BZE2W37hLoHR4ixrKKIxydc50=; b=FtQ8qRVUn8o8clHLuKU/YPnLK2SK peAKnWmf/0h5CvMw8S4ZmpMS1bNQTGXnED6BJbOeflL2U2QNrZ4+Obq2jeNs3UV1 ftF/QiowTlHaDwC8+4RqBOfwEDN+1YjVKTcy7eHxDhii8Ob09mgokNNGETAutyf8 8ntBqmUbMxpyTt4PcksUJBjmipnYG/a8vO/3+rn2orT/ek0yg/l7m9XXXGAwkmp6 UEpZ1hNXrGxVA58r3K3YXek6nSZL9ExylDJXehMZ73iYB25ksFT+NOL0nojippYQ kIhYQfireSdbC1vDaQ7YL19b8AoYdIE+v0MQRNVbgZ+goTqzi1aU00HLFg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id f3354ba1 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sun, 19 Dec 2021 12:50:58 +0000 (UTC) Date: Sun, 19 Dec 2021 07:50:52 -0500 From: Julien Lepiller User-Agent: K-9 Mail for Android In-Reply-To: <87bl1dsz6b.fsf_-_@gnu.org> References: <87fsqw5j9h.fsf@gmail.com> <87pmpu5oi8.fsf@gmail.com> <87bl1dsz6b.fsf_-_@gnu.org> Message-ID: <61183D53-CE3D-4A00-AC7D-294C0C98FC00@lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=89.234.186.109; envelope-from=julien@lepiller.eu; helo=lepiller.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639918343; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=UNE2AMjbwLnBXUjdcnTDxrfm4pMnkXCyfxGZajfeW3M=; b=NsEVp4ZrNC5AOs8Gi6ewSSlvYgQyxYsHua6/z/hCJ+Mot0ziPE9QSsI/3STwvF6KD/4jCn ynZf5PbJqDDhN0YV/F1IrEX49oPIvEziRTVAY7gYNn+qutk/1XhkVBEsO99ls66No5nP+A HCn88tu0aVTbVGynQV4fiwejPa9yx0K9Zb10OUN85ezn6T732JRXrGz/ZWKRvKjBP3LreY 1dccpmqhIcqniN7v3JBY3y8DrL9QUYQTMSILYrGcF6YuKxUWODnr8FOIKh3utNtXvqkDz7 Vt7lRj+uGkxnCucAyyKS5sLBy6064X8JOjyPxO15MU+LGY/5LPoq+nGHIlESMg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639918343; a=rsa-sha256; cv=none; b=P/RwcfV9s1807KPIbtIMt+CPrupAqilc47/zHL0TYLxy/mUbHUusRqlSi6fzTCKSePd/Qw 32u9MndQ1l0C8G4oogA54dl2otiSRJzX81tpCP/6vzQX3ccfqUCwzPuoP2I73LYZ4GXnMX oc2zO6MEV/1HauEFjuHPk1ab9yzolm3zT7/18Nmc0/Rl6pBguoElp/O5fUDrQPzZo7bbQM PhrALm4dYcUxD/02BnbsntEBOWBOCx0qnPH8gwQwgyNl4WSCy+I7UmnwZxinH7iPWU+2jm c95qMNHGH63ANYTr9I2uNNx+Wmsy0OCSh6k1cFqaKQxbfkXMMXaxUi8HAF2tdA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=FtQ8qRVU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.62 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=FtQ8qRVU; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 23FDB212C8 X-Spam-Score: -2.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: 96CUgZKhXKWh Sorry if this is overwhelming, but also: Le 19 d=C3=A9cembre 2021 04:48:28 GMT-05:00, Mathieu Othacehe a =C3=A9crit=C2=A0: > >Hey Artyom, > >> ;;; Copyright =C2=A9 2021 Solene Rapenne >> +;;; Copyright =C2=A9 2021 Artyom V=2E Poptsov >> + > >No need for an extra new-line here=2E > >> + (lambda* (#:key outputs #:allow-other-keys) >> + (substitute* "Makefile" >> + (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)") >> + (format #f "~a/bin/" (assoc-ref outputs "out"))) >> + (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)") >> + (format #f "~a/share/" (assoc-ref outputs "out")))))) > >You can now write: > >--8<---------------cut here---------------start------------->8--- > ,#~(modify-phases %standard-phases > (delete 'check) > (delete 'configure) > (add-before 'build 'patch > (lambda* (#:key outputs #:allow-other-keys) > (substitute* "Makefile" > (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)") > (string-append #$output "/bin/")) > (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)") > (string-append #$output "/share/"))))) >--8<---------------cut here---------------end--------------->8--- > Don't remove the check phase=2E Use #:tests? #f instead and add a comment = explaining why=2E If the tests fail, we should fix them, not put them under= the rug ;) Maybe it would be easier to pass BINDIR, SHAREDIR and CC with #:make-flags= ? >> + (replace 'build >> + (lambda _ >> + (setenv "CC" "gcc") > >That would break cross-compilation=2E You should use something like: > >--8<---------------cut here---------------start------------->8--- >(string-append "CC=3D" ,(cc-for-target))=2E >--8<---------------cut here---------------end--------------->8--- > >> + (setenv "LDFLAGS" "-static") > >Why are we building a static version of the program? > >There's also this linter warning: > >gnu/packages/linux=2Escm:8649:14: libtree@3=2E0=2E1: synopsis should star= t with an upper-case letter or digit > >Thanks, > >Mathieu > Could you send a new patch with these changes? Don't hesitate to ask if yo= u're a bit lost or need help on some points :)