From: Julien Lepiller <julien@lepiller.eu>
To: 52472@debbugs.gnu.org, othacehe@gnu.org, poptsov.artyom@gmail.com
Subject: [bug#52472] [PATCH] gnu: Add libtree
Date: Sun, 19 Dec 2021 07:50:52 -0500 [thread overview]
Message-ID: <61183D53-CE3D-4A00-AC7D-294C0C98FC00@lepiller.eu> (raw)
In-Reply-To: <87bl1dsz6b.fsf_-_@gnu.org>
Sorry if this is overwhelming, but also:
Le 19 décembre 2021 04:48:28 GMT-05:00, Mathieu Othacehe <othacehe@gnu.org> a écrit :
>
>Hey Artyom,
>
>> ;;; Copyright © 2021 Solene Rapenne <solene@perso.pw>
>> +;;; Copyright © 2021 Artyom V. Poptsov <poptsov.artyom@gmail.com>
>> +
>
>No need for an extra new-line here.
>
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (substitute* "Makefile"
>> + (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)")
>> + (format #f "~a/bin/" (assoc-ref outputs "out")))
>> + (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)")
>> + (format #f "~a/share/" (assoc-ref outputs "out"))))))
>
>You can now write:
>
>--8<---------------cut here---------------start------------->8---
> ,#~(modify-phases %standard-phases
> (delete 'check)
> (delete 'configure)
> (add-before 'build 'patch
> (lambda* (#:key outputs #:allow-other-keys)
> (substitute* "Makefile"
> (("\\$\\(DESTDIR\\)\\$\\(BINDIR\\)")
> (string-append #$output "/bin/"))
> (("\\$\\(DESTDIR\\)\\$\\(SHAREDIR\\)")
> (string-append #$output "/share/")))))
>--8<---------------cut here---------------end--------------->8---
>
Don't remove the check phase. Use #:tests? #f instead and add a comment explaining why. If the tests fail, we should fix them, not put them under the rug ;)
Maybe it would be easier to pass BINDIR, SHAREDIR and CC with #:make-flags?
>> + (replace 'build
>> + (lambda _
>> + (setenv "CC" "gcc")
>
>That would break cross-compilation. You should use something like:
>
>--8<---------------cut here---------------start------------->8---
>(string-append "CC=" ,(cc-for-target)).
>--8<---------------cut here---------------end--------------->8---
>
>> + (setenv "LDFLAGS" "-static")
>
>Why are we building a static version of the program?
>
>There's also this linter warning:
>
>gnu/packages/linux.scm:8649:14: libtree@3.0.1: synopsis should start with an upper-case letter or digit
>
>Thanks,
>
>Mathieu
>
Could you send a new patch with these changes? Don't hesitate to ask if you're a bit lost or need help on some points :)
next prev parent reply other threads:[~2021-12-19 12:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 20:42 [bug#52472] [PATCH] gnu: Add libtree Artyom V. Poptsov
2021-12-18 8:02 ` Artyom V. Poptsov
2021-12-19 9:48 ` Mathieu Othacehe
2021-12-19 12:50 ` Julien Lepiller [this message]
2022-01-13 3:30 ` Artyom V. Poptsov
2022-01-13 7:38 ` Maxime Devos
2022-01-13 17:18 ` Artyom V. Poptsov
2022-01-13 17:37 ` Maxime Devos
2022-01-13 17:51 ` Artyom V. Poptsov
2022-01-17 18:09 ` Artyom V. Poptsov
2022-01-17 19:02 ` Maxime Devos
2022-01-17 19:14 ` Artyom V. Poptsov
2022-01-17 19:22 ` Maxime Devos
2022-01-28 18:30 ` Artyom V. Poptsov
2022-01-28 18:54 ` Maxime Devos
2022-02-04 18:25 ` Artyom V. Poptsov
2022-02-04 19:19 ` Maxime Devos
2022-02-05 5:50 ` Artyom V. Poptsov
2022-02-05 10:56 ` Maxime Devos
2022-02-05 11:34 ` Artyom V. Poptsov
2022-03-09 22:06 ` bug#52472: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61183D53-CE3D-4A00-AC7D-294C0C98FC00@lepiller.eu \
--to=julien@lepiller.eu \
--cc=52472@debbugs.gnu.org \
--cc=othacehe@gnu.org \
--cc=poptsov.artyom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.