From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id yIldN6NOkWTLTgEASxT56A (envelope-from ) for ; Tue, 20 Jun 2023 09:00:51 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sNA9N6NOkWRV4gAA9RJhRA (envelope-from ) for ; Tue, 20 Jun 2023 09:00:51 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 45D06EB46 for ; Tue, 20 Jun 2023 09:00:51 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBVLy-0007rx-Vd; Tue, 20 Jun 2023 03:00:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBVLQ-0007pD-6X for guix-patches@gnu.org; Tue, 20 Jun 2023 03:00:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qBVLP-0001YG-7j for guix-patches@gnu.org; Tue, 20 Jun 2023 03:00:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qBVLO-0003ea-I4 for guix-patches@gnu.org; Tue, 20 Jun 2023 03:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#60826] [PATCH gnome-team v3 2/5] build: gnu: Export a %gnu-default-modules variable. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Jun 2023 07:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60826 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 60826@debbugs.gnu.org Received: via spool by 60826-submit@debbugs.gnu.org id=B60826.168724437613983 (code B ref 60826); Tue, 20 Jun 2023 07:00:02 +0000 Received: (at 60826) by debbugs.gnu.org; 20 Jun 2023 06:59:36 +0000 Received: from localhost ([127.0.0.1]:57856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBVKy-0003dT-0l for submit@debbugs.gnu.org; Tue, 20 Jun 2023 02:59:36 -0400 Received: from smtpm2.myservices.hosting ([185.26.105.233]:59278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBVKw-0003dL-5V for 60826@debbugs.gnu.org; Tue, 20 Jun 2023 02:59:34 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm2.myservices.hosting (Postfix) with ESMTP id 5A78720E5A; Tue, 20 Jun 2023 08:59:31 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id C25C5800A0; Tue, 20 Jun 2023 08:59:27 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Cps_EdX0l-Kl; Tue, 20 Jun 2023 08:59:27 +0200 (CEST) Received: from [192.168.1.116] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 4B44F8009F; Tue, 20 Jun 2023 08:59:27 +0200 (CEST) Message-ID: <600640a9-751f-5193-aceb-469b11269d4d@makinata.eu> Date: Tue, 20 Jun 2023 07:59:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US References: <788ffede0cb9cdab9d7b7573de321dfd554caa0b.1687212109.git.mirai@makinata.eu> <1fdc6634bb6687a25a08f99e0c2b8fbda44c1563.camel@gmail.com> From: Bruno Victal In-Reply-To: <1fdc6634bb6687a25a08f99e0c2b8fbda44c1563.camel@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1687244451; a=rsa-sha256; cv=none; b=Hllws1rSBeBp658jzYzwbYaOcgwGFyWzRogHp6TzTlmQJrGUlCjWhWWqGE3rCI1j4L3eC0 vJHlHbf5MA6i+AhL5xNE7JJg2rcYQxaNNB3O0OXRSuTXOwAGw7a9SDXrmPnhepffrsldwO 19P6kr/NfLm02jnjyk4/+eVFdVM59abozUrRLd+yiCV5ZuYmM6BQc3OGD4flbqgyOnj1vm xSaXRbElA4499CXVnnGu9gE9U0p7VXazDhGgaOF2YNaJ1+uMrvgCmuWyW4qdVSSw1AWmi9 tjHcAfLgIqbA/jpmEMFJ84UUUNVd2VZ9k3LX4hKN+pWD/X1dGW8JdkL3G6EtUQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1687244451; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=jEEnhHiQrDIc43EGC01nrS4dLlWPg+8sf6MKgC5zmPs=; b=QPsfyqXfkXH6dfjH7MvEYfG+5q0H7FsNUjHYr85bL9jBdCdn5kkr20dggxaREkQ1UEXe7f 5ZZdeQaXJVfD6gNIoOwGfhcCw6JvH27jmVgEVuutj/Ez7Kh7Z4NEa1PbJ41aHRD1BwX0zx RPVtH6s8SFqNxU38sfCErgjcZfnLtr9lfqtNwGjlCKPg8WafuF0GaxCBrkQ83f/N4uF7hF pHkyhSpsqQE+RpImO6tnV+ouaVhDxURPAI+Xc9pHPuEYpzl5fyy5JMQ1qyDj+jffnwXOFc 7UdyWvIBUfWq/UMFO09RMaoNfLepMAaZobiK4ZhZWA37Xdmj4HjtxBQbrdY4jQ== Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.54 X-Spam-Score: -2.54 X-Migadu-Queue-Id: 45D06EB46 X-TUID: IJb4JY5WruHE Hi Liliana, On 2023-06-20 05:18, Liliana Marie Prikler wrote: > Am Montag, dem 19.06.2023 um 23:07 +0100 schrieb Bruno Victal: >> This makes tweaking the #:module argument less reliant on the >> programmers astral wisdom to divine the right module imports. >> >> * guix/build-system/gnu.scm (%default-modules): Rename to … >> (%gnu-default-modules): … this and export it as well. >> --- > Uhm, is this required? I see it used in xdgmime, but I'd very much > like to do without it. As indicated in the commit message, its purpose is to make things easier. (I've taken inspiration from elm-build-system here) I think the most compelling arguments to this approach is that in some packages you see things like: --8<---------------cut here---------------start------------->8--- gnu/packages/boost.scm- (list gnu/packages/boost.scm: #:imported-modules `((guix build python-build-system) gnu/packages/boost.scm- ,@%gnu-build-system-modules) gnu/packages/boost.scm: #:modules `(((guix build python-build-system) #:select (python-version)) gnu/packages/boost.scm- ,@%gnu-build-system-modules) gnu/packages/boost.scm- #:tests? #f gnu/packages/boost.scm- #:configure-flags --8<---------------cut here---------------end--------------->8--- Which is most likely a mistake since the actual #:module should be about %default-modules which is a subset of %gnu-build-system-modules. (albeit one with seemingly little impact) The divination comment stems from the following reasoning: “How can I know what gnu-build-system actually imports if not by guessing/cargo-culting or peering at the private %default-modules?“ (at that point, why not export it as well?) I'd argue it's a nice addition though strictly speaking its not fundamental for this patch-series and can be left out, by manually expanding the %gnu-default-modules value in the xdgmime arguments. -- Furthermore, I consider that nonfree software must be eradicated. Cheers, Bruno.