From: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
To: "Wamm K. D" <jaft.r@outlook.com>, 55774@debbugs.gnu.org
Subject: [bug#55774] [PATCH] gnu: quodlibet: Add dependencies for plugins to work.
Date: Fri, 03 Jun 2022 08:04:10 +0200 [thread overview]
Message-ID: <5d389f5061f937d238b758b23c61c3621a519b9c.camel@ist.tugraz.at> (raw)
In-Reply-To: <BN8PR07MB7027B7A3811C66F33FB041D899A19@BN8PR07MB7027.namprd07.prod.outlook.com>
Am Freitag, dem 03.06.2022 um 00:02 -0500 schrieb Wamm K. D:
> * gnu/packages/music.scm (quodlibet): Add dependencies for plugins to
> work.
Should be ... (quodlibet)[inputs]: Add ACTUAL_INPUTS...
> ---
> gnu/packages/music.scm | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 554d70f266..3751305b3c 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -47,6 +47,7 @@
> ;;; Copyright © 2022 Sughosha <sughosha@disroot.org>
> ;;; Copyright © 2022 Remco van 't Veer <remco@remworks.net>
> ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> +;;; Copyright © 2022 Wamm K. D. <jaft.r@outlook.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -179,6 +180,7 @@ (define-module (gnu packages music)
> #:use-module (gnu packages vim) ;for 'xxd'
> #:use-module (gnu packages web)
> #:use-module (gnu packages webkit)
> + #:use-module (gnu packages wm)
> #:use-module (gnu packages wxwidgets)
> #:use-module (gnu packages xdisorg)
> #:use-module (gnu packages xml)
> @@ -6752,7 +6754,16 @@ (define-public quodlibet
> python-pygobject
> python-pytest
> python-sgmllib3k
> - python-toml))
> + python-toml
> + ;; optional but needed for multimedia keys not under
> Gnome
> + keybinder-3.0
> + ;; optional but needed for Undo/Redo
> + ;; support for multiline text fields
> + gtksourceview
> + ;; optional but needed for the auto library update plugin
> + python-pyinotify
> + ;; optional but needed for the Musicbrainz plugin
> + python-musicbrainzngs))
YMMV, but it's better for inputs to be sorted alphabetically. Use line
comments to demarcate specific features, e.g.
keybinder-3.0 ; keybindings outside of GNOME
gtksourceview ; undo, redo, multiline text fields
...
Don't forget the 79 character limit; when in doubt claim less features.
If possible, try to line up the comments.
Also, comments like "musicbrainz plugin needs python-musicbrainz" are
not as informative as you'd think and can probably be dropped :)
Cheers
next prev parent reply other threads:[~2022-06-03 6:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 5:02 [bug#55774] [PATCH] gnu: quodlibet: Add dependencies for plugins to work Wamm K. D
2022-06-03 6:04 ` Liliana Marie Prikler [this message]
2022-06-03 13:13 ` Wamm K. D.
2022-06-03 13:22 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d389f5061f937d238b758b23c61c3621a519b9c.camel@ist.tugraz.at \
--to=liliana.prikler@ist.tugraz.at \
--cc=55774@debbugs.gnu.org \
--cc=jaft.r@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.