* [bug#51950] [PATCH 1/1] gnu: Add emacs-ddskk-with-nicola
2021-11-18 14:01 ` [bug#51950] [PATCH 1/1] gnu: Add emacs-ddskk-with-nicola Taiju HIGASHI
@ 2021-11-18 15:17 ` Taiju HIGASHI
2021-11-21 8:54 ` Liliana Marie Prikler
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Taiju HIGASHI @ 2021-11-18 15:17 UTC (permalink / raw)
To: 51950
I'm sorry.
I accidentally sent two e-mails to you.
The contents of the first email are quoted below.
----
Hi,
I'm a native speaker of Japanese.
There is emacs-ddskk in the gnu channel of Guix, but I usually use the kana
direct input method.
To use the kana direct input method with the ddskk emacs package, we need to
do the following steps after installing ddskk.
https://github.com/skk-dev/ddskk/tree/master/nicola#42-nicola-ddskk-%E3%81%AE%E3%82%A4%E3%83%B3%E3%82%B9%E3%83%88%E3%83%BC%E3%83%AB
(japanese)
With this patch, that will be no longer necessary.
I wanted to implement it with multiple outputs, but I couldn't figure out how
to implement it when there is a dependency between two outputs.
I'm new to Guix, so please let me know if there is a more appropriate
solution.
Thank you.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [bug#51950] [PATCH 1/1] gnu: Add emacs-ddskk-with-nicola
2021-11-18 14:01 ` [bug#51950] [PATCH 1/1] gnu: Add emacs-ddskk-with-nicola Taiju HIGASHI
2021-11-18 15:17 ` Taiju HIGASHI
@ 2021-11-21 8:54 ` Liliana Marie Prikler
2021-11-22 2:58 ` [bug#51950] [PATCH v2] " Taiju HIGASHI
2021-11-22 3:16 ` [bug#51950] [PATCH v3] " Taiju HIGASHI
3 siblings, 0 replies; 11+ messages in thread
From: Liliana Marie Prikler @ 2021-11-21 8:54 UTC (permalink / raw)
To: Taiju HIGASHI, 51950
Am Donnerstag, den 18.11.2021, 23:01 +0900 schrieb Taiju HIGASHI:
> ---
> gnu/packages/emacs-xyz.scm | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index e141c390d8..0ca2bbc066 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -28635,6 +28635,35 @@ (define-public emacs-ddskk
> conversion program}, a Japanese input method on Emacs.")
> (license license:gpl2+))))
>
> +(define-public emacs-ddskk-with-nicola
> + (package
> + (inherit emacs-ddskk)
> + (name "emacs-ddskk-with-nicola")
> + (synopsis "Simple Kana to Kanji conversion program (with
> NICOLA)")
> + (propagated-inputs
> + `(("emacs-ddskk" ,emacs-ddskk)))
> + (arguments
> + (substitute-keyword-arguments (package-arguments emacs-ddskk)
> + ((#:phases phases)
> + `(modify-phases ,phases
> + (add-after 'unpack 'chdir
> + (lambda _
> + (chdir "nicola")
> + #t))
> + (replace 'configure
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (assoc-ref outputs "out")))
> + (substitute* "Makefile"
> + (("PREFIX = NONE")
> + (string-append "PREFIX = " out))
> + (("LISPDIR = NONE")
> + (string-append "LISPDIR = " out
> "/share/emacs/site-lisp"))))
> + (make-file-writable "NICOLA-DDSKK-CFG")
> + (emacs-substitute-sexps "NICOLA-DDSKK-CFG"
> + ("setq NICOLA-DDSKK_PREFIX" ""))
> + #t))
You don't need to patch the Makefile to set those variables, use
#:make-flags instead.
> + (delete 'check)))))))
Again, use #:tests? and provide a comment as to why you're setting it
to #f.
Cheers
^ permalink raw reply [flat|nested] 11+ messages in thread
* [bug#51950] [PATCH v2] gnu: Add emacs-ddskk-with-nicola
2021-11-18 14:01 ` [bug#51950] [PATCH 1/1] gnu: Add emacs-ddskk-with-nicola Taiju HIGASHI
2021-11-18 15:17 ` Taiju HIGASHI
2021-11-21 8:54 ` Liliana Marie Prikler
@ 2021-11-22 2:58 ` Taiju HIGASHI
2021-11-22 3:05 ` Taiju HIGASHI
2021-11-22 20:37 ` bug#51950: " Liliana Marie Prikler
2021-11-22 3:16 ` [bug#51950] [PATCH v3] " Taiju HIGASHI
3 siblings, 2 replies; 11+ messages in thread
From: Taiju HIGASHI @ 2021-11-22 2:58 UTC (permalink / raw)
To: liliana.prikler, 51950; +Cc: Taiju HIGASHI
---
gnu/packages/emacs-xyz.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d3338d45bd..7f82bace7b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -28631,6 +28631,34 @@ (define-public emacs-ddskk
conversion program}, a Japanese input method on Emacs.")
(license license:gpl2+))))
+(define-public emacs-ddskk-with-nicola
+ (package
+ (inherit emacs-ddskk)
+ (name "emacs-ddskk-with-nicola")
+ (synopsis "Simple Kana to Kanji conversion program (with NICOLA)")
+ (propagated-inputs
+ `(("emacs-ddskk" ,emacs-ddskk)))
+ (arguments
+ `(#:make-flags
+ (let ((out (assoc-ref %outputs "out")))
+ (append
+ (list (string-append "PREFIX=" out)
+ (string-append "LISPDIR=" out "/share/emacs/site-lisp"))))
+ #:tests? #f ; no test
+ ,@(substitute-keyword-arguments (package-arguments emacs-ddskk)
+ ((#:phases phases)
+ `(modify-phases ,phases
+ (add-after 'unpack 'chdir
+ (lambda _
+ (chdir "nicola")
+ #t))
+ (replace 'configure
+ (lambda* (#:key outputs #:allow-other-keys)
+ (make-file-writable "NICOLA-DDSKK-CFG")
+ (emacs-substitute-sexps "NICOLA-DDSKK-CFG"
+ ("setq NICOLA-DDSKK_PREFIX" ""))
+ #t)))))))))
+
(define-public emacs-objed
(package
(name "emacs-objed")
--
2.33.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [bug#51950] [PATCH v3] gnu: Add emacs-ddskk-with-nicola
2021-11-18 14:01 ` [bug#51950] [PATCH 1/1] gnu: Add emacs-ddskk-with-nicola Taiju HIGASHI
` (2 preceding siblings ...)
2021-11-22 2:58 ` [bug#51950] [PATCH v2] " Taiju HIGASHI
@ 2021-11-22 3:16 ` Taiju HIGASHI
2021-11-22 3:18 ` Taiju HIGASHI
3 siblings, 1 reply; 11+ messages in thread
From: Taiju HIGASHI @ 2021-11-22 3:16 UTC (permalink / raw)
To: 51950; +Cc: Taiju HIGASHI
---
gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d3338d45bd..de0e94c7ee 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -28631,6 +28631,33 @@ (define-public emacs-ddskk
conversion program}, a Japanese input method on Emacs.")
(license license:gpl2+))))
+(define-public emacs-ddskk-with-nicola
+ (package
+ (inherit emacs-ddskk)
+ (name "emacs-ddskk-with-nicola")
+ (synopsis "Simple Kana to Kanji conversion program (with NICOLA)")
+ (propagated-inputs
+ `(("emacs-ddskk" ,emacs-ddskk)))
+ (arguments
+ `(#:make-flags
+ (let ((out (assoc-ref %outputs "out")))
+ (list (string-append "PREFIX=" out)
+ (string-append "LISPDIR=" out "/share/emacs/site-lisp")))
+ #:tests? #f ; no test
+ ,@(substitute-keyword-arguments (package-arguments emacs-ddskk)
+ ((#:phases phases)
+ `(modify-phases ,phases
+ (add-after 'unpack 'chdir
+ (lambda _
+ (chdir "nicola")
+ #t))
+ (replace 'configure
+ (lambda* (#:key outputs #:allow-other-keys)
+ (make-file-writable "NICOLA-DDSKK-CFG")
+ (emacs-substitute-sexps "NICOLA-DDSKK-CFG"
+ ("setq NICOLA-DDSKK_PREFIX" ""))
+ #t)))))))))
+
(define-public emacs-objed
(package
(name "emacs-objed")
--
2.33.1
^ permalink raw reply related [flat|nested] 11+ messages in thread