From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iPcOIUM3F18dGwAA0tVLHw (envelope-from ) for ; Tue, 21 Jul 2020 18:43:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KDThHEM3F1/oJQAAbx9fmQ (envelope-from ) for ; Tue, 21 Jul 2020 18:43:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9482494053C for ; Tue, 21 Jul 2020 18:43:14 +0000 (UTC) Received: from localhost ([::1]:35806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxxEO-00046h-A5 for larch@yhetil.org; Tue, 21 Jul 2020 14:43:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxxEE-00046S-5y for guix-patches@gnu.org; Tue, 21 Jul 2020 14:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57072) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jxxED-0000xx-T7 for guix-patches@gnu.org; Tue, 21 Jul 2020 14:43:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jxxED-00064W-QR for guix-patches@gnu.org; Tue, 21 Jul 2020 14:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42085] [PATCH 4/6] gnu: Add python-nodeenv. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Jul 2020 18:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42085 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , 42085@debbugs.gnu.org Received: via spool by 42085-submit@debbugs.gnu.org id=B42085.159535697123323 (code B ref 42085); Tue, 21 Jul 2020 18:43:01 +0000 Received: (at 42085) by debbugs.gnu.org; 21 Jul 2020 18:42:51 +0000 Received: from localhost ([127.0.0.1]:40385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxxE3-000646-2T for submit@debbugs.gnu.org; Tue, 21 Jul 2020 14:42:51 -0400 Received: from mout01.posteo.de ([185.67.36.65]:35599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jxxE1-00063r-Ma for 42085@debbugs.gnu.org; Tue, 21 Jul 2020 14:42:50 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 567FC160060 for <42085@debbugs.gnu.org>; Tue, 21 Jul 2020 20:42:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1595356963; bh=WEbCCVgQqQkIxk6aiKEry3xVfpA5mYzrt/9baRPmRWQ=; h=Subject:From:To:Date:From; b=p/6q7t+4/0WfvMJMkdrC3J3Yk9Gp2OCFWhjAwQgW9MDva0c8GZDg3nfSyncRkZKT8 r0TaoXZ5Rt0XTsFyajB4pdO+dMQZvwUXhuFA/ts8joDEz4BoVggaUZQiXyBOXK2hPb LsIDVBfFwB9N8IBhfrlgn8MJ5aCgwHLJTM7Vp2xdvXEQwr8OG9dbfKklY04U/PsAKk oz+9ZOR9MetlunwtAqKfgi+0+y3IMT/jMyattX8dFSZCWk073lw6M580uQxcjH0cHs L+0cYzU6MtJ3UQtHTqgeBUQhCJPyef4/8+yShwZQnwXoJg9PIMkgsWKiBGX3hdwXth aDwuUeBkG8G4A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BB6sY6Xlyz6tmS; Tue, 21 Jul 2020 20:42:41 +0200 (CEST) Message-ID: <5c8aad09797a818d525c121a24601020b271b514.camel@posteo.net> From: Vinicius Monego Date: Tue, 21 Jul 2020 15:42:37 -0300 In-Reply-To: <87tuy1hob5.fsf@gnu.org> References: <20200627154645.64264-1-monego@posteo.net> <20200627154645.64264-4-monego@posteo.net> <87tuy1hob5.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=posteo.net header.s=2017 header.b=p/6q7t+4; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: q13/qf/pZt+p Em seg, 2020-07-20 às 23:25 +0200, Marius Bakke escreveu: > We often omit the python- prefix for packages that are not used as a > library, i.e. Python packages that produce a "normal program". Is > that > the case here? It does provide an executable. It's a tool like virtualenv, but for Node packages instead of Python. > Perhaps it would make sense to place this in (gnu packages node) as > simply "nodeenv"? IIUC the {language} modules are for packages affiliated with the foundation behind the language, or other compiler or interpreter implementations. That's not the case here. > > + (native-inputs > > + `(("python-coverage" ,python-coverage) > > + ("python-flake8" ,python-flake8) > > + ("python-mock" ,python-mock) > > + ("python-pytest" ,python-pytest) > > + ("python-tox" ,python-tox))) > > 'python-tox' can probably be removed since we call out to pytest > directly. Some packages needlessly test for it though, in that case > you > can remove it from requirements-dev.txt with substitute*. Removed. I also removed flake8, since it's only used in the tox.ini file.