From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YJNvJJuhSmB3aAAA0tVLHw (envelope-from ) for ; Thu, 11 Mar 2021 23:02:51 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id eKpEIJuhSmDIUAAA1q6Kng (envelope-from ) for ; Thu, 11 Mar 2021 23:02:51 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 43B8712C0A for ; Fri, 12 Mar 2021 00:02:51 +0100 (CET) Received: from localhost ([::1]:34366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKUKP-000256-Pk for larch@yhetil.org; Thu, 11 Mar 2021 18:02:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKUJp-00023F-LX for guix-devel@gnu.org; Thu, 11 Mar 2021 18:02:13 -0500 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:36518) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lKUJm-0000Oa-Q2 for guix-devel@gnu.org; Thu, 11 Mar 2021 18:02:13 -0500 Received: by mail-ed1-x52a.google.com with SMTP id o19so5310326edc.3 for ; Thu, 11 Mar 2021 15:02:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DAEqgi2ykpuQTs/wDgoy+/zVst8M3po3ZqlQTFuCL9g=; b=TawIB4y/Dk1fO1RHIEkYrtwqdXH+OFNOCWZOaC3LB8YtmUMVeu48ql7Cqc28QPrYte +58K4xeXBEKfxeMxOMWBKq0YWuxFoV4wtRv+Uvp6VL9+JsVi8ohk5rWgTSlJwVN545yD AtyC7ha/gHcA8WJjXLDdv8WAm0Ycd6OaaqKGJGr7Amk8arSxnv3s6Xt930YIMAeX2PcP QXQwxFKdUmB9yNTGUewRDUAThPCyphMrVrHajS+5/VTeaNmj0URbm0NLaqCjcXG7/9nk N8wQLnXrOvkKN3Uce77k/M5CE8ezgyM9/5e0suX2AYYJppEWdNWW85erk1zHMqV/KeqC mMCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DAEqgi2ykpuQTs/wDgoy+/zVst8M3po3ZqlQTFuCL9g=; b=uGhYnYyT8k9395fBXggMNV42hFgFtIl+UPojWPTu+sLz7lZBkLctKmFJ42DCSL8EB7 Px86bRupMjhpDbmEWLGJDI22rIa9QxQ2bxw5pwsZpF+nqdbbqCgqa1WRV1jZJuk/DO9A eEZkA9NDf+4VAAd95VmbaeZiah2c6Fw9kKpzOw+z1pt3vsqYTxZMhKKSSylOeXONbcb8 r/fhcohc3weKvX9MqBGqi8jM6iOqdhIvKrvzWhkNpWFLY2BNuK9BU8DkUlxkuxqaDYej erYltCbZ9bS9YcrwHsO5utQ3DwbnwzlLpXy7Ka+vzo0lxwf7d/hx+HiO8b5kPTIJB4GG nGGA== X-Gm-Message-State: AOAM532VgM1ioehn2sEwpcfEI6/ILn5nJA5uD+tTTQUgGikeXq+6gsoD 0qkRKuLcbfalc95KqbpMb2auLCybOucZWFna X-Google-Smtp-Source: ABdhPJx2PCm1DT/JlaIrNIt84hU2j8PAj1NyOinNJ5uywVHTn+FH2Lf0shu3kkrg4W9rBcWW5+JYjA== X-Received: by 2002:a05:6402:1691:: with SMTP id a17mr10995408edv.336.1615503729082; Thu, 11 Mar 2021 15:02:09 -0800 (PST) Received: from [192.168.178.20] ([109.90.125.150]) by smtp.gmail.com with ESMTPSA id cx15sm2096166edb.54.2021.03.11.15.02.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Mar 2021 15:02:08 -0800 (PST) Subject: Re: Commit pushed to master with unauthorised signature To: Leo Famulari References: <87h7lid7qn.fsf@nckx> <8f198b1a-9e31-bc29-922f-2c1dd404390c@gmail.com> From: Taylan Kammer Message-ID: <5c1c9469-c6ff-89d5-5756-1f40db2be61f@gmail.com> Date: Fri, 12 Mar 2021 00:02:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=taylan.kammer@gmail.com; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guix-devel@gnu.org Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615503771; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=DAEqgi2ykpuQTs/wDgoy+/zVst8M3po3ZqlQTFuCL9g=; b=GrWj6Wu8yfjBfgmMocwFCHbdBRMyRx6pilQ03Ss+zdiRVtQRtZBktVvtJQWs2pjVt0Ebp4 qi/IFbGn9U+bv0Nfna94RlfKFpKu6yEMO11bq/+meQSPtRwlI4J67MkOxuDdHTby2HWcnQ LvsgPOtiAQmdvSDw4h36AWwFFkjiy3oM8uTSNEPzd8/pG58cN51+aPJVN8plakbjkvxS/E AMy0d/W0DSQjRvImcndZsasDveFUeJxeDdMKZEJgpY1QxtYGwhUsMN1CLi8xOiVmANmaFt gpkTPCZOIj8Fhx2WD2ZsK+h58T1Hhu3ArtbsuWj6uRe+S1Ofro8eg432U+mc0A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615503771; a=rsa-sha256; cv=none; b=TgYHtqX2gmu3eLAXT65tIl4+9sG43rINvLmEi6b4lDpwkAoepZtVZJyxSuf8d1glB/Va6n KyAjiolUhenU3ICbXDsmgQcOT3H2Sllrq3ZTV4muPNB2JcQ/zu4lbz2b0kGx+YKvXxg4pQ P4cJPyg6GA+QNKB8qdHEYv4QEK+RehSG+4sdzafor+HXQ7cjyxwAzsRVoC2Khp41fhWsPp rOr7aywv6u9kWJgdQCoKYWFSO+x0rpr2GI3BjxJ2b31YrVYXHB9QkjpOWy8Duz35qzG3cK 6XzMqmLzqY2Z5mrE0QYg4SVPuf4X3UAwL7LVxNY0jT0KngOArj38Q2XmJIQMnQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b="TawIB4y/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -1.29 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b="TawIB4y/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 43B8712C0A X-Spam-Score: -1.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: mpo8OUr4HDNt On 11.03.2021 20:16, Leo Famulari wrote: > On Thu, Mar 11, 2021 at 12:15:19AM +0100, Taylan Kammer wrote: >> Damn, sorry about that. I assumed of course that an improperly signed >> commit would not be accepted, so I didn't pay any special mind. > > The security model is based on the client-side, i.e. `guix pull`. That > way, we don't have to trust the Git repo. We do want to improve the repo > so that it's not possible to push commits signed with unauthorized keys, > but that hasn't been done yet. > >> However, I also assumed that adding a new GPG key to my savannah.gnu.org >> account would be sufficient. I did that via the web interface, and >> ensured that the encryption test is successful. The commit is signed >> with that new GPG key. > > Adding your key(s) to your Savannah account is a required step... > >> Are the GPG keys added to one's Savannah account unrelated to commit >> signing in the Guix repo, or are they not automatically synced, or is >> this a further bug?.. > > ... but, we have a new code authentication system, described in the > manual section Specifying Channel Authorizations: > > https://guix.gnu.org/manual/en/html_node/Specifying-Channel-Authorizations.html > > Basically, committers' keys must be added to the .guix-authorizations > file in the Git repo before their work will be accepted by `guix pull`. > > We are really happy that you are pushing code again :) > > When this issue popped up yesterday, I removed your commit access just > to avoid further broken commits. Concretely, this means that I removed > you from the Guix "group" on Savannah. > > However, I want to re-add you as a committer. Please read the manual > sections Commit Access. Especially, the part about the pre-push Git > hook, which would have caught this issue before pushing. > > https://guix.gnu.org/manual/en/html_node/Commit-Access.html > > Let me know when you've read the updated committer workflow guidelines > and installed the pre-push Git hook, and we'll add your new key to > .guix-authorizations, re-add you to the Savannah group, and then we can > continue with our happy hacking :) Thanks for the kind explanation! I'll get in touch when I'm not so out of the loop anymore. To be honest I was just "summoned" by a bug report on guile-bytestructures and am otherwise still overloaded with work life plus personal projects outside of free software. - Taylan