From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wPq9LOia7WJgDgAAbAwnHQ (envelope-from ) for ; Sat, 06 Aug 2022 00:34:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id eNzELOia7WIktAAA9RJhRA (envelope-from ) for ; Sat, 06 Aug 2022 00:34:16 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 544713A64F for ; Sat, 6 Aug 2022 00:34:16 +0200 (CEST) Received: from localhost ([::1]:58876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oK5tX-0000eq-9s for larch@yhetil.org; Fri, 05 Aug 2022 18:34:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oK5tK-0000eU-F5 for guix-patches@gnu.org; Fri, 05 Aug 2022 18:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42699) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oK5tK-0000ru-6X for guix-patches@gnu.org; Fri, 05 Aug 2022 18:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oK5tJ-0004Go-QZ for guix-patches@gnu.org; Fri, 05 Aug 2022 18:34:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56989] [PATCH v2] gnu: bqn: Add bqn.scm and dbqn package. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 Aug 2022 22:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56989 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Rodriguez Cc: 56989@debbugs.gnu.org Received: via spool by 56989-submit@debbugs.gnu.org id=B56989.165973883416402 (code B ref 56989); Fri, 05 Aug 2022 22:34:01 +0000 Received: (at 56989) by debbugs.gnu.org; 5 Aug 2022 22:33:54 +0000 Received: from localhost ([127.0.0.1]:60681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oK5t8-0004GQ-CU for submit@debbugs.gnu.org; Fri, 05 Aug 2022 18:33:54 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:35638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oK5t3-0004G9-4h for 56989@debbugs.gnu.org; Fri, 05 Aug 2022 18:33:49 -0400 Received: by mail-ed1-f68.google.com with SMTP id w3so5039919edc.2 for <56989@debbugs.gnu.org>; Fri, 05 Aug 2022 15:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=AC2Wu7sMvXqtGfpgg2kA04Nmu8PzXYB3JQu8M5WvHGM=; b=GS6LFvZkm6BnrUlDL2LBC7bBz5fbHcRW71elbeFJ75cjAZhxy4jkLNwadb0/jLT/wv wqaRSA2fI0kPRC+Gn1v7u1er32q61bJ8xULDgsTFCru8K5NUdXZP2CbvonMt9Fg3kz8W 9xjNeX7/06sKGQIU/8OzhL4cZ60VHel5/SCUSiTB+fABiaAX4oFm7O9VnjltpP3Mrt5t J2zptTHnlP1IHxdfs1IJ4oB8RQn3/kwWNlXXwBoVtKIX60VEWp8tAGoBgVDLgbUmTa54 sOSrKAPr70oNoZrRV7LAyG9WjzhqAKZ4LYUIeWJ2v01u4Lnq3uIA+lNbzfzcvHv64rfF urig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=AC2Wu7sMvXqtGfpgg2kA04Nmu8PzXYB3JQu8M5WvHGM=; b=ouRWW1PyAtu4POYCxEVtWXvStwmgPQBEoD/dupWx37bAnwnnwEyXMcmu3WbhmRSwsE +Iw7jb5g4BkCFMvHnQzW7wyuaUBrQ5jWXIh9L+xH4xZPbz1G/mEWLi6nUmf+JbGe2Rzu CuxRMJQ9O8JkF8/IVDQ4qHkIvvHEh12V1YyBkglTgb8YA6cnXi6BBdhR2O7JF2N0M9hW ELoMDhAW9YB2kbXOzt3aJ6V6gfD40pHI5gnG5HYSARu3BWsGWM2yP0wVTiXJe29hO+0y xA+BAS2+/JGJ5azxmUUWtpI1ZmwEdw8v4TxKT4AwNxruMxLiWrD2dC197HykNaaVH8u5 QLAg== X-Gm-Message-State: ACgBeo2GOpS0qAzPUoYznKA0LZPgO31aJ2SW8P8EuM+CA2JWSnVMEiA0 E715n8WuqMOnARxtQxGakZ8= X-Google-Smtp-Source: AA6agR7Sygo5oocN7UX8kxqpYR6rp9Smvl8LLlkwE10H6H/ot/bR5oicJ9BM917BD8JjYuUf8kNQtA== X-Received: by 2002:aa7:d513:0:b0:43d:5c81:4f71 with SMTP id y19-20020aa7d513000000b0043d5c814f71mr4392744edq.308.1659738819177; Fri, 05 Aug 2022 15:33:39 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id d23-20020a05640208d700b0043a7134b381sm550467edz.11.2022.08.05.15.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 15:33:38 -0700 (PDT) Message-ID: <5bffe66896dbebfe4716b924eb3d7a13e8e6344b.camel@gmail.com> From: Liliana Marie Prikler Date: Sat, 06 Aug 2022 00:33:37 +0200 In-Reply-To: <87zggin1u0.fsf@gmail.com> References: <20220805054616.30620-1-yewscion@gmail.com> <7742c07ce28494af40c74262277417e60fe6f500.camel@ist.tugraz.at> <87zggin1u0.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659738856; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=AC2Wu7sMvXqtGfpgg2kA04Nmu8PzXYB3JQu8M5WvHGM=; b=nXkH9ZJRgfwXZW2APkEUMw2d2NtpQkArKMbOmwsG6eXPDL20tVlh1dWhO7biIV3MgMEj64 1dgAG8y54WgOQD2BJORVDGZnPOKzfZNfP29M3RFT4u2q32q66s6+8BXZNWWc6jYO7hB7Wu vuTxDxkWCbhlY7MNUxYQ/s6cyZW5VjqZLjDT55k2rGwuzQZqsmMxZq2pLhd4u2J/kPYHk8 O6Qzj352j5GCqQzQ0DTTYYrfc0AkvXsdbrP+tDVc7DBY6gaN6L0a7Zu6UBaf5cOW/p3iVO cMEg6Ib1WgcwKCR/q3rkSLT2PXDGL1W4XRQIBXnhee3affzKg9DWxDPos82Qvg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659738856; a=rsa-sha256; cv=none; b=ozTEWz4ocvX5gMfYLOIKoEm1kXFJwXFQeIxQEQtEd15ydOCs4lbuR+KUChIQQWkQvDzyar XVi23fV2r5mIdTMnj+w1TB/GR4Ko14Kd7jFEH3pl2K9jN5p+aU/XseiuICsnkPRz7GpT66 +nC7tGWHcmbsYZGNyyVE1g62v8XpswhezvHfZqWxFSlS+v1PvXtruI9VGx65AaKaW8GBIX PFmxcZY57TNeBrjS8yB62c1esH2I0SxFFKfZlP7MqY0grQSwW/HHtSRxS1j7CIkHNJQ/e2 wqXCih0uQQ0hP+a/uGZnRmelK9wC761W+IN9x+/Y8lqMAzSl/dTpurvBJoS/zQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=GS6LFvZk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.60 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=GS6LFvZk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 544713A64F X-Spam-Score: 7.60 X-Migadu-Scanner: scn1.migadu.com X-TUID: XsKioeX5gREi Am Freitag, dem 05.08.2022 um 11:12 -0400 schrieb Christopher Rodriguez: > > > Don't let-bind tag, version and hash, use them inline. > ... > > Note that version will be bound here even if you use the version > > field to do so. > > This makes sense, and I've removed the let binding entirely. My only > uncertainty is where "revision" should go; I've currently attached it > to the upstream version tag (version "0.2.1-1"), where "0.2.1" is the > tag and "1" is the revision. Is this correct? You should let-bind revision and commit. You should nt let-bind tag, version and hash. Use git-version like (git-version "0.2.1" revision commit). > > > You could do > >   (replace 'check > >     (lambda* (#:key tests? #:allow-other-keys) > >       (when tests? > >         (for-each (lambda (known-good-test) > >                     (invoke my-glorious-bin known-good-test)) > >                   known-good-tests)))) > > FSVO my-glorious-bin and known-good-tests. > > I plan to do this once I've been able to look at each test and the > entire source and see if I can get it working. I've added an issue > upstream[1] where the author of the package has confirmed it is on > "just enough life support" to build the recommended implementation > from source. > > As it stands, I would have to test each test individually anyway, and > only add it to the package if it arbitrarily passes on my machine for > some reason. I don't think there is value there, as tests are meant > to ensure consistency and I cannot do that using such a workflow. Fair enough. > And though this *is* and *should be* a public package, it is *not* > the recommended interpreter for the language. It is primarily > included here to build the recommended one (CBQN) from source, along > with some other tools I've yet to package that require it during > build. That isn't really a good argument not to have tests though. While package maintainers should check that dependant packages still build, having early failure for a broken package (courtesy of the check phase) goes a long way. > > > You can use #:rest args to bind args for apply.  Also use assoc-ref > > rather than cdr + assoc. > > I had, for some reason, flipped the arguments on assoc-ref (which > obviously didn't work) and when that failed fell back to cdr + assoc. > I woke up this morning and noticed my mistake; It is fixed now. Ah, yes, the infamous flip :) > As for the #:rest args recommendation: I cannot figure out how to > explicitly bind (list options) to #:options in the apply call using > #:rest. This is probably ignorance on my part; I am still learning > the some of the mechanisms in scheme, and have not used #:rest (or > the dot notation for it) much at all. (cons* #:options your-options rest) ? > Is there an example You could point me to so I can educate myself? > > > Is OpenJDK 17 required? > > Really, only a JDK 7+ is required. openjdk17 carries the "openjdk" > label currently, and so I defaulted to that one. Is there another I > should use in my packages instead? If there is no *variable* named "openjdk", I'd suggest using the lowest one that works. If people are so inclined to use a newer jdk they can modify the package graph (which is easier than walking back to the earliest supported version), plus it's lower bootstrap for those of us building from source. Cheers