From: tumashu <tumashu@163.com>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: "26557@debbugs.gnu.org" <26557@debbugs.gnu.org>
Subject: bug#26557: [PATCH] gnu: let exwm command work with arguments
Date: Wed, 19 Apr 2017 18:03:28 +0800 (CST) [thread overview]
Message-ID: <5be25944.bb1e.15b85aab553.Coremail.tumashu@163.com> (raw)
In-Reply-To: <dd9f9bd5.AEMAJWvi2cQAAAAAAAAAAAO1_3wAAAACwQwAAAAAAAW9WABY9xyO@mailjet.com>
[-- Attachment #1.1: Type: text/plain, Size: 702 bytes --]
updated patch:
At 2017-04-19 16:15:05, "Arun Isaac" <arunisaac@systemreboot.net> wrote:
>
>> The most useful case is adding "--debug-init" to debug the emacs
>> problem, "-q" may useful too.
>
>Ok.
>
>> - exec ~a --exit-with-session ~a --eval '~s' ~%"
>> + exec ~a --exit-with-session ~a $* --eval '~s' ~%"
>
>To account for arguments with spaces in them, could you make this "$@"
>instead of $* ?
>
>https://stackoverflow.com/questions/12314451/accessing-bash-command-line-args-vs
>
>Also, the first line of the commit message should be
>
>gnu: emacs-exwm: Let exwm ...
>
>Note the addition of "emacs-exwm" and title case of "Let".
>
>Thanks!
>
>
>
[-- Attachment #1.2: Type: text/html, Size: 998 bytes --]
[-- Attachment #2: 0001-gnu-emacs-exwm-Let-exwm-shell-wrap-work-with-argumen.patch --]
[-- Type: application/octet-stream, Size: 1147 bytes --]
From b9937f40378bcf616f5c866232e42db6630c9ae3 Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu@163.com>
Date: Wed, 19 Apr 2017 06:14:44 +0800
Subject: [PATCH] gnu: emacs-exwm: Let exwm shell-wrap work with arguments
* gnu/packages/emacs.scm (emacs-exwm): Add "$@" to exwm shell-wrap
---
gnu/packages/emacs.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 6eb8751ad..68bac8b41 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4475,7 +4475,7 @@ It should enable you to implement low-level X11 applications.")
(format #t "#!~a ~@
export DISPLAY=:0 ~@
~a +SI:localuser:$USER ~@
- exec ~a --exit-with-session ~a --eval '~s' ~%"
+ exec ~a --exit-with-session ~a \"$@\" --eval '~s' ~%"
(string-append (assoc-ref inputs "bash") "/bin/sh")
(string-append (assoc-ref inputs "xhost") "/bin/xhost")
(string-append (assoc-ref inputs "dbus") "/bin/dbus-launch")
--
2.12.2
next prev parent reply other threads:[~2017-04-19 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 22:33 bug#26557: [PATCH] gnu: let exwm command work with arguments Feng Shu
2017-04-19 6:01 ` Arun Isaac
2017-04-19 7:40 ` tumashu
2017-04-19 8:15 ` Arun Isaac
2017-04-19 10:03 ` tumashu [this message]
2017-04-19 16:52 ` Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5be25944.bb1e.15b85aab553.Coremail.tumashu@163.com \
--to=tumashu@163.com \
--cc=26557@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.