[PATCH 2/2] gnu: Add gnome-clocks.

[PATCH 2/2] gnu: Add gnome-clocks.

[rennes]

[-- Attachment #1: Type: text/plain, Size: 84 bytes --]

Hello,
this patch is gnome-clocks application.

Built, linted and tested.

Thank you

[-- Attachment #2: 0001-gnu-Add-gnome-clocks.patch --]
[-- Type: text/x-patch, Size: 2981 bytes --]

From fd784203294523120f09312ffe9699a4983e6156 Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Sat, 1 Oct 2016 07:22:39 -0500
Subject: [PATCH 2/2] gnu: Add gnome-clocks.

	* gnu/packages/gnome-clocks.scm (gnome-clocks): New variable.

---
 gnu/packages/gnome-clocks.scm | 62 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)
 create mode 100644 gnu/packages/gnome-clocks.scm

diff --git a/gnu/packages/gnome-clocks.scm b/gnu/packages/gnome-clocks.scm
new file mode 100644
index 0000000..5da4f76
--- /dev/null
+++ b/gnu/packages/gnome-clocks.scm
@@ -0,0 +1,62 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Rene Saavedra <rennes@openmailbox.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages gnome-clocks)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix download)
+  #:use-module (guix packages)
+  #:use-module (guix utils)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gsound)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages pkg-config))
+
+(define-public gnome-clocks
+  (package
+    (name "gnome-clocks")
+    (version "3.20.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://gnome/sources/" name "/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "05rnf4r9mn8zfwypalm6rkm34dri02cqaavp933wwclnxc3i5c3x"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("glib" ,glib "bin") ; for glib-compile-schemas.
+       ("intltool" ,intltool)
+       ("itstool" ,itstool)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("geoclue" ,geoclue)
+       ("geocode-glib" ,geocode-glib)
+       ("gnome-desktop" ,gnome-desktop)
+       ("gsound" ,gsound)
+       ("gtk+" ,gtk+)
+       ("libgweather" ,libgweather)))
+    (home-page "https://wiki.gnome.org/Apps/Clocks")
+    (synopsis "Clocks applications for GNOME")
+    (description
+     "Simple clock application for GNOME.  It includes world clocks,
+alarms, a stopwatch and a timer.")
+    (license license:gpl2)))
-- 
2.10.0

Re: [PATCH 2/2] gnu: Add gnome-clocks.

[Hartmut Goebel]

[-- Attachment #1.1: Type: text/plain, Size: 644 bytes --]

Hi,

Am 01.10.2016 um 14:38 schrieb rennes:
> this patch is gnome-clocks application.

Thanks for these patches. Please put both of them into
gnu/packages/gnome.scm, since they are gnome-related. We do not add a
file for each package.

-- 
Schönen Gruß
Hartmut Goebel
Dipl.-Informatiker (univ), CISSP, CSSLP, ISO 27001 Lead Implementer
Information Security Management, Security Governance, Secure Software
Development

Goebel Consult, Landshut
http://www.goebel-consult.de

Blog: http://www.goebel-consult.de/blog/verschlusselte-mailingslisten
Kolumne: http://www.cissp-gefluester.de/2012-02-bring-your-own-life-glosse


[-- Attachment #1.2: Type: text/html, Size: 1796 bytes --]

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 2430 bytes --]

Re: [PATCH 2/2] gnu: Add gnome-clocks.

[Ludovic Courtès]

rennes <rennes@openmailbox.org> skribis:

> From fd784203294523120f09312ffe9699a4983e6156 Mon Sep 17 00:00:00 2001
> From: Rene Saavedra <rennes@openmailbox.org>
> Date: Sat, 1 Oct 2016 07:22:39 -0500
> Subject: [PATCH 2/2] gnu: Add gnome-clocks.
>
> 	* gnu/packages/gnome-clocks.scm (gnome-clocks): New variable.

Could you please move it to gnome.scm, as Harmut suggests?

> +    (home-page "https://wiki.gnome.org/Apps/Clocks")
> +    (synopsis "Clocks applications for GNOME")

Singular.

> +    (description
> +     "Simple clock application for GNOME.  It includes world clocks,
         ^
Make a full sentence.

> +    (license license:gpl2)))

Most likely ‘gpl2+’ (please check).

Could you send an updated patch?

Thanks!

Ludo’.

Re: [PATCH 2/2] gnu: Add gnome-clocks.

[rennes]

Hello,

> Could you send an updated patch?

Hello,
I found a problem with one of the functions of the application related 
to gnome-shell and geoclue. I will continue conducting tests.

Thank you.