From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d070f-0004Yn-FX for guix-patches@gnu.org; Mon, 17 Apr 2017 09:48:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d070c-0003SM-D8 for guix-patches@gnu.org; Mon, 17 Apr 2017 09:48:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53511) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d070c-0003Rm-3v for guix-patches@gnu.org; Mon, 17 Apr 2017 09:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d070b-0005PS-O3 for guix-patches@gnu.org; Mon, 17 Apr 2017 09:48:01 -0400 Subject: bug#26454: [PATCH 2/2] gnu: add emacs-exwm References: <20170411225803.2420-2-tumashu@163.com> Resent-Message-ID: Message-Id: <596f39ca.AEUAJFdKV9QAAAAAAAAAAAO0QTIAAAACwQwAAAAAAAW9WABY9Mdm@mailjet.com> MIME-Version: 1.0 From: Arun Isaac Date: Mon, 17 Apr 2017 19:17:13 +0530 In-reply-to: <31bbef43.33c0.15b79b10ef2.Coremail.tumashu@163.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 26454@debbugs.gnu.org I have finished all corrections. And, as far as I can tell, exwm builds and works fine. If there are no other suggestions, let me know, and I'll push. In the patch I just sent, I check if the 'exwm feature is loaded. If it is not loaded, then a default configuration is loaded. Else, nothing happens and we proceed assuming the user has configured exwm in their ~/.emacs. This way, we get a working exwm out of the box and at the same time, retain the user's ability to customize their exwm easily. Though upstream prefers we use the pregenerated source code, I'm afraid we cannot do that. All Guix packages are strictly built from source. For now, there is no problem with our own regenerated source code. And, I don't anticipate there will be many problems in the future. If and when there is a problem and the package breaks, we will report the problem upstream as a bug, and take any necessary action to fix our package. Until then, this should be fine. I've made many other minor edits and a little code restructuring. Please go through the patch. I had to move the synopsis field up to the top of the package definition so that I could reference it later while creating the .desktop file. Also, I've switched back to the ELPA tarball. There seem to be some exwm upstream bugs with floating windows. Apart from that, it works great. I have switched to exwm from my previous window manager, dwm. :-) =