From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7d5S-0001Z9-VC for guix-patches@gnu.org; Mon, 08 May 2017 03:28:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7d5O-0002zu-0t for guix-patches@gnu.org; Mon, 08 May 2017 03:28:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34648) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d7d5N-0002za-SQ for guix-patches@gnu.org; Mon, 08 May 2017 03:28:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d7d5N-0002bp-Kd for guix-patches@gnu.org; Mon, 08 May 2017 03:28:01 -0400 Subject: bug#26817: [PATCH] gnu: Add pngcrunch. Resent-Message-ID: References: <1494177899-20012-1-git-send-email-h.goebel@crazy-compilers.com> <20170507233646.GB20778@jasmine> From: Hartmut Goebel Message-ID: <59101DE8.10004@crazy-compilers.com> Date: Mon, 8 May 2017 09:27:36 +0200 MIME-Version: 1.0 In-Reply-To: <20170507233646.GB20778@jasmine> Content-Type: multipart/alternative; boundary="------------070404030604010709090405" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 26817@debbugs.gnu.org This is a multi-part message in MIME format. --------------070404030604010709090405 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Am 08.05.2017 um 01:36 schrieb Leo Famulari: >> > + (("\\$\\(DESTDIR\\)/usr/") >> > + (string-append (assoc-ref outputs "out") "/")))))))) > That's strange; DESTDIR is typically an intermediate location between > the source directory and PREFIX. I assume this Makefile is written by > hand? Yes, it is written by hand and not using e.g PREFIX :-( Should I add a comment? -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | --------------070404030604010709090405 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
Am 08.05.2017 um 01:36 schrieb Leo Famulari:
> +              (("\\$\\(DESTDIR\\)/usr/")
> +               (string-append (assoc-ref outputs "out") "/"))))))))

That's strange; DESTDIR is typically an intermediate location between
the source directory and PREFIX. I assume this Makefile is written by
hand?

Yes, it is written by hand and not using e.g PREFIX :-(

Should I add a comment?

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |
--------------070404030604010709090405--