From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: bavier@member.fsf.org
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gc: Add option --keep-going.
Date: Thu, 24 Nov 2016 10:28:32 +0100 [thread overview]
Message-ID: <5836B2C0.9060706@crazy-compilers.com> (raw)
In-Reply-To: <20161117224903.46deb2e6@centurylink.net>
Hi Eric,
thanks for the review and finding all these typos :-)
Am 18.11.2016 um 05:49 schrieb Eric Bavier:
>> > + printMsg(lvlError, format("cannot delete path `%1%' since it is still alive") % *i);
> ^
> Is error formatting appropriate, or is there a warning level we can use?
>
I agree that these are warnings and no errors. There is not "lvlWarn",
thoug, just "lvlInfo". So I took this value from a few lines below which
say:
if (state.shouldDelete)
printMsg(lvlError, format("deleting garbage..."));
else
printMsg(lvlError, format("determining live/dead paths..."));
So, what do you think?
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
next prev parent reply other threads:[~2016-11-24 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 14:37 [PATCH] gc: Add option --keep-going Hartmut Goebel
2016-11-18 4:49 ` Eric Bavier
2016-11-24 9:28 ` Hartmut Goebel [this message]
2016-11-27 21:07 ` Ludovic Courtès
2016-11-18 23:15 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5836B2C0.9060706@crazy-compilers.com \
--to=h.goebel@crazy-compilers.com \
--cc=bavier@member.fsf.org \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.