From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Goebel Subject: Re: [PATCH 5/5] guix: python-build-system: Fix an outdated comment. Date: Thu, 13 Oct 2016 09:32:31 +0200 Message-ID: <57FF388F.9000002@crazy-compilers.com> References: <1476105003-29538-1-git-send-email-h.goebel@crazy-compilers.com> <1476105003-29538-6-git-send-email-h.goebel@crazy-compilers.com> <20161012160343.GE31109@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buaVM-0001L9-Ha for guix-devel@gnu.org; Thu, 13 Oct 2016 03:32:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buaVH-0000UB-AQ for guix-devel@gnu.org; Thu, 13 Oct 2016 03:32:40 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:43055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buaVH-0000Sa-45 for guix-devel@gnu.org; Thu, 13 Oct 2016 03:32:35 -0400 In-Reply-To: <20161012160343.GE31109@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Am 12.10.2016 um 18:03 schrieb Leo Famulari: >> > (define %standard-phases >> > - ;; 'configure' and 'build' phases are not needed. Everything is done during >> > - ;; 'install'. >> > + ;; 'configure' phase is not needed. > I have no real comment because I don't know the python-build-system well > enough. Is the sentence about 'install' no longer accurate? The python-build-system uses the build and the install phase, but not the configure phase. So the old comment was plain wrong. I assume once only the install phase was used[*] and the comment has had been correct :-) Which is possible and much like running "make install" without prior run to "make". -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |