From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Goebel Subject: Re: [PATCH 1/4] gnu: Add python-avro. Date: Mon, 26 Sep 2016 11:31:48 +0200 Message-ID: <57E8EB04.2040905@crazy-compilers.com> References: <20160925211728.7636-1-mbakke@fastmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boSGl-0004lI-Lp for guix-devel@gnu.org; Mon, 26 Sep 2016 05:32:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boSGi-0003m6-G0 for guix-devel@gnu.org; Mon, 26 Sep 2016 05:32:15 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:60957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boSGi-0003lq-9S for guix-devel@gnu.org; Mon, 26 Sep 2016 05:32:12 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3sjJdb13tfz3hlJb for ; Mon, 26 Sep 2016 11:32:03 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3sjJdL57MJzvkW5 for ; Mon, 26 Sep 2016 11:31:50 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id 1YsdQScyXl7o for ; Mon, 26 Sep 2016 11:31:49 +0200 (CEST) Received: from hermia.goebel-consult.de (ppp-188-174-136-87.dynamic.mnet-online.de [188.174.136.87]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for ; Mon, 26 Sep 2016 11:31:49 +0200 (CEST) Received: from [192.168.110.2] (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id EF0406045E for ; Mon, 26 Sep 2016 11:31:48 +0200 (CEST) In-Reply-To: <20160925211728.7636-1-mbakke@fastmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Am 25.09.2016 um 23:17 schrieb Marius Bakke: > +;;; Avro uses a single source repository for all implementations. The individual > +;;; released versions often have missing or incomplete test data, so we define > +;;; the common source here for use in all avro packages. > +(define (avro-version) "1.8.1") > +(define (avro-source version) With "Avro uses a single source repository for all implementations " you mean for both Python 2 and Python 3? Well, this is the common case :-) Any other packages do have this and we never use a separate definition for source or version. Please have a look at e.g. python-graphql-relay (picked as example at random). > + `(#:tests? #f ; Requires Apache Ivy. Please add, why this is a problem. If Ivy is not yet pacakges, I suggest adding something like "TODO: enable if Apache Ivy is packaged". -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |