From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hartmut Goebel <h.goebel@crazy-compilers.com>
Subject: Re: [PATCH 2/3] guix: ant-build-system: add empty `tests` target to
	default build.xml.
Date: Mon, 5 Sep 2016 13:32:44 +0200
Message-ID: <57CD57DC.90005@crazy-compilers.com>
References: <1473067474-7485-1-git-send-email-h.goebel@crazy-compilers.com>
	<1473067474-7485-3-git-send-email-h.goebel@crazy-compilers.com>
	<CAEwRq=rhy1dSv0QbWp3E-qSQrKGd4HikkFxPg5piM+WGA00mPg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57689)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <h.goebel@crazy-compilers.com>) id 1bgs90-000305-6U
	for guix-devel@gnu.org; Mon, 05 Sep 2016 07:32:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <h.goebel@crazy-compilers.com>) id 1bgs8u-0005xZ-5Y
	for guix-devel@gnu.org; Mon, 05 Sep 2016 07:32:53 -0400
Received: from mail-out.m-online.net ([212.18.0.9]:45803)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <h.goebel@crazy-compilers.com>) id 1bgs8t-0005xS-Up
	for guix-devel@gnu.org; Mon, 05 Sep 2016 07:32:48 -0400
In-Reply-To: <CAEwRq=rhy1dSv0QbWp3E-qSQrKGd4HikkFxPg5piM+WGA00mPg@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>

Hi,

Am 05.09.2016 um 12:59 schrieb Vincent Legoll:
> On Mon, Sep 5, 2016 at 11:24 AM, Hartmut Goebel
> <h.goebel@crazy-compilers.com> wrote:
>> This avoids the need to set #:tests? #f whenever using #:jar-name
>> (and thus using the default build.xml).
> Isn't it a bit misleading to have a test target that does no real
> testing, or am I
> misunderstanding this patch ?

When specifying #:jar-file, the ant-builder will create a build.xml.
This build.xml did not include a test-target at all. So one *always* had
to include "#:tests? #f" to disable calling the (non-existing)
test-target - otherwise build would fail. But adding "#:tests? #f" is
just redundant.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |