From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Woodcroft <b.woodcroft@uq.edu.au>
Subject: Re: [PATCH] gnu: Add r-glmnet.
Date: Fri, 1 Jul 2016 09:08:21 +1000
Message-ID: <5775A665.7080709@uq.edu.au>
References: <20160630014444.28656-1-donttrustben@gmail.com>
	<idjziq2vodu.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44443)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bIl4T-00015Y-Tr
	for guix-devel@gnu.org; Thu, 30 Jun 2016 19:08:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bIl4P-0006WA-SY
	for guix-devel@gnu.org; Thu, 30 Jun 2016 19:08:33 -0400
Received: from mailhub2.soe.uq.edu.au ([130.102.132.209]:56630
	helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bIl4P-0006V6-8g
	for guix-devel@gnu.org; Thu, 30 Jun 2016 19:08:29 -0400
In-Reply-To: <idjziq2vodu.fsf@bimsb-sys02.mdc-berlin.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>, Ben Woodcroft <donttrustben@gmail.com>
Cc: guix-devel@gnu.org



On 30/06/16 22:42, Ricardo Wurmus wrote:
> Ben Woodcroft <donttrustben@gmail.com> writes:
>
>> * gnu/packages/statistics.scm (r-glmnet): New variable.
>> ---
>>   gnu/packages/statistics.scm | 26 ++++++++++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>>
>> diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
>> index f037392..732d874 100644
>> --- a/gnu/packages/statistics.scm
>> +++ b/gnu/packages/statistics.scm
>> @@ -2244,6 +2244,32 @@ singular and eigenvalue decompositions, as well as for principal component
>>   analysis of large sparse or dense matrices.")
>>       (license (list license:gpl2+ license:gpl3+))))
>>   
>> +(define-public r-glmnet
>> +  (package
>> +   (name "r-glmnet")
>> +   (version "2.0-5")
>> +   (source
>> +    (origin
>> +     (method url-fetch)
>> +     (uri (cran-uri "glmnet" version))
>> +     (sha256
>> +      (base32
>> +       "1cbpzmbv837fvq88rgn6mgzgr9f1wqp9fg8gh2kkmngvr1957a9c"))))
>> +   (build-system r-build-system)
>> +    (inputs
>> +     `(("gfortran" ,gfortran)))
>> +   (propagated-inputs
>> +    `(("r-foreach" ,r-foreach)))
>> +   (home-page "http://www.jstatsoft.org/v33/i01")
>> +   (synopsis "Lasso and Elastic-Net Regularized Generalized Linear Models")
> Does this need to be all caps?

No they do not. I made all except the first lower case and pushed. 
Thanks for the review.
ben