From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Woodcroft <b.woodcroft@uq.edu.au>
Subject: Re: [PATCH] gnu: Add multiqc.
Date: Wed, 29 Jun 2016 09:05:02 +1000
Message-ID: <5773029E.1000400@uq.edu.au>
References: <20160628145042.25341-1-ricardo.wurmus@mdc-berlin.de>
	<idj7fd9wee7.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41254)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bI24G-0004kZ-2e
	for guix-devel@gnu.org; Tue, 28 Jun 2016 19:05:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bI24B-0001mS-12
	for guix-devel@gnu.org; Tue, 28 Jun 2016 19:05:18 -0400
Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:37889
	helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bI24A-0001kM-EH
	for guix-devel@gnu.org; Tue, 28 Jun 2016 19:05:14 -0400
In-Reply-To: <idj7fd9wee7.fsf@bimsb-sys02.mdc-berlin.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>, guix-devel@gnu.org



On 29/06/16 00:56, Ricardo Wurmus wrote:
> Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:
>
>> * gnu/packages/bioinformatics.scm (multiqc): New variable.
>> ---
>>   gnu/packages/bioinformatics.scm | 30 ++++++++++++++++++++++++++++++
>>   1 file changed, 30 insertions(+)
>>
>> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
>> index 04ed769..45595d0 100644
>> --- a/gnu/packages/bioinformatics.scm
>> +++ b/gnu/packages/bioinformatics.scm
>> @@ -5321,3 +5321,33 @@ group or two ChIP groups run under different conditions.")
>>         (description "This program compares version strings.  It intends to be a
>>   replacement for strverscmp.")
>>         (license license:gpl3+))))
>> +
>> +(define-public multiqc
>> +  (package
>> +    (name "multiqc")
>> +    (version "0.6")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://pypi.python.org/packages/23/d9/95a5e62eea95f220007d7a6683d0da1ee1d9f99e6932bcff793b6601ef15/multiqc-"
>> +             version ".tar.gz"))

I think 'pypi-uri' would be better here, now that it handles these kinds 
of URLs. We should change 'import' so that these long URLs are not printed.

Thanks for the patch.
ben