From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cHnAAMBRUWI+ewEAgWs5BA (envelope-from ) for ; Sat, 09 Apr 2022 11:28:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id AEGoOb9RUWIhEwEA9RJhRA (envelope-from ) for ; Sat, 09 Apr 2022 11:28:31 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B05578E02 for ; Sat, 9 Apr 2022 11:28:31 +0200 (CEST) Received: from localhost ([::1]:45898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nd7OQ-0003ME-VA for larch@yhetil.org; Sat, 09 Apr 2022 05:28:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55370) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nd7Nz-0003Lr-Sa for guix-patches@gnu.org; Sat, 09 Apr 2022 05:28:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42841) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nd7Nx-0005uI-Sf for guix-patches@gnu.org; Sat, 09 Apr 2022 05:28:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nd7Nx-0002Tb-Kn for guix-patches@gnu.org; Sat, 09 Apr 2022 05:28:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54668] [PATCH 0/3] Turn diagnostic locations into hyperlinks Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 09 Apr 2022 09:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54668 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 54668-done@debbugs.gnu.org Received: via spool by 54668-done@debbugs.gnu.org id=D54668.16494964629488 (code D ref 54668); Sat, 09 Apr 2022 09:28:01 +0000 Received: (at 54668-done) by debbugs.gnu.org; 9 Apr 2022 09:27:42 +0000 Received: from localhost ([127.0.0.1]:36738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nd7Ne-0002Sy-41 for submit@debbugs.gnu.org; Sat, 09 Apr 2022 05:27:42 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:46258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nd7Nc-0002Sq-C4 for 54668-done@debbugs.gnu.org; Sat, 09 Apr 2022 05:27:40 -0400 Received: from [192.168.109.254] ([188.189.133.86]) by laurent.telenet-ops.be with bizsmtp id GZTe2700B1s0Pjw01ZTesn; Sat, 09 Apr 2022 11:27:39 +0200 Message-ID: <574b1752ae3f2b03c019d3028153bb7587ad5468.camel@telenet.be> From: Maxime Devos Date: Sat, 09 Apr 2022 11:27:38 +0200 In-Reply-To: <87tub38c9k.fsf_-_@gnu.org> References: <20220401145955.32347-1-ludo@gnu.org> <20220401150146.32529-1-ludo@gnu.org> <875ynpuk0t.fsf_-_@gnu.org> <87tub38c9k.fsf_-_@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-5G/f2fEXfH3uhGzi8h27" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1649496459; bh=y3vY029t2HVZf2madLrgF7N7JSUzcuQilRTgh2Y9rPM=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=IEo3PuVzknO1eZvapvXzeUWz6wqrY0hpTPYDjE3L0x1pNKGHS6ZuNNikDAocM+JeL Vsi5SFMGJCI7sjPJzrXkNAv/gT3Er4Hve0t6i2iAjlEXm28Dc5/0G2O8TKIhGxkhEa wdS71qA9UBboj5h+eQB1L+xGsBPRy8F/wtdJEiVe3bpLFs0d/whZTOGZqsBBpucB95 tbH6TIW3Ch8E3Fa8eZog2iH93ks2udfBtaoJY4WTNvJ1UPqa/PGgeVBbpMtLOS9Zct LsiedYcNHLhCtMtH3gyomqiG4T61yUu04EmKlpf7QFB+eVm63zeu0PqiveeGS1GgsA yv2GSPUd0MuXA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649496511; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=y3vY029t2HVZf2madLrgF7N7JSUzcuQilRTgh2Y9rPM=; b=hqJGVxQtn6W7iL0TZyzewi1In1o5SRKVjyvBaiNP86kd3HspJaw7ZNRieqwBNMwxYqbL/y aNGdrdrmJLBsc+1lY/xr8FxAsmotImBXaR2xLV9mi/4VRXohVfF3vGa9azX83etjWSfV0p 113rlfEepleZ+PoCPcC+EkNWN75eo7QJoPoDgKIgdeE0XsAannhOAXI7i+R0RE+fzQnZSr 3Q3Eqng/pL55BWXeKIz0W/ancnP0P/5XBrC6uzsXdLXzrw4f4W5XgP2UYSn3HTr2CpSEXU +BJCod91rPHdhdHTQ4Ru4PVUa4S7VHqizEG/ERF8oqPOTxQvhltRRyy+nByVSg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649496511; a=rsa-sha256; cv=none; b=OOGbHNdiSm6OEPjxQJt9jvZkzFEjuUn47i+S7840MWR5RqKMcwlaH7ZbeQfZYK9Hk9WcZk 7rQpMYsfBQ5MYWRDoMSPSFqzIXfN3w/0WLRlVrN1D46lsRm1s1eRTWq/qHnhDyoc87wZxl fBWjdi4lK6GYfDpEfjmi/SQrCkTHnLAidu3D0JuB9sj22vfLJb7/Udq0KGFNROYYFFD3Pb 0ADr1SbQncJcCQ9gTqmSGaY8Tko9xaYx5EzhVEZ3zkLpHubQmWS53odqb3XDu/9YT7sQGN fV2Oefu1nag3ogCcr/8qpfxzblOXhG3mAm1JTWDq87HmqTnThcTg/iHKaoAAXw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=IEo3PuVz; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=IEo3PuVz; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B05578E02 X-Spam-Score: 3.83 X-Migadu-Scanner: scn1.migadu.com X-TUID: CPGrl2V2fcKV --=-5G/f2fEXfH3uhGzi8h27 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s schreef op za 09-04-2022 om 00:02 [+0200]: > > So I guess we should pass =E2=80=98uri=E2=80=99 through =E2=80=98uri-en= code=E2=80=99.=C2=A0 I=E2=80=99ll do that > > in a > > separate patch. >=20 > Actually this is already done by =E2=80=98file-hyperlink=E2=80=99 a few l= ines > below, so we=E2=80=99re fine. FWIW, (guix ui) doesn't seem to do this for license links: ((? license? license) (let ((text (license-name license)) (uri (license-uri license))) (if (and hyperlinks? uri (string-prefix? "http" uri)) (hyperlink uri text) text))) Likewise for (guix scripts describe), though it might not be a problem there yet given the limited set of URIs. I think it's a bit less fragile to move the uri-encoding from 'file- hyperlink' to 'hyperlink', WDYT? Greetings, Maxime. --=-5G/f2fEXfH3uhGzi8h27 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYlFRihccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7icgAP4vGtGtqtQo03bwpKSDvLTweZiI M0a0zOYyoCE+yd0kbgD9FSEpspVSkUsCkm1qm0vXbYix5frT0IjFai24m4xPtgM= =GxYP -----END PGP SIGNATURE----- --=-5G/f2fEXfH3uhGzi8h27--