From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Woodcroft <b.woodcroft@uq.edu.au>
Subject: Re: [Patch] ruby-debug-inspector
Date: Wed, 1 Jun 2016 17:35:14 +1000
Message-ID: <574E9032.9040801@uq.edu.au>
References: <87vb1uxmxu.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me>
	<20160531175917.GE13578@debian-netbook>
	<87k2iax8hj.fsf@mailerver.i-did-not-set--mail-host-address--so-tickle-me>
	<20160601070207.GA30401@debian-netbook>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47297)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1b80gd-0005Xj-Ic
	for guix-devel@gnu.org; Wed, 01 Jun 2016 03:35:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1b80gZ-0004no-Du
	for guix-devel@gnu.org; Wed, 01 Jun 2016 03:35:30 -0400
Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:52960
	helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1b80gY-0004iK-RG
	for guix-devel@gnu.org; Wed, 01 Jun 2016 03:35:27 -0400
In-Reply-To: <20160601070207.GA30401@debian-netbook>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>, Matthew Jordan <matthewjordandevops@yandex.com>
Cc: guix-devel <guix-devel@gnu.org>

Hi Matthew,

Thanks for the patch, all patches toward rails are much appreciated. I 
do have a few comments though.
>> * gnu/packages/rails.scm: New file.
I'm of the opinion that we should keep most ruby packages in 
gnu/packages/ruby.scm because to me "is this ruby package a rails 
package?" is not one with a straightforward answer. We already have 
activesupport in ruby.scm for instance, and that is more of a rails 
package than this I would argue.
>> +  #:use-module (guix build-system ruby))
>> +
>> +(define-public ruby-debug-inspector
>> +  (package
>> +    (name "ruby-debug-inspector")
>> +    (version "0.0.2")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (rubygems-uri "debug_inspector" version))
>> +       (sha256
>> +        (base32
>> +         "109761g00dbrw5q0dfnbqg8blfm699z4jj70l4zrgf9mzn7ii50m"))))
>> +    (build-system ruby-build-system)
>> +    (arguments
>> +     `(#:tests? #f)) ;; tests fail, when attepting to run the bacon command.
Looking a bit closer at this it appears the test directory is missing 
from the gem but even the repository too. Maybe instead we add a cheap 
and cheerful test like this:

     (arguments
      `(#:phases
        (modify-phases %standard-phases
          (replace 'check
            (lambda _
              (zero? (system* "ruby" "-Ilib" "-r" "debug_inspector")))))))

WDYT?
>> +    (inputs
>> +     `(("ruby-bacon" ,ruby-bacon)))
bacon is not a dependency other than for testing, is that right? If so I 
don't think it is necessary.
>> +    (synopsis "Ruby wrapper for the MRI 2.0 debug_inspector API")
>> +    (description
>> +     "This package provides a Ruby wrapper for the MRI 2.0 debug_inspector
>> +API.")
>> +    (home-page
>> +     "https://github.com/banister/debug_inspector")
>> +    (license expat)))
Can you send an updated patch please? I'll look at your other patches 
soon too.

Thanks,
ben