Re: [Patch] ruby-debug-inspector

[Ben Woodcroft <b.woodcroft@uq.edu.au>]

Hi Matthew,

Thanks for the patch, all patches toward rails are much appreciated. I 
do have a few comments though.
>> * gnu/packages/rails.scm: New file.
I'm of the opinion that we should keep most ruby packages in 
gnu/packages/ruby.scm because to me "is this ruby package a rails 
package?" is not one with a straightforward answer. We already have 
activesupport in ruby.scm for instance, and that is more of a rails 
package than this I would argue.
>> +  #:use-module (guix build-system ruby))
>> +
>> +(define-public ruby-debug-inspector
>> +  (package
>> +    (name "ruby-debug-inspector")
>> +    (version "0.0.2")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (rubygems-uri "debug_inspector" version))
>> +       (sha256
>> +        (base32
>> +         "109761g00dbrw5q0dfnbqg8blfm699z4jj70l4zrgf9mzn7ii50m"))))
>> +    (build-system ruby-build-system)
>> +    (arguments
>> +     `(#:tests? #f)) ;; tests fail, when attepting to run the bacon command.
Looking a bit closer at this it appears the test directory is missing 
from the gem but even the repository too. Maybe instead we add a cheap 
and cheerful test like this:

     (arguments
      `(#:phases
        (modify-phases %standard-phases
          (replace 'check
            (lambda _
              (zero? (system* "ruby" "-Ilib" "-r" "debug_inspector")))))))

WDYT?
>> +    (inputs
>> +     `(("ruby-bacon" ,ruby-bacon)))
bacon is not a dependency other than for testing, is that right? If so I 
don't think it is necessary.
>> +    (synopsis "Ruby wrapper for the MRI 2.0 debug_inspector API")
>> +    (description
>> +     "This package provides a Ruby wrapper for the MRI 2.0 debug_inspector
>> +API.")
>> +    (home-page
>> +     "https://github.com/banister/debug_inspector")
>> +    (license expat)))
Can you send an updated patch please? I'll look at your other patches 
soon too.

Thanks,
ben