From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Roelandt Subject: Re: [PATCH 02/10] gnu: Update python-unittest2 to 0.6.0 Date: Fri, 6 May 2016 03:28:39 +0200 Message-ID: <572BF347.9080301@gmail.com> References: <1461939663-5936-1-git-send-email-tipecaml@gmail.com> <1461939663-5936-3-git-send-email-tipecaml@gmail.com> <20160430213306.GB32505@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayUZr-0005ii-HQ for guix-devel@gnu.org; Thu, 05 May 2016 21:29:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayUZf-0008D6-N4 for guix-devel@gnu.org; Thu, 05 May 2016 21:29:06 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:33932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayUZe-00086q-DJ for guix-devel@gnu.org; Thu, 05 May 2016 21:28:59 -0400 Received: by mail-wm0-x243.google.com with SMTP id n129so6513439wmn.1 for ; Thu, 05 May 2016 18:28:44 -0700 (PDT) In-Reply-To: <20160430213306.GB32505@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org On 04/30/2016 11:33 PM, Leo Famulari wrote: > As with python-cmd2, could you if setuptools is required for the > python-3 variant? > So, I applied the following patch: --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -1520,8 +1520,7 @@ matching them against a list of media-ranges.") (build-system python-build-system) (propagated-inputs `(("python-six" ,python-six))) - (inputs - `(("python-setuptools" ,python-setuptools))) + ;(inputs `(("python-setuptools" ,python-setuptools))) (home-page "http://pypi.python.org/pypi/unittest2") (synopsis "Python unit testing library") (description @@ -1530,7 +1529,12 @@ standard library.") (license psfl))) (define-public python2-unittest2 - (package-with-python2 python-unittest2)) + ;(package-with-python2 python-unittest2)) + (let ((base (package-with-python2 (strip-python2-variant python-unittest2)))) + (package + (inherit base) + (native-inputs `(("python2-setuptools" ,python2-setuptools) + ,@(package-native-inputs base)))))) (define-public python-py (package I can still build python-unittest2 and python-barbicanclient: $ ./pre-inst-env guix build python-unittest2 /gnu/store/kh4nbzvqv9ic535xls92q8j6p6iz30kk-python-unittest2-0.6.0 $ ./pre-inst-env guix build python-barbicanclient /gnu/store/n3kas9l1ffcf84gdbx1sswzrm4cl93n6-python-barbicanclient-4.0.1 I can still build python2-unittest2: $ ./pre-inst-env guix build python2-unittest2 /gnu/store/ld9l5y5hxs19d15babphp7mv1kxsak55-python2-unittest2-0.6.0 But I can no longer build python2-barbicanclient: http://paste.debian.net/682000/ >> > - #:tests? #f)))) ; no setup.py test command > Disabling two tests is an improvment over this! Did you find anyone else > on the net having trouble with these two tests? Not really, I was quite happy with enabling most of them for Python2 and did not look any further, since my main goal was packaging python-barbicanclient. Cyril.