From: Ben Woodcroft <donttrustben@gmail.com>
To: Leo Famulari <leo@famulari.name>, Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>,
Mathieu Lirzin <mthl@openmailbox.org>
Subject: Re: [PATCH] tar bombs and muscle
Date: Sat, 30 Apr 2016 15:48:50 +1000 [thread overview]
Message-ID: <57244742.5080201@gmail.com> (raw)
In-Reply-To: <20160430021353.GC13826@jasmine>
On 30/04/16 12:13, Leo Famulari wrote:
> On Sun, Apr 24, 2016 at 10:04:01AM +1000, Ben Woodcroft wrote:
>> * gnu/packages/bioinformatics.scm (muscle): New variable.
>> + (file-name (string-append name "-" version ".tar.gz"))
> Once fetched, the source code is a directory rather than a tarball, so
> I think it's best to omit the last component of the string.
>
>> + (replace 'install
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (let* ((out (assoc-ref outputs "out"))
>> + (bin (string-append out "/bin")))
>> + (install-file "muscle" bin)))))))
> It only creates the one executable?
>
>> + (license license:public-domain)))
> Wow, they really don't make it easy to find this information. Can you
> add a comment saying that it's in 'usage.cpp'? Unless I missed something
> obvious...
>
> Otherwise, looks good to me!
Pushed with those changes. Thanks.
next prev parent reply other threads:[~2016-04-30 5:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-17 1:30 [PATCH] tar bombs and muscle Ben Woodcroft
2016-01-17 1:51 ` Ben Woodcroft
2016-01-17 9:30 ` Mathieu Lirzin
2016-01-17 12:45 ` Pjotr Prins
2016-01-17 4:29 ` Eric Bavier
2016-01-17 6:27 ` Ben Woodcroft
2016-04-24 0:04 ` Ben Woodcroft
2016-04-30 2:13 ` Leo Famulari
2016-04-30 5:48 ` Ben Woodcroft [this message]
2016-01-17 8:35 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57244742.5080201@gmail.com \
--to=donttrustben@gmail.com \
--cc=b.woodcroft@uq.edu.au \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
--cc=mthl@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.