From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Woodcroft <donttrustben@gmail.com>
Subject: Re: [PATCH v2 03/10] gnu: Add python-pytest-pep8.
Date: Mon, 25 Apr 2016 09:45:37 +1000
Message-ID: <571D5AA1.9090605@gmail.com>
References: <1461244921-7412-1-git-send-email-donttrustben@gmail.com>
	<1461503184-8841-1-git-send-email-donttrustben@gmail.com>
	<1461503184-8841-4-git-send-email-donttrustben@gmail.com>
	<20160424170405.GA12480@debian-netbook>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37926)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <donttrustben@gmail.com>) id 1auTj1-0007iT-K0
	for Guix-devel@gnu.org; Sun, 24 Apr 2016 19:46:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <donttrustben@gmail.com>) id 1auTiy-000335-BP
	for Guix-devel@gnu.org; Sun, 24 Apr 2016 19:46:03 -0400
Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:36848)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <donttrustben@gmail.com>) id 1auTiy-000331-4R
	for Guix-devel@gnu.org; Sun, 24 Apr 2016 19:46:00 -0400
Received: by mail-pf0-x242.google.com with SMTP id p185so15697140pfb.3
	for <Guix-devel@gnu.org>; Sun, 24 Apr 2016 16:45:59 -0700 (PDT)
In-Reply-To: <20160424170405.GA12480@debian-netbook>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>, Ben Woodcroft <donttrustben@gmail.com>
Cc: Guix-devel@gnu.org



On 25/04/16 03:04, Efraim Flashner wrote:
> On Sun, Apr 24, 2016 at 11:06:17PM +1000, Ben Woodcroft wrote:
[..]
>> +           ;; 'setup.py test' does not run tests
>> +           (lambda* (#:key inputs outputs #:allow-other-keys)
>> +             (let ((out (assoc-ref outputs "out")))
>> +               (setenv "PYTHONPATH"
>> +                       (string-append
>> +                        (getenv "PYTHONPATH")
>> +                        ":"
>> +                        out
>> +                        "/lib/python"
> some of the previous lines should be combined into one line

I think this is a matter of style, but I've amended it to below, which I 
assume is OK - I have no strong opinions.

+               (setenv
+                "PYTHONPATH"
+                (string-append (getenv "PYTHONPATH")":" out "/lib/python"
+                               (string-take (string-take-right
+                                      (assoc-ref inputs "python") 5) 3)
+                               "/site-packages"))

[..]

>> +    (propagated-inputs
>> +     `(("python-pytest-cache", python-pytest-cache)
>> +       ("python-pytest" ,python-pytest)
>> +       ("python-pep8" ,python-pep8)))
> Are you sure all of these need to be propagated?

That's what the install_requires in setup.py is telling me.

[..]

Thanks,
ben