From: Ben Woodcroft <donttrustben@gmail.com>
To: Efraim Flashner <efraim@flashner.co.il>,
Ben Woodcroft <donttrustben@gmail.com>
Cc: Guix-devel@gnu.org
Subject: Re: [PATCH v2 03/10] gnu: Add python-pytest-pep8.
Date: Mon, 25 Apr 2016 09:45:37 +1000 [thread overview]
Message-ID: <571D5AA1.9090605@gmail.com> (raw)
In-Reply-To: <20160424170405.GA12480@debian-netbook>
On 25/04/16 03:04, Efraim Flashner wrote:
> On Sun, Apr 24, 2016 at 11:06:17PM +1000, Ben Woodcroft wrote:
[..]
>> + ;; 'setup.py test' does not run tests
>> + (lambda* (#:key inputs outputs #:allow-other-keys)
>> + (let ((out (assoc-ref outputs "out")))
>> + (setenv "PYTHONPATH"
>> + (string-append
>> + (getenv "PYTHONPATH")
>> + ":"
>> + out
>> + "/lib/python"
> some of the previous lines should be combined into one line
I think this is a matter of style, but I've amended it to below, which I
assume is OK - I have no strong opinions.
+ (setenv
+ "PYTHONPATH"
+ (string-append (getenv "PYTHONPATH")":" out "/lib/python"
+ (string-take (string-take-right
+ (assoc-ref inputs "python") 5) 3)
+ "/site-packages"))
[..]
>> + (propagated-inputs
>> + `(("python-pytest-cache", python-pytest-cache)
>> + ("python-pytest" ,python-pytest)
>> + ("python-pep8" ,python-pep8)))
> Are you sure all of these need to be propagated?
That's what the install_requires in setup.py is telling me.
[..]
Thanks,
ben
next prev parent reply other threads:[~2016-04-24 23:46 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 13:21 [PATCH] Add python-scikit-bio Ben Woodcroft
2016-04-21 13:21 ` [PATCH 01/10] gnu: Add python2-pytest-cache Ben Woodcroft
2016-04-21 13:21 ` [PATCH 02/10] gnu: Add python-bz2file Ben Woodcroft
2016-04-21 15:43 ` Efraim Flashner
2016-04-21 18:24 ` Hartmut Goebel
2016-04-24 13:17 ` Ben Woodcroft
2016-04-21 13:21 ` [PATCH 03/10] gnu: Add python-pytest-pep8 Ben Woodcroft
2016-04-21 18:26 ` Hartmut Goebel
2016-04-24 13:21 ` Ben Woodcroft
2016-04-21 13:21 ` [PATCH 04/10] gnu: Add python-pytest-flakes Ben Woodcroft
2016-04-21 18:26 ` Hartmut Goebel
2016-04-21 13:21 ` [PATCH 05/10] gnu: Add python-future Ben Woodcroft
2016-04-21 13:21 ` [PATCH 06/10] gnu: Add python-cachecontrol Ben Woodcroft
2016-04-21 13:21 ` [PATCH 07/10] gnu: python-tornado: Use 'python2-variant' Ben Woodcroft
2016-04-21 13:21 ` [PATCH 08/10] gnu: python-ipython: " Ben Woodcroft
2016-04-21 15:14 ` Ricardo Wurmus
2016-04-24 13:11 ` Ben Woodcroft
2016-04-24 13:12 ` Ben Woodcroft
2016-04-21 13:22 ` [PATCH 09/10] gnu: Add python-natsort Ben Woodcroft
2016-04-21 15:09 ` Ricardo Wurmus
2016-04-21 13:22 ` [PATCH 10/10] gnu: Add python-scikit-bio Ben Woodcroft
2016-04-21 15:04 ` Ricardo Wurmus
2016-04-21 15:07 ` Ricardo Wurmus
2016-04-21 15:09 ` Ricardo Wurmus
2016-04-24 13:01 ` [PATCH 2/2] " Ben Woodcroft
2016-04-24 13:06 ` [PATCH v2] " Ben Woodcroft
2016-04-24 13:06 ` [PATCH v2 01/10] gnu: Add python2-pytest-cache Ben Woodcroft
2016-04-25 18:22 ` Leo Famulari
2016-04-24 13:06 ` [PATCH v2 02/10] gnu: Add python-bz2file Ben Woodcroft
2016-04-25 18:27 ` Leo Famulari
2016-04-24 13:06 ` [PATCH v2 03/10] gnu: Add python-pytest-pep8 Ben Woodcroft
2016-04-24 17:04 ` Efraim Flashner
2016-04-24 23:42 ` Ben Woodcroft
2016-04-24 23:45 ` Ben Woodcroft [this message]
2016-04-25 8:43 ` Ricardo Wurmus
2016-04-25 12:36 ` Ben Woodcroft
2016-04-25 18:19 ` Leo Famulari
2016-04-25 20:07 ` proper Python inputs (was: gnu: Add python-pytest-pep8.) Hartmut Goebel
2016-04-26 14:19 ` Ricardo Wurmus
2016-04-24 13:06 ` [PATCH v2 04/10] gnu: Add python-pytest-flakes Ben Woodcroft
2016-04-25 18:34 ` Leo Famulari
2016-04-24 13:06 ` [PATCH v2 05/10] gnu: Add python-future Ben Woodcroft
2016-04-25 18:30 ` Leo Famulari
2016-04-24 13:06 ` [PATCH v2 06/10] gnu: Add python-cachecontrol Ben Woodcroft
2016-04-25 18:35 ` Leo Famulari
2016-04-24 13:06 ` [PATCH v2 07/10] gnu: python-tornado: Use 'python2-variant' Ben Woodcroft
2016-04-25 18:36 ` Leo Famulari
2016-04-24 13:06 ` [PATCH v2 08/10] gnu: python-ipython: " Ben Woodcroft
2016-04-25 18:48 ` Leo Famulari
2016-04-24 13:06 ` [PATCH v2 09/10] gnu: Add python-natsort Ben Woodcroft
2016-04-25 18:41 ` Leo Famulari
2016-04-24 13:06 ` [PATCH v2 10/10] gnu: Add python-scikit-bio Ben Woodcroft
2016-04-25 18:47 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571D5AA1.9090605@gmail.com \
--to=donttrustben@gmail.com \
--cc=Guix-devel@gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.