From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Woodcroft Subject: Re: [PATCH v2 03/10] gnu: Add python-pytest-pep8. Date: Mon, 25 Apr 2016 09:42:05 +1000 Message-ID: <571D59CD.7050205@gmail.com> References: <1461244921-7412-1-git-send-email-donttrustben@gmail.com> <1461503184-8841-1-git-send-email-donttrustben@gmail.com> <1461503184-8841-4-git-send-email-donttrustben@gmail.com> <20160424170405.GA12480@debian-netbook> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auTfM-0001o0-1J for Guix-devel@gnu.org; Sun, 24 Apr 2016 19:42:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auTfI-0002Tc-Qp for Guix-devel@gnu.org; Sun, 24 Apr 2016 19:42:15 -0400 Received: from mail-pf0-x232.google.com ([2607:f8b0:400e:c00::232]:33143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auTfI-0002TY-JW for Guix-devel@gnu.org; Sun, 24 Apr 2016 19:42:12 -0400 Received: by mail-pf0-x232.google.com with SMTP id 206so10453744pfu.0 for ; Sun, 24 Apr 2016 16:42:12 -0700 (PDT) In-Reply-To: <20160424170405.GA12480@debian-netbook> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Efraim Flashner , Ben Woodcroft Cc: Guix-devel@gnu.org On 25/04/16 03:04, Efraim Flashner wrote: > On Sun, Apr 24, 2016 at 11:06:17PM +1000, Ben Woodcroft wrote: [..] >> + (let ((out (assoc-ref outputs "out"))) >> + (setenv "PYTHONPATH" >> + (string-append >> + (getenv "PYTHONPATH") >> + ":" >> + out >> + "/lib/python" > some of the previous lines should be combined into one line I think this is a matter of style, but I've amended it to below, which I assume is OK - I have no strong opinions. + (setenv + "PYTHONPATH" + (string-append (getenv "PYTHONPATH")":" out "/lib/python" + (string-take (string-take-right + (assoc-ref inputs "python") 5) 3) + "/site-packages")) > >> + (string-take (string-take-right >> + (assoc-ref inputs "python") 5) 3) >> + "/site-packages")) >> + (zero? >> + (system* >> + (string-append out "/bin/py.test") "test_pep8.py")))))))) >> + (propagated-inputs >> + `(("python-pytest-cache", python-pytest-cache) >> + ("python-pytest" ,python-pytest) >> + ("python-pep8" ,python-pep8))) > Are you sure all of these need to be propagated? That's what the install_requires in setup.py is telling me. Thanks, ben